Skip to content

feat(bin): add photo and video uploaders - #31

Merged
icco merged 7 commits into
mainfrom
feat/photo-upload
Oct 22, 2026
Merged

icco merged 7 commits into
mainfrom
feat/photo-upload

Conversation

@icco

@icco icco commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Why

Adds bin/photo and bin/video, which upload to photos.natwelch.com and videos.natwelch.com, print the URLs, and copy them to the clipboard. gifme now builds with magick and uploads through photo instead of CloudApp.

Risks

Both need jq. video predicts the watch URL from the job id and the current UTC year, and it 404s until conversion finishes.

icco and others added 5 commits October 22, 2026 22:53
Quote expansions in gifme, kubectl-ssh, and suitup, loop over project roots in suitup, and disable SC1071 so zsh scripts stop erroring in the LSP.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
.shellcheckrc is not found when an LSP lints via stdin from another directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Switch brewup, daily, dbr, git-adopt, set_ip, and screenshots to bash so shellcheck covers them, fix the findings, and syntax check the remaining zsh scripts with zsh -n in CI. CI now only lints shell files and fails on findings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
photo posts images to photos.natwelch.com, prints the URLs, and copies them to the clipboard. gifme now builds with magick and uploads through photo instead of CloudApp.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@icco
icco marked this pull request as ready for review October 22, 2026 23:05
@icco
icco requested a balanced review from Copilot October 22, 2026 23:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Multipart filename handling can cause valid image paths to fail or upload unintended files.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

video posts to videos.natwelch.com and prints the watch URLs. Both uploaders quote filenames so commas and semicolons reach the server intact, and print the server's error message on failure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@icco icco changed the title feat(bin): add photo uploader and use it in gifme feat(bin): add photo and video uploaders Oct 22, 2026
@icco

icco commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

Fixed in b5c65c1: filenames are now quoted in the curl form field, so commas and semicolons upload intact.

@icco
icco requested a balanced review from Copilot October 22, 2026 23:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@icco
icco requested a balanced review from Copilot October 22, 2026 23:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@icco
icco merged commit b27a832 into main Oct 22, 2026
5 checks passed
@icco
icco deleted the feat/photo-upload branch October 22, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants