[icco]

Why

Fixes shellcheck findings in bin/ and moves brewup, daily, dbr, git-adopt, set_ip, and screenshots from zsh to bash so shellcheck covers them. clean.sh (uses **) stays zsh with an inline SC1071 disable.

CI shellcheck now lints only shell shebangs and fails on findings (find -exec \; swallowed them), and adds zsh -n for the zsh scripts. Includes the unpushed suitup HFP to logo.dev commit from local main.

Risks

set_ip now creates the domain dir before cd, and brewup runs its dotfiles step in a subshell instead of cd -.

[Copilot]

🟢 Approval recommended

The focused shell-script and CI changes have no identified blocking correctness or compatibility issues.

No open issues 🎉

What changed in this PR

This PR addresses ShellCheck warnings in the repository’s utility scripts and strengthens shell validation in CI.

Changes:

• Converts six scripts from zsh to Bash and improves argument quoting and directory-change handling.
• Consolidates suitup directory traversal and replaces ~/HFP/ with ~/logo.dev/.
• Makes CI’s bin/ ShellCheck step fail on findings and adds zsh syntax checks.

File	Description
bin/​suitup	Quotes paths, consolidates traversal, and updates the project directory.
bin/​set_ip	Switches to Bash and creates the domain directory before entering it.
bin/​screenshots	Switches the interpreter to Bash.
bin/​kubectl-ssh	Quotes arguments passed to kubectl commands.
bin/​git-adopt	Switches the interpreter to Bash.
bin/​gifme	Preserves argument boundaries and quotes output paths.
bin/​dbr	Switches to Bash and quotes Docker arguments.
bin/​daily	Switches to Bash and exits if the directory change fails.
bin/​clean.sh	Adds an SC1071 suppression while retaining zsh.
bin/​brewup	Switches to Bash and isolates the dotfiles step in a subshell.
.github/​workflows/​ci.yml	Filters shell scripts, propagates ShellCheck failures, and adds zsh syntax checks.

_{Review effort: Balanced}