Skip to content

fix: use the labeled image select on the VTA pools page - #103

Merged
vthwang merged 1 commit into
mainfrom
fix/pool-image-select
Oct 17, 2026
Merged

vthwang merged 1 commit into
mainfrom
fix/pool-image-select

Conversation

@geoffturk

Copy link
Copy Markdown
Member

The VTA pools page (/admin/pools) landed in #100 alongside #99 and kept the native <select> with the old (latest) suffix, so it didn't show the nightly/main channel tags or build date like the rest of the site.

Changes

  • Switch the VTA image picker in PoolBatchesView to the shadcn Select, using imageLabel for option text (e.g. 0.61.0-648f27e4 [nightly] 2026-10-15).
  • Constrain the menu to the trigger width with a capped, scrollable height, matching Create VTA.
  • Show a disabled "Loading images…" field until images arrive.
  • Type the image list as ImageOption[].

Default selection (latest release) and the disabled-while-creating behavior are unchanged.

Testing

  • tsc --noEmit and ESLint pass.

Signed-off-by: Geoff Turk geoff@ic3.dev

The pools page landed alongside the image labeling change and kept the
native select with the old "(latest)" suffix. Switch it to the shadcn
Select with imageLabel, matching the Create VTA and Platform Stack
screens: channel tags, build date, trigger-width constrained menu, and
a disabled placeholder while images load.

Signed-off-by: Geoff Turk <geoff@ic3.dev>
@geoffturk
geoffturk requested a review from vthwang October 16, 2026 12:16
@vthwang
vthwang merged commit 12f903f into main Oct 17, 2026
1 check passed
@vthwang
vthwang deleted the fix/pool-image-select branch October 17, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants