Repository navigation
fix(ghcr): list latest, nightly and main images ahead of the rest - #86
Merged
Merged
Conversation
ListTags sorted every tag newest-first and then swapped the latest row with whatever was first. When nightly was the newest build, the swap moved latest to the top and dropped nightly into latest's old slot, below main and unchanneled builds. Nightly and main were never placed on purpose. - internal/ghcr/client.go: replace the swap with a stable sort by channel rank (latest, nightly, main, then the rest), so unchanneled tags keep their newest-first order and undated tags stay last. A build carrying several channels takes its highest-ranked slot. result[0] is still the latest row, so frontends default as before. - internal/ghcr/client_test.go: cover the nightly-newest case, a build flagged both nightly and main, a missing channel, and no channels. Signed-off-by: Geoff Turk <geoff@ic3.dev>
vthwang
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListTagssorted every tag newest-first and then swapped the latest row with whatever was first. When nightly was the newest build, the swap moved latest to the top and dropped nightly into latest's old slot, below main and unchanneled builds. Nightly and main were never placed on purpose.internal/ghcr/client.go: replace the swap with a stable sort by channel rank (latest, nightly, main, then the rest), so unchanneled tags keep their newest-first order and undated tags stay last. A build carrying several channels takes its highest-ranked slot.result[0]is still the latest row, so frontends default as before.internal/ghcr/client_test.go: cover the nightly-newest case, a build flagged both nightly and main, a missing channel, and no channels.Tested locally against GHCR via the portal's image dropdowns.