Skip to content

[patch] add storage class selection to prevent invalid storageClassName on config-pvc for upgrade - #2565

Merged
dixitgsathwara merged 11 commits into
masterfrom
ds-upgrade
Aug 31, 2026
Merged

[patch] add storage class selection to prevent invalid storageClassName on config-pvc for upgrade#2565
dixitgsathwara merged 11 commits into
masterfrom
ds-upgrade

Conversation

@dixitgsathwara

@dixitgsathwara dixitgsathwara commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Before this change, the upgrade command had no storage class selection step. It attempted to detect the storage provider automatically, but returned None for unrecognised providers. This None was passed to preparePipelinesNamespace and rendered as the string "None" in the Kubernetes manifest, causing a 422 error on the config-pvc.

  • Added storage class selection to the upgrade flow with the following behaviour:

    • --storage-pipeline and --storage-accessmode args override everything when provided
    • If the pipelines namespace already has a config-pvc --> read its storageClassName directly
    • If no config-pvc exists --> auto-detect the storage provider and suggest RWO/RWX classes
    • If auto-detect fails or user declines --> prompt for RWO and RWX storage classes manually

Jira Issue

Guidance for Reviewers

Testing

  • if an existing config-pvc is found in the pipelines namespace, the storage class is read directly from it and used without prompting the user
    image

  • auto detected storage class
    image

  • when the auto-detected storage class is declined, the upgrade command lists all available storage classes on the cluster and prompts the user to enter the name of the ReadWriteMany( access mode is selected based on isSNO or not) storage class
    image

  • If the entered storage class does not exist on the cluster, the prompt will reject the input with "Specified storage class is not available on this cluster" and ask the user to try again.
    image

@dixitgsathwara
dixitgsathwara requested a review from a team as a code owner August 27, 2026 18:28
@dixitgsathwara
dixitgsathwara merged commit 0de1ead into master Aug 31, 2026
11 checks passed
@dixitgsathwara
dixitgsathwara deleted the ds-upgrade branch August 31, 2026 05:43
karol-czarnecki added a commit that referenced this pull request Sep 7, 2026
@karol-czarnecki
Squashed commit of the following:
a9a2528 
commit 7c9e670
Author: Ian Boden <82514609+IanBoden@users.noreply.github.com>
Date:   Mon Sep 7 07:46:44 2026 +0100

    re-enable path based routing for specific catalogs (#2577)

commit 6d77ba5
Author: mnivedithaa <mnivedithaa@gmail.com>
Date:   Thu Sep 3 16:58:16 2026 +0530

    [patch] Gitops operator update to 1.20 (#2581)

commit e27070c
Author: yohlema <86248178+yohlema@users.noreply.github.com>
Date:   Thu Sep 3 02:36:20 2026 -0400

    [patch] added smartcleanse test suite to fvt dashboard (#2575)

commit 54dba34
Author: Parveen Kumar <parveenkumar@ibm.com>
Date:   Wed Sep 2 19:04:56 2026 +0530

    [minor] Support September Interim Catalog Update (#2570)

commit 3fb12a9
Author: mnivedithaa <mnivedithaa@gmail.com>
Date:   Wed Sep 2 16:13:56 2026 +0530

    [patch] fvtsaas ROSA cluster stuck in uninstalling state (#2574)

commit 3d00fbc
Author: Parveen Kumar <parveenkumar@ibm.com>
Date:   Tue Sep 1 22:00:24 2026 +0530

    [doc] Update Cloud Pak for Data compatibility to v5.3.1 (#2571)

commit 0de1ead
Author: AquaD17 <112812380+dixitgsathwara@users.noreply.github.com>
Date:   Mon Aug 31 11:13:33 2026 +0530

    [patch] add storage class selection to prevent invalid storageClassName on config-pvc for upgrade (#2565)

    Co-authored-by: Dixit Sathwara <Dixit.Sathwara1@ibm.com>

commit 8728800
Author: Adit <adit@ibm.com>
Date:   Fri Aug 28 13:46:23 2026 +0530

    [minor] Add SLS pod template YAML support for LicenseService CR in gitops (#2546)

commit 98d3d4b
Author: sdoshi96 <shyamdoshi99@gmail.com>
Date:   Fri Aug 28 11:24:35 2026 +0530

    [minor] Added facilities platform logs in must-gather (#2561)

    Co-authored-by: Shyam Doshi <Shyam.Doshi@ibm.com>
    Co-authored-by: dushyantbangal <dushyantbangal@gmail.com>

commit 5de9e0f
Author: Parveen Kumar <parveenkumar@ibm.com>
Date:   Thu Aug 27 20:16:06 2026 +0530

    [minor] Support August Catalog Update (#2497)

    Co-authored-by: Anil Prajapati <Anil.Prajapati@ibm.com>
    Co-authored-by: shimto-jacob-siby <shimto.jacob.siby@ibm.com>

commit 9edb93f
Author: Pal Vala <valapal2005@gmail.com>
Date:   Wed Aug 26 13:52:30 2026 +0530

    [patch] upgrade : correct channel resolution for partial upgrade resumption (#2527)

commit 9b1e106
Author: Divyesh-Khokhar <divyesh.k@ibm.com>
Date:   Wed Aug 26 13:17:47 2026 +0530

    [minor] Default to RHOAI and remove ODH/RHOAI interactive prompt (#2552)

commit f286c87
Author: Sharan-Robinson-IBM <sharan.robinson@ibm.com>
Date:   Mon Aug 24 09:21:43 2026 -0500

    [patch] Add filters to tekton definitions for mas restore command (#2549)

commit bab71f3
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Mon Aug 24 11:35:44 2026 +0100

    [doc] update supported versions in B&R guides (#2553)

commit 83c5a44
Author: kushwahck-ibm <kushwah.chiranjiv@ibm.com>
Date:   Fri Aug 21 13:05:29 2026 +0530

    [patch] Support ClusterIssuer selection based on environment type in gitops (#2494)

commit 815179d
Author: nehasangwai-ibm <Neha.Sangwai@ibm.com>
Date:   Fri Aug 21 00:03:54 2026 +0530

    [patch] CP4D 5.3.1 Helm airgapped install support (#2537)

    Co-authored-by: Prajesh Jain <Prajesh.Jain@ibm.com>
    Co-authored-by: SahilSheikh1 <sahilsheikh6897@gmail.com>
    Co-authored-by: SahilSheikh1 <68754786+SahilSheikh1@users.noreply.github.com>
    Co-authored-by: David Parker <parkerda@uk.ibm.com>
    Co-authored-by: akashbogam <87757632+akashbogam@users.noreply.github.com>
    Co-authored-by: Andrew Foster <163020579+gbanfo@users.noreply.github.com>
    Co-authored-by: Andrew Whitfield <whitfiea@uk.ibm.com>
    Co-authored-by: Jeel-Oza <jeel.hp.87@gmail.com>
    Co-authored-by: Jeel Oza <Jeel.Oza@ibm.com>
    Co-authored-by: Pal Vala <valapal2005@gmail.com>
    Co-authored-by: Pal Valaexit <Pal.Vala@ibm.com>
    Co-authored-by: karol-czarnecki <112193189+karol-czarnecki@users.noreply.github.com>
    Co-authored-by: Társis Augusto <64480693+terc1997@users.noreply.github.com>
    Co-authored-by: yohlema <86248178+yohlema@users.noreply.github.com>
    Co-authored-by: mnivedithaa <mnivedithaa@gmail.com>
    Co-authored-by: Nikita Kumble <47314239+nikitakumble@users.noreply.github.com>
    Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>
    Co-authored-by: MaxRobak <61717686+MaxRobak@users.noreply.github.com>
    Co-authored-by: Parveen Kumar <parveenkumar@ibm.com>
    Co-authored-by: Ian Boden <82514609+IanBoden@users.noreply.github.com>
    Co-authored-by: Divyesh-Khokhar <divyesh.k@ibm.com>
    Co-authored-by: Matheus Cardoso de Medeiros <38898699+RexMCM@users.noreply.github.com>
    Co-authored-by: Matheus Cardoso de Medeiros <Matheus.Cardoso@ibm.com>
    Co-authored-by: Harsh Tamakuwala <Harsh.Tamakuwala@ibm.com>
    Co-authored-by: Nivedithaa Mahendran <nivedithaa.mahendran@ibm.com>
    Co-authored-by: abhirup-choudhury015 <abhirup.choudhury@ibm.com>
    Co-authored-by: Raj Bhavsar <rajbhavsar909@gmail.com>
    Co-authored-by: Raj Bhavsar <Raj.Bhavsar@ibm.com>
    Co-authored-by: leo-miran <105313348+leo-miran@users.noreply.github.com>
    Co-authored-by: Leonardo Miranda <Leo.Miranda@ibm.com>

commit 24ed626
Author: Divyesh-Khokhar <divyesh.k@ibm.com>
Date:   Wed Aug 19 17:55:16 2026 +0530

    [patch] update channel env var name to AISERVICE_CHANNEL in rhoai.yml.j2 (#2544)

commit 371cf71
Author: Aneri Thakkar <121008198+Aneri11U@users.noreply.github.com>
Date:   Wed Aug 19 15:36:01 2026 +0530

    [patch] Disable setting up routingMode for Aug release (#2541)

commit e1875bf
Author: Sakshi-Singhroha1 <Sakshi.Singhroha@ibm.com>
Date:   Tue Aug 18 14:45:52 2026 +0530

    [minor] Add ibm-ca.yaml.j2 template for Cognos Analytics CP4D service in gitops (#2536)

commit 833405f
Author: Jvaneel Dwivedi <jvaneel.dwivedi.ibm@gmail.com>
Date:   Mon Aug 17 16:31:54 2026 +0530

    [patch] Extend Monitor FVT 9.3.x support  (#2532)

    Co-authored-by: Jvaneel Dwivedi <jvaneel.dwivedi@ibm.com>

commit 5cbbf99
Author: Jvaneel Dwivedi <jvaneel.dwivedi.ibm@gmail.com>
Date:   Fri Aug 14 18:57:42 2026 +0530

    [patch] Increase MAX_RETRIES for launchfvt-predict from 50 to 72 (#2530)

    Co-authored-by: Jvaneel Dwivedi <jvaneel.dwivedi@ibm.com>

commit 25d5143
Author: Joe Harte <josefharte@gmail.com>
Date:   Fri Aug 14 10:48:00 2026 +0100

    [minor] AI Service tenant operator customization (#2489)

    Co-authored-by: Josef Harte <josefharte@Josefs-MacBook-Pro.local>
    Co-authored-by: Josef Harte <josefharte@dhcp-9-224-176-118.iea-ie.ibm.com>
    Co-authored-by: Josef Harte <josefharte@dhcp-9-224-174-150.iea-ie.ibm.com>

commit 120771a
Author: aadawadk <114399757+aadawadk@users.noreply.github.com>
Date:   Wed Aug 12 18:01:18 2026 +0530

    [patch] reenable routingMode (#2518)

    Co-authored-by: Ian Boden <82514609+IanBoden@users.noreply.github.com>
    Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>
rmakkena-1 pushed a commit that referenced this pull request Sep 24, 2026
@dixitgsathwara Dixit Sathwara @rmakkena-1
[patch] add storage class selection to prevent invalid storageClassNa…
3023cee 
…me on config-pvc for upgrade (#2565)

Co-authored-by: Dixit Sathwara <Dixit.Sathwara1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terenceq terenceq terenceq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dixitgsathwara @terenceq