IBX-12374: Enabled the Behat annotations-to-attributes set in the shared Rector configuration factory - #53
Merged
Conversation
…red Rector configuration factory
konradoboza
approved these changes
Sep 8, 2026
KamilSznajdrowicz
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Phase-5 cleanup of the Behat 4 upgrade (ibexa/behat#200). Behat 4 removed annotation support, so every repository must use PHP attributes for step definitions and hooks. The per-repository
rector.phpfiles got a->withAttributesSets(behat: true)guard during the migration; this adds the same guard to the sharedIbexaRectorConfigFactoryso factory-based configurations are covered too, and new repositories get it for free.Registers
SetList::BEHAT_ANNOTATIONS_TO_ATTRIBUTES— a no-op on code that already uses attributes, converts any reintroduced annotation.For QA:
IbexaRectorConfigFactoryTestupdated and green; phpstan and code style clean.Documentation:
N/A