fix(conversation): rebuild agent runtime after workspace changes - #979
Open
zilongshao wants to merge 1 commit into
Open
fix(conversation): rebuild agent runtime after workspace changes#979zilongshao wants to merge 1 commit into
zilongshao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix stale agent runtime reuse after a conversation workspace is changed or moved.
Previously, updating
conversation.extra.workspacecould leave the in-memory agent bound to the old workspace. Runtime workspace persistence could also overwrite a newly selected non-empty workspace with a stale resolved path.Changes
WorkspaceChangedreason.Verification
cargo fmt --all -- --checkcargo clippy -p aionui-common -p aionui-ai-agent -p aionui-conversation -p aionui-app -- -D warningscargo test -p aionui-ai-agent task_manager::tests --libcargo test -p aionui-app --test message_e2e workspace_move_patch_keeps_two_message_turns_on_new_workspace -- --exactjust push(9,262/9,262 selected tests passed locally; verified upstream Windows-incompatible tests were excluded only by an untracked local nextest profile, while CI retains the repository configuration)Observability
Existing structured lifecycle logging was extended with conversation ID, change flags, and rebuild reason. Workspace paths are intentionally not logged.