pam: delay auth init until grace period expires - #1069
Open
deivi98 wants to merge 1 commit into
Open
Conversation
During a grace period, hyprlock allows unlocking via mouse movement or a keypress without completing PAM authentication. However, PAM (and therefore any module in the stack, e.g. pam_u2f) was being initialised immediately on startup regardless of grace, causing FIDO2 security keys to light up and wait for a touch that is never needed when the user unlocks during grace. Fix this by waiting at the start of CPam::init()'s thread until the grace period wall-clock time has elapsed before calling into pam_authenticate(). The wait uses the existing inputSubmittedCondition condvar so that terminate() wakes the thread immediately if the session is unlocked (via grace, SIGUSR1, etc.) before the grace period ends, avoiding a hang on exit.
Author
|
Tested locally and it works, even with system suspend mid grace period |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a grace period, hyprlock allows unlocking via mouse movement or a keypress without completing PAM authentication. However, PAM (and therefore any module in the stack, e.g. pam_u2f) was being initialised immediately on startup regardless of grace, causing FIDO2 security keys to light up and wait for a touch that is never needed when the user unlocks during grace.
Fix this by waiting at the start of CPam::init()'s thread until the grace period wall-clock time has elapsed before calling into pam_authenticate(). The wait uses the existing inputSubmittedCondition condvar so that terminate() wakes the thread immediately if the session is unlocked (via grace, SIGUSR1, etc.) before the grace period ends, avoiding a hang on exit.