You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CHANGELOG.md (or repo-specific changelog) updated with an entry
package.json / package version updated if publishing a release
No secrets or credentials committed
Security review completed if required
Performance benchmarks included if applicable
Migration steps included if applicable
Reviewer Guidance
List the specific areas you want reviewers to focus on (e.g., security, migration, public API, edge cases). Provide commands or steps to run the project locally to validate the change:
# checkout PR branch
git checkout $BRANCH# run tests
npm ci && npm test# run lint
npm run lint
Acceptance Criteria
Define the minimal conditions that must be true for this PR to be merged (e.g., tests pass, performance threshold met, migration completed).
validateField() {
this.widgetConfigTemp.isWidgetLogin = this.widgetConfigTemp.isWidgetLogin !== false
this.widgetConfigTemp.isVaultEnabled = this.widgetConfigTemp.isWidgetLogin}
basically at present i am storing the value of isWidgetLogin in isVaultEnabled field as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Provide a short, descriptive title of the change (50 characters max recommended).
Summary
One-paragraph summary describing what the change does and why. Link related issue(s) or design docs.
Background / Motivation
Explain the context, problem being solved, and any alternatives considered. Include links to design docs, issues, or RFCs.
Scope of Changes
Type
Implementation
Describe the approach taken, key design decisions, and why.
Testing & QA
Migration / Rollout Plan
Security / Privacy Considerations
List any security implications, new secrets, or compliance-related items.
Performance Impact
Any benchmark results or expected performance regressions/improvements.
Release Notes (for changelog)
One-line summary suitable for release notes / CHANGELOG.
Checklist (required)
package.json/ package version updated if publishing a releaseReviewer Guidance
List the specific areas you want reviewers to focus on (e.g., security, migration, public API, edge cases). Provide commands or steps to run the project locally to validate the change:
Acceptance Criteria
Define the minimal conditions that must be true for this PR to be merged (e.g., tests pass, performance threshold met, migration completed).
Approvals