Skip to content

Updated id widget#194

Open
varsha766 wants to merge 3 commits into
developfrom
feature/widget-enhancement
Open

Updated id widget#194
varsha766 wants to merge 3 commits into
developfrom
feature/widget-enhancement

Conversation

@varsha766

Copy link
Copy Markdown
Collaborator

Title

Provide a short, descriptive title of the change (50 characters max recommended).

  • Added toggel to disable widget login

Summary

One-paragraph summary describing what the change does and why. Link related issue(s) or design docs.


Background / Motivation

Explain the context, problem being solved, and any alternatives considered. Include links to design docs, issues, or RFCs.


Scope of Changes

  • Files / modules affected (high level)
  • Public API changes (if any)
  • Database / schema / migration impact (if any)

Type

  • Feature
  • Bugfix
  • Docs
  • Refactor
  • Tests
  • Performance
  • Build / CI / Config

Implementation

Describe the approach taken, key design decisions, and why.


Testing & QA

  • Units / integration tests added: describe coverage and important test cases
  • Manual / exploratory test steps for QA
  • CI matrix: platforms/versions validated

Migration / Rollout Plan

  • Data migrations and downtime expectations
  • Backwards compatibility notes
  • Feature flags and staged rollout instructions

Security / Privacy Considerations

List any security implications, new secrets, or compliance-related items.


Performance Impact

Any benchmark results or expected performance regressions/improvements.


Release Notes (for changelog)

One-line summary suitable for release notes / CHANGELOG.


Checklist (required)

  • Linked issue or ticket present (link: )
  • Target branch is correct
  • PR description explains the why, not just the what
  • Code compiles and tests pass locally
  • Unit and integration tests added where applicable
  • Documentation updated (README, docs site, comments)
  • CHANGELOG.md (or repo-specific changelog) updated with an entry
  • package.json / package version updated if publishing a release
  • No secrets or credentials committed
  • Security review completed if required
  • Performance benchmarks included if applicable
  • Migration steps included if applicable

Reviewer Guidance

List the specific areas you want reviewers to focus on (e.g., security, migration, public API, edge cases). Provide commands or steps to run the project locally to validate the change:

# checkout PR branch
git checkout $BRANCH
# run tests
npm ci && npm test
# run lint
npm run lint

Acceptance Criteria

Define the minimal conditions that must be true for this PR to be merged (e.g., tests pass, performance threshold met, migration completed).


Approvals

  • At least one approving review from code owners
  • CI status checks are green
  • Any required manual QA sign-off

@varsha766 varsha766 requested review from Pratap2018 and Vishwas1 and removed request for Pratap2018 June 18, 2026 14:44
Comment thread src/views/playground/WidgetConfig/Index.vue Outdated
Comment thread src/views/playground/WidgetConfig/Index.vue Outdated
@Vishwas1

Vishwas1 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

can you test if we are doing this behaviour:

  • If login toggle is enabled -> enable vault
  • If login toggle is disabled -> disable vault

I could not see any code releated to this behaviour.

We might beed to implement a watcher which will:

IF isWidgetLogin is set = true
the watch make the ifVaultEnabled = true

IF isWidgetLogin is set = false
the watch make the ifVaultEnabled = false

@varsha766

@varsha766

varsha766 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

can you test if we are doing this behaviour:

* If login toggle is enabled -> enable vault

* If login toggle is disabled -> disable vault

I could not see any code releated to this behaviour.

We might beed to implement a watcher which will:

IF isWidgetLogin is set = true the watch make the ifVaultEnabled = true

IF isWidgetLogin is set = false the watch make the ifVaultEnabled = false

@varsha766

validateField() {
this.widgetConfigTemp.isWidgetLogin = this.widgetConfigTemp.isWidgetLogin !== false
this.widgetConfigTemp.isVaultEnabled = this.widgetConfigTemp.isWidgetLogin}
basically at present i am storing the value of isWidgetLogin in isVaultEnabled field as well

Comment thread src/views/playground/WidgetConfig/Index.vue
@varsha766 varsha766 requested a review from Vishwas1 June 19, 2026 04:46
@@ -391,6 +405,12 @@ export default {
},
deep: true
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment on top

// Sync: Vault is only enabled when widget login is enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants