Skip to content

Proposal 0007: name tokenOf's argument so gitleaks stops flagging it - #291

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/new-session-ywdrth-0007-gitleaks
Nov 17, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/new-session-ywdrth-0007-gitleaks

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

scan / gitleaks (Secret-Scan-Floor, a required check) fails on main and on every open PR. Its only finding is in docs/proposals/0007-affine-grade-mode-record-borrow-axis.adoc, which arrived in #286.

The CI log names the file but not the line. I ran the default generic-api-key rule as a perl approximation, with gitleaks' 3.5-bit entropy threshold, over the file. One line matches, line 346:

tokenOf : OwnershipIntentV2 -> Maybe Nat

The rule reads it as token…: <value>, and the value OwnershipIntentV2 has an entropy of 3.57.

Change

  • The sketch now reads tokenOf : (intent : OwnershipIntentV2) -> Maybe Nat. The type is unchanged. The ( stops the rule from matching.
  • The note on the sketch records that it was rechecked on 2026-11-16.
  • CHANGELOG entry added.

No suppression or allowlist entry was added, and no scanner setting changed.

Evidence

  • I extracted the sketch (lines 259–372) as Proposal/OwnershipMode.idr beside src/abi/ and ran idris2 --check with Idris2 0.8.0. It built (7/7: Building Proposal.OwnershipMode) with no errors.
  • The same perl rule finds nothing in the edited file or in the added CHANGELOG lines.
  • The perl rule is an approximation. Only this PR's scan / gitleaks run confirms the fix.

Generated by Claude Code

…g it

The sketch's signature `tokenOf : OwnershipIntentV2 -> Maybe Nat` matched
the scanner's generic-api-key rule (a `token` name, a colon, then a
high-entropy word), so `scan / gitleaks` failed on main and on every pull
request. The signature now names its argument; the type is unchanged.
The extracted sketch was rechecked with Idris2 0.8.0 (`idris2 --check`).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated the proposal documentation to record an additional check of its Idris sketch on 16 November 2026.
    • Clarified the name used for the tokenOf argument; its input and return types remain unchanged.
    • Added an Unreleased changelog entry noting the argument name, unchanged type and Idris2 version used for the check.

The proposal sketch now names the tokenOf argument intent, with its types unchanged. It records a recheck date of 2026-11-16. The changelog notes the argument naming and the Idris2 0.8.0 check.

Changes: Proposal 0007 update

Layer / File(s) Summary
Update sketch and changelog
docs/proposals/0007-affine-grade-mode-record-borrow-axis.adoc, CHANGELOG.adoc
The sketch names the tokenOf argument intent without changing its input or return types. It adds a recheck date of 2026-11-16. The changelog records the naming and Idris2 0.8.0 check.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to becd5

This is a documentation-only rename of a function argument in a proposal sketch, with no runtime impact. Whether it clears the secret-scanner check will be shown by the PR's own scan run.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: renaming the argument of tokenOf in Proposal 0007 so gitleaks stops flagging it. The changeset does exactly this, and the title states the reason. It is specific and c…
Description check Passed The description covers the problem, the change, and the evidence. It explains why gitleaks fails, what the change does, that no suppression was added, and how the sketch was checked with Idris2 0.8.0.…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: renaming the argument of tokenOf in Proposal 0007 so gitleaks stops flagging it. The changeset does exactly this, and the title states the reason. It is specific and concise.

Full details: Description check

Explanation

The description covers the problem, the change, and the evidence. It explains why gitleaks fails, what the change does, that no suppression was added, and how the sketch was checked with Idris2 0.8.0. It does not fill in the repository template's Testing section headings or the RSR Quality Checklist. The required checklist items, such as tests, formatting, linter, SPDX headers, and secrets, are not ticked or addressed. The Summary and Changes sections are present in substance, but the template's structure is not followed. The description is mostly complete, so the check passes, with a note on the missing checklist.

Resolution

Optionally, add the template headings (Summary, Changes, RSR Quality Checklist, Testing) and tick or address the checklist items, including the CHANGELOG item, which this PR covers.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 99805fd0-84fb-492d-8bc3-caf8b17cb1e6
Commits

Reviewing files that changed from the base of the PR and between 2f3f7c8 and becd523.

Files selected for processing: 2

  • CHANGELOG.adoc
  • docs/proposals/0007-affine-grade-mode-record-borrow-axis.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 23

  • GitHub Check: Dogfooding compliance summary
  • GitHub Check: CodeRabbit
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / JS runtimes — deno
  • GitHub Check: governance / JS runtimes — pnpm
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / UUID v8 conformance
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / JS runtimes — environment provisions Bun first
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / UUID v7 conformance
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: Patch Bridge CVE triage
  • GitHub Check: Hypatia neurosymbolic scan
  • GitHub Check: Grade kernel proofs (Idris2 0.8.0 + Agda)
  • GitHub Check: Layering contract (I1 + I3)
  • GitHub Check: Cargo audit (RustSec advisories)
Additional context used

Code guidelines: 1

.github/copilot-instructions.md — auto-discovered
Path-based instructions: 1

Source excerpt: Annotate and document all files.

CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • CHANGELOG.adoc
  • docs/proposals/0007-affine-grade-mode-record-borrow-axis.adoc
Additional comments: 1

docs/proposals/0007-affine-grade-mode-record-borrow-axis.adoc: 1

346-346: Stability & Availability

The decisive premise is the gitleaks scan range. The checkout does not contain the job that runs scan / gitleaks, so this cannot be decided from the repository. Whether the rename leaves the required check failing depends on whether that job scans history containing the original tokenOf addition. Confirming it needs the workflow definition, or the result of this PR's scan / gitleaks run.

@sonarqubecloud

Copy link
Copy Markdown

@linear-code
linear-code Bot marked this pull request as ready for review November 16, 2026 23:24
@hyperpolymath
hyperpolymath merged commit 2955ea3 into main Nov 17, 2026
49 checks passed
@hyperpolymath
hyperpolymath deleted the claude/new-session-ywdrth-0007-gitleaks branch November 17, 2026 16:44
hyperpolymath pushed a commit that referenced this pull request Nov 17, 2026
CHANGELOG: keep both entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
hyperpolymath pushed a commit that referenced this pull request Nov 17, 2026
CHANGELOG: keep both entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y6FD63UrriRBHqmhhEca9t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants