Repository navigation
fix(hypatia): pass the grid's scanner pin to the reusable; port the edge checker - #20
Conversation
…dge checker Squabble's check-workflow-edges failed on main after the mint (#17) for two reasons: * A real defect: hypatia-scan.yml calls metadatastician/standards/.github/workflows/hypatia-scan-reusable.yml at 46ee183 without `hypatia-ref`, so the scan runs that workflow's default Hypatia (adb2f41), while fork-governance.yml and verdict-grid-publish.yml grade its findings as --hypatia-ref be98f74. The caller now passes `hypatia-ref: be98f74...`, the grid's pin. * A checker blind spot: it looked for the hypatia-scan-findings upload in hypatia-scan.yml itself, but the reusable uploads it. Fixed at source in hyperpolymath/rsr-template-repo#290 (b31c166, ff922d4); this ports scripts/check-workflow-edges.sh and tests/workflows/workflow_edges_test.sh as they stand there. No-ops once a template update brings #290. bash scripts/check-workflow-edges.sh . -> all workflow edges resolve bash tests/workflows/workflow_edges_test.sh -> 46 PASS (the reusable is read live at 46ee183 from raw.githubusercontent.com) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs
|
Caution Review failedThe pull request is closed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
🟠 indeterminate · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high) — reported, never grading the change.
Hypatia scan: error — the scanner produced no findings array
panic-attack assail: 14 finding(s)
pons asinorum: 9 finding(s)
finishingbot (release readiness): 173 finding(s)
glambot (presentation quality): 93 finding(s)
rhodibot (RSR compliance): 13 finding(s)
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
#25) ## Summary This ports commit 8ffc72a from hyperpolymath/rsr-template-repo#290. That commit landed in the template after this repository's port, #20, had already merged without it. It clears the SonarCloud failure "C Security Rating on New Code" that #20 merged with. `reusable_source` in `scripts/check-workflow-edges.sh` fetches a called workflow with `curl -fsSL`. Because of `-L`, curl follows redirects to any protocol, so a redirect could downgrade the fetch to plain http. That is the SonarCloud annotation on line 150 ("Not enforcing HTTPS here might allow for redirections to insecure websites"). ## Changes - `scripts/check-workflow-edges.sh`: line 150 now passes `--proto =https --proto-redir =https` to curl, so both the request and any redirect must stay on https. ## RSR Quality Checklist ### Required - [x] Tests pass: `bash tests/workflows/workflow_edges_test.sh` passes 46 checks, and `bash scripts/check-workflow-edges.sh` passes on this tree. - [x] Code is formatted (one-line change) - [x] Linter is clean (no new warnings or errors) - [x] No banned language patterns - [x] No `unsafe` blocks without `// SAFETY:` comments - [x] No banned functions - [x] SPDX license headers present on all new/modified source files - [x] No secrets, credentials, or `.env` files included ### As Applicable Nothing here applies: this is a one-flag change to a check script. ## Testing - I ran the edge suite and the live checker, as listed above. - I fetched a pinned reusable from raw.githubusercontent.com with the restricted flags and the fetch succeeded. - The same change on the template turned SonarCloud's quality gate from failed to passed on #290. ## Known reds on `main`, not this PR's `main` (eee4e40) is red on three checks this PR does not touch: - **Canon lockstep.** metadatastician/standards' `canon.lock` moved to draft 2.1.5 on 2026-11-07, with a new gates hash. The deed declares 2.1.3. The template's main is red on the same check. The spine adopts first, per `[canon].order`. - **canary.** rhodibot reports one would-mutate finding, also on template main. - **estate-rules.** `just repo-init` on a Use-this-template child reports one unfilled token. --- _Generated by [Claude Code](https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs)_ --------- Co-authored-by: Claude <noreply@anthropic.com>




Summary
Squabble's
check-workflow-edgeshas been red onmainsince the mint (#17), for two reasons.A real defect.
hypatia-scan.ymlcallsmetadatastician/standards/.github/workflows/hypatia-scan-reusable.yml@46ee183withouthypatia-ref. So the scan runs the reusable's default Hypatia (adb2f41), whilefork-governance.ymlandverdict-grid-publish.ymlgrade its findings as--hypatia-ref be98f74. The grid was naming a scanner that didn't run.A checker blind spot. The checker looked for the
hypatia-scan-findingsupload insidehypatia-scan.ymlitself, but the reusable is what uploads it. That is fixed at source in hyperpolymath/rsr-template-repo#290, owner decision 2026-11-05.Changes
.github/workflows/hypatia-scan.yml: the call passeswith: hypatia-ref: be98f74ce93df200752f3798efa1305bfa3e0e10, the grid's pin, with a comment saying why.scripts/check-workflow-edges.shandtests/workflows/workflow_edges_test.sh: ported from #290 as they stand (b31c166,ff922d4). The port becomes a no-op once a template update brings #290.RSR Quality Checklist
Required
bash scripts/check-workflow-edges.sh .→ all workflow edges resolve;bash tests/workflows/workflow_edges_test.sh→ 46 PASS;check-lock-sync.sh→ in sync (theuses:line is unchanged).unsafeblocks.As Applicable
CHANGELOG: not touched.Testing
Local runs as above. The checker reads the reusable live at
46ee183from raw.githubusercontent.com. Its offline controls live in #290.Generated by Claude Code