Skip to content

fix(hypatia): pass the grid's scanner pin to the reusable; port the edge checker - #20

Merged
hyperpolymath merged 2 commits into
mainfrom
claude/hypatia-pin-caller
Nov 5, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
claude/hypatia-pin-caller

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Squabble's check-workflow-edges has been red on main since the mint (#17), for two reasons.

A real defect. hypatia-scan.yml calls metadatastician/standards/.github/workflows/hypatia-scan-reusable.yml@46ee183 without hypatia-ref. So the scan runs the reusable's default Hypatia (adb2f41), while fork-governance.yml and verdict-grid-publish.yml grade its findings as --hypatia-ref be98f74. The grid was naming a scanner that didn't run.

A checker blind spot. The checker looked for the hypatia-scan-findings upload inside hypatia-scan.yml itself, but the reusable is what uploads it. That is fixed at source in hyperpolymath/rsr-template-repo#290, owner decision 2026-11-05.

Changes

  • .github/workflows/hypatia-scan.yml: the call passes with: hypatia-ref: be98f74ce93df200752f3798efa1305bfa3e0e10, the grid's pin, with a comment saying why.
  • scripts/check-workflow-edges.sh and tests/workflows/workflow_edges_test.sh: ported from #290 as they stand (b31c166, ff922d4). The port becomes a no-op once a template update brings #290.

RSR Quality Checklist

Required

  • Tests pass: bash scripts/check-workflow-edges.sh . → all workflow edges resolve; bash tests/workflows/workflow_edges_test.sh → 46 PASS; check-lock-sync.sh → in sync (the uses: line is unchanged).
  • Code is formatted.
  • Linter is clean.
  • No banned language patterns.
  • No unsafe blocks.
  • No banned functions.
  • SPDX headers present (unchanged).
  • No secrets.

As Applicable

  • CHANGELOG: not touched.

Testing

Local runs as above. The checker reads the reusable live at 46ee183 from raw.githubusercontent.com. Its offline controls live in #290.


Generated by Claude Code

…dge checker

Squabble's check-workflow-edges failed on main after the mint (#17) for
two reasons:

* A real defect: hypatia-scan.yml calls
  metadatastician/standards/.github/workflows/hypatia-scan-reusable.yml at
  46ee183 without `hypatia-ref`, so the scan runs that workflow's default
  Hypatia (adb2f41), while fork-governance.yml and
  verdict-grid-publish.yml grade its findings as --hypatia-ref be98f74.
  The caller now passes `hypatia-ref: be98f74...`, the grid's pin.
* A checker blind spot: it looked for the hypatia-scan-findings upload in
  hypatia-scan.yml itself, but the reusable uploads it. Fixed at source in
  hyperpolymath/rsr-template-repo#290 (b31c166, ff922d4); this ports
  scripts/check-workflow-edges.sh and tests/workflows/workflow_edges_test.sh
  as they stand there. No-ops once a template update brings #290.

  bash scripts/check-workflow-edges.sh .         -> all workflow edges resolve
  bash tests/workflows/workflow_edges_test.sh    -> 46 PASS
  (the reusable is read live at 46ee183 from raw.githubusercontent.com)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Hypatia grid orange

🟠 indeterminate · commit 9e436941a514 · run 41989663202 · scope: this change (3 file(s))

Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high) — reported, never grading the change.

Reporter Gate Status Critical High Medium Minor Since previous revision
Hypatia scan gating 🟠 indeterminate 0 0 0 0 — no comparable baseline
panic-attack assail advisory 🟡 medium 0 0 1 0 — no comparable baseline
pons asinorum advisory 🟢 clean 0 0 0 0 — no comparable baseline
finishingbot (release readiness) advisory 🔴 high 0 9 5 0 — no comparable baseline
glambot (presentation quality) advisory 🔵 minor 0 0 0 5 — no comparable baseline
rhodibot (RSR compliance) advisory 🟢 clean 0 0 0 0 — no comparable baseline
accessibilitybot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
cipherbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
echidnabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
panicbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
seambot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
sustainabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
Hypatia scan: error — the scanner produced no findings array
  • 🟠 indeterminate: the scanner produced no findings array
panic-attack assail: 14 finding(s)
  • medium CommandInjection — scripts/check-workflow-edges.sh — 36 potentially unquoted variable expansions in scripts/check-workflow-edges.sh
  • 13 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
pons asinorum: 9 finding(s)
  • 9 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
finishingbot (release readiness): 173 finding(s)
  • high V1-DOC-ROADMAP.adoc — Required file ROADMAP.adoc not found (Project roadmap).
  • high TOOL-001 — .tool-versions file not found for asdf/mise version management.
  • high SCM-001-NEUROSYM.scm — Required SCM file NEUROSYM.scm not found (Neurosymbolic AI documentation).
  • high SCM-001-AGENTIC.scm — Required SCM file AGENTIC.scm not found (Agentic AI integration documentation).
  • high SCM-001-PLAYBOOK.scm — Required SCM file PLAYBOOK.scm not found (Operational playbooks and procedures).
  • high SCM-001-ECOSYSTEM.scm — Required SCM file ECOSYSTEM.scm not found (Project's place in the ecosystem).
  • high SCM-001-META.scm — Required SCM file META.scm not found (Meta-level information and architectural decisions).
  • high SCM-001-STATE.scm — Required SCM file STATE.scm not found (Project state and progress tracking).
  • high PH-100 — Found 124 placeholders, exceeds maximum allowed (0)
  • medium V1-COM-CONTRIBUTING.md — CONTRIBUTING.md file not found (Contribution guidelines).
  • medium V1-COM-CODE_OF_CONDUCT.md — CODE_OF_CONDUCT.md file not found (Code of conduct).
  • medium V1-SEC-001 — SECURITY.md not found for responsible disclosure.
  • medium TEST-001 — Could not determine if this is a Rust or Deno project.
  • medium REL-004 — No SECURITY.md file found
  • 159 further finding(s) in files this change does not touch: reported, not graded (0 critical, 3 high).
glambot (presentation quality): 93 finding(s)
  • info GS-001 — Install git-seo for comprehensive SEO analysis: https://github.com/hyperpolymath/git-seo
  • info MACH-007 — ECOSYSTEM.scm not found in .machine_readable/ directory.
  • info MACH-007 — META.scm not found in .machine_readable/ directory.
  • info MACH-007 — STATE.scm not found in .machine_readable/ directory.
  • info MACH-005 — No robots.txt found. Consider adding one for crawler control.
  • 88 further finding(s) in files this change does not touch: reported, not graded (0 critical, 2 high).
rhodibot (RSR compliance): 13 finding(s)
  • 13 further finding(s) in files this change does not touch: reported, not graded (0 critical, 12 high).
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
  • ⚪ not applicable: template default: enrol once the repository serves HTML
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
  • ⚪ not applicable: template default: enrol once the repository implements cryptography
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
  • ⚪ not applicable: template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
  • ⚪ not applicable: panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
  • ⚪ not applicable: template default: enrol once a seam register exists at spec/seams/seam-register.json
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
  • ⚪ not applicable: reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)

Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run.

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 5, 2026 10:58
@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 5, 2026 10:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T11:05:49.815844Z b7b715c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@hyperpolymath
hyperpolymath merged commit 42ac315 into main Nov 5, 2026
58 of 65 checks passed
@hyperpolymath
hyperpolymath deleted the claude/hypatia-pin-caller branch November 5, 2026 10:59
hyperpolymath added a commit that referenced this pull request Nov 10, 2026
#25)

## Summary

This ports commit 8ffc72a from hyperpolymath/rsr-template-repo#290. That
commit landed in the template after this repository's port, #20, had
already merged without it. It clears the SonarCloud failure "C Security
Rating on New Code" that #20 merged with.

`reusable_source` in `scripts/check-workflow-edges.sh` fetches a called
workflow with `curl -fsSL`. Because of `-L`, curl follows redirects to
any protocol, so a redirect could downgrade the fetch to plain http.
That is the SonarCloud annotation on line 150 ("Not enforcing HTTPS here
might allow for redirections to insecure websites").

## Changes

- `scripts/check-workflow-edges.sh`: line 150 now passes `--proto =https
--proto-redir =https` to curl, so both the request and any redirect must
stay on https.

## RSR Quality Checklist

### Required

- [x] Tests pass: `bash tests/workflows/workflow_edges_test.sh` passes
46 checks, and `bash scripts/check-workflow-edges.sh` passes on this
tree.
- [x] Code is formatted (one-line change)
- [x] Linter is clean (no new warnings or errors)
- [x] No banned language patterns
- [x] No `unsafe` blocks without `// SAFETY:` comments
- [x] No banned functions
- [x] SPDX license headers present on all new/modified source files
- [x] No secrets, credentials, or `.env` files included

### As Applicable

Nothing here applies: this is a one-flag change to a check script.

## Testing

- I ran the edge suite and the live checker, as listed above.
- I fetched a pinned reusable from raw.githubusercontent.com with the
restricted flags and the fetch succeeded.
- The same change on the template turned SonarCloud's quality gate from
failed to passed on #290.

## Known reds on `main`, not this PR's

`main` (eee4e40) is red on three checks this PR does not touch:

- **Canon lockstep.** metadatastician/standards' `canon.lock` moved to
draft 2.1.5 on 2026-11-07, with a new gates hash. The deed declares
2.1.3. The template's main is red on the same check. The spine adopts
first, per `[canon].order`.
- **canary.** rhodibot reports one would-mutate finding, also on
template main.
- **estate-rules.** `just repo-init` on a Use-this-template child
reports one unfilled token.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants