Repository navigation
fix(lock-sync): port rsr-template-repo#285 (same-SHA keys, job-level calls) - #19
Conversation
…calls) The mint (#17) carried rsr-template-repo#284's clause-5 exception. Codex review found two defects in it, fixed upstream in hyperpolymath/rsr-template-repo#285 (c438af6); this ports that fix as it stands. A self-SHA record is exempt only when its key is the same full SHA and it is the target of a job-level reusable call, read from the YAML position rather than the path's shape. No-ops once a template update brings #285. This repo's only exempt record, metadatastician/standards@46ee183, still passes: its key and ref are the same SHA and all six callers are job-level. bash scripts/check-lock-sync.sh -> in sync and transitively closed bash tests/workflows/check_lock_sync_test.sh -> 137 PASS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs
|
Caution Review failedThe pull request is closed. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
|
🟠 indeterminate · commit Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high) — reported, never grading the change.
Hypatia scan: error — the scanner produced no findings array
panic-attack assail: 14 finding(s)
pons asinorum: 9 finding(s)
finishingbot (release readiness): 173 finding(s)
glambot (presentation quality): 93 finding(s)
rhodibot (RSR compliance): 13 finding(s)
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19b093d386
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # every `steps:` block is a job-level reusable-workflow call. | ||
| if (line ~ /[^[:space:]]/) { | ||
| match(line, /^[[:space:]]*/); ind = RLENGTH | ||
| if (stepind >= 0 && ind <= stepind) stepind = -1 |
There was a problem hiding this comment.
Preserve step context for indentless YAML sequences
When a valid workflow formats a step sequence without extra indentation (steps: followed by - name: at the same column), this condition clears stepind on the sequence item. A later uses: key in that step has no leading dash and is therefore misclassified as a job-level reusable call when its action path resembles .github/workflows/*.yml. In that scenario, the checker incorrectly permits a self-SHA ref: for an action and exits successfully, defeating the guard this change is intended to add.
Useful? React with 👍 / 👎.



Summary
The mint (#17) carried the exception from hyperpolymath/rsr-template-repo#284 into
scripts/check-lock-sync.sh. Codex review found two defects in that exception, and both were mine:ref:;uses:sits in the YAML.They are fixed upstream in hyperpolymath/rsr-template-repo#285 (
c438af6). This PR ports that fix as it stands. It becomes a no-op once a template update brings #285.Changes
scripts/check-lock-sync.shandtests/workflows/check_lock_sync_test.sh: byte-identical to #285's.This repo's only exempt record,
metadatastician/standards@46ee183, still passes. Its key andref:are the same SHA, and all six callers are job-level.RSR Quality Checklist
Required
bash scripts/check-lock-sync.sh→ in sync and transitively closed;bash tests/workflows/check_lock_sync_test.sh→ 137 PASS.unsafeblocks.As Applicable
CHANGELOG: not touched.Testing
Local runs as above. #285 carries the negative controls: each new test fails against #284's checker.
Generated by Claude Code