Skip to content

fix(lock-sync): port rsr-template-repo#285 (same-SHA keys, job-level calls) - #19

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/lock-sync-tighten
Nov 5, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/lock-sync-tighten

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

The mint (#17) carried the exception from hyperpolymath/rsr-template-repo#284 into scripts/check-lock-sync.sh. Codex review found two defects in that exception, and both were mine:

  • it never checked that a record's key is the same full SHA as its ref:;
  • it judged "reusable call" from the shape of the path, not from where the uses: sits in the YAML.

They are fixed upstream in hyperpolymath/rsr-template-repo#285 (c438af6). This PR ports that fix as it stands. It becomes a no-op once a template update brings #285.

Changes

  • scripts/check-lock-sync.sh and tests/workflows/check_lock_sync_test.sh: byte-identical to #285's.

This repo's only exempt record, metadatastician/standards@46ee183, still passes. Its key and ref: are the same SHA, and all six callers are job-level.

RSR Quality Checklist

Required

  • Tests pass: bash scripts/check-lock-sync.sh → in sync and transitively closed; bash tests/workflows/check_lock_sync_test.sh → 137 PASS.
  • Code is formatted.
  • Linter is clean.
  • No banned language patterns.
  • No unsafe blocks.
  • No banned functions.
  • SPDX headers present (unchanged).
  • No secrets.

As Applicable

  • CHANGELOG: not touched.

Testing

Local runs as above. #285 carries the negative controls: each new test fails against #284's checker.


Generated by Claude Code

…calls)

The mint (#17) carried rsr-template-repo#284's clause-5 exception. Codex
review found two defects in it, fixed upstream in
hyperpolymath/rsr-template-repo#285 (c438af6); this ports that fix as it
stands. A self-SHA record is exempt only when its key is the same full SHA
and it is the target of a job-level reusable call, read from the YAML
position rather than the path's shape. No-ops once a template update
brings #285.

This repo's only exempt record, metadatastician/standards@46ee183, still
passes: its key and ref are the same SHA and all six callers are
job-level.

  bash scripts/check-lock-sync.sh              -> in sync and transitively closed
  bash tests/workflows/check_lock_sync_test.sh -> 137 PASS

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BYbQRtNu216R13jtZLmoqs
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Hypatia grid orange

🟠 indeterminate · commit 19b093d38604 · run 41946794468 · scope: this change (2 file(s))

Advisory: 11 row(s), worst 🔴 high (0 critical, 9 high) — reported, never grading the change.

Reporter Gate Status Critical High Medium Minor Since previous revision
Hypatia scan gating 🟠 indeterminate 0 0 0 0 — no comparable baseline
panic-attack assail advisory 🟢 clean 0 0 0 0 — no comparable baseline
pons asinorum advisory 🟢 clean 0 0 0 0 — no comparable baseline
finishingbot (release readiness) advisory 🔴 high 0 9 5 0 — no comparable baseline
glambot (presentation quality) advisory 🔵 minor 0 0 0 5 — no comparable baseline
rhodibot (RSR compliance) advisory 🟢 clean 0 0 0 0 — no comparable baseline
accessibilitybot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
cipherbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
echidnabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
panicbot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
seambot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
sustainabot advisory ⚪ not applicable 0 0 0 0 — no comparable baseline
Hypatia scan: error — the scanner produced no findings array
  • 🟠 indeterminate: the scanner produced no findings array
panic-attack assail: 14 finding(s)
  • 14 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
pons asinorum: 9 finding(s)
  • 9 further finding(s) in files this change does not touch: reported, not graded (0 critical, 0 high).
finishingbot (release readiness): 173 finding(s)
  • high V1-DOC-ROADMAP.adoc — Required file ROADMAP.adoc not found (Project roadmap).
  • high TOOL-001 — .tool-versions file not found for asdf/mise version management.
  • high SCM-001-NEUROSYM.scm — Required SCM file NEUROSYM.scm not found (Neurosymbolic AI documentation).
  • high SCM-001-AGENTIC.scm — Required SCM file AGENTIC.scm not found (Agentic AI integration documentation).
  • high SCM-001-PLAYBOOK.scm — Required SCM file PLAYBOOK.scm not found (Operational playbooks and procedures).
  • high SCM-001-ECOSYSTEM.scm — Required SCM file ECOSYSTEM.scm not found (Project's place in the ecosystem).
  • high SCM-001-META.scm — Required SCM file META.scm not found (Meta-level information and architectural decisions).
  • high SCM-001-STATE.scm — Required SCM file STATE.scm not found (Project state and progress tracking).
  • high PH-100 — Found 124 placeholders, exceeds maximum allowed (0)
  • medium V1-COM-CONTRIBUTING.md — CONTRIBUTING.md file not found (Contribution guidelines).
  • medium V1-COM-CODE_OF_CONDUCT.md — CODE_OF_CONDUCT.md file not found (Code of conduct).
  • medium V1-SEC-001 — SECURITY.md not found for responsible disclosure.
  • medium TEST-001 — Could not determine if this is a Rust or Deno project.
  • medium REL-004 — No SECURITY.md file found
  • 159 further finding(s) in files this change does not touch: reported, not graded (0 critical, 3 high).
glambot (presentation quality): 93 finding(s)
  • info GS-001 — Install git-seo for comprehensive SEO analysis: https://github.com/hyperpolymath/git-seo
  • info MACH-007 — ECOSYSTEM.scm not found in .machine_readable/ directory.
  • info MACH-007 — META.scm not found in .machine_readable/ directory.
  • info MACH-007 — STATE.scm not found in .machine_readable/ directory.
  • info MACH-005 — No robots.txt found. Consider adding one for crawler control.
  • 88 further finding(s) in files this change does not touch: reported, not graded (0 critical, 2 high).
rhodibot (RSR compliance): 13 finding(s)
  • 13 further finding(s) in files this change does not touch: reported, not graded (0 critical, 12 high).
accessibilitybot: not_applicable — template default: enrol once the repository serves HTML
  • ⚪ not applicable: template default: enrol once the repository serves HTML
cipherbot: not_applicable — template default: enrol once the repository implements cryptography
  • ⚪ not applicable: template default: enrol once the repository implements cryptography
echidnabot: not_applicable — template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
  • ⚪ not applicable: template default: enrol once the repository carries proofs and an ECHIDNA engine is configured
panicbot: not_applicable — panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
  • ⚪ not applicable: panic-attack is already graded by the verdict grid's own panic-attack row, from static-analysis-gate.yml evidence; enrolling panicbot would report one scanner twice and give two rows that can disagree
seambot: not_applicable — template default: enrol once a seam register exists at spec/seams/seam-register.json
  • ⚪ not applicable: template default: enrol once a seam register exists at spec/seams/seam-register.json
sustainabot: not_applicable — reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)
  • ⚪ not applicable: reserved fleet slot; no adapter exists (gitbot-fleet bots/sustainabot/README.adoc)

Scope: static findings reported by each row's tool at the named commit. The table grades only findings in files this change touches, so the colour answers "does this change introduce anything?", not "what does the whole repository still carry?". Standing findings are counted in each accordion and in report.json; the baseline filter remains the place where acknowledged debt is recorded. The lane state is the worst GATING row; advisory rows are listed and counted but never set it. Purple, red, yellow and blue grade the worst GRADED finding present; orange is evidence missing, malformed or a scanner that did not run; grey is an explicit scope exclusion with its reason. No row is a security certification. report.json, badge.json and the raw findings are in the verdict-grid artifact on the linked run.

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 5, 2026 10:57
@hyperpolymath
hyperpolymath merged commit 2fcd245 into main Nov 5, 2026
64 of 71 checks passed
@hyperpolymath
hyperpolymath deleted the claude/lock-sync-tighten branch November 5, 2026 10:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T11:00:43.768883Z 19b093d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19b093d386

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# every `steps:` block is a job-level reusable-workflow call.
if (line ~ /[^[:space:]]/) {
match(line, /^[[:space:]]*/); ind = RLENGTH
if (stepind >= 0 && ind <= stepind) stepind = -1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve step context for indentless YAML sequences

When a valid workflow formats a step sequence without extra indentation (steps: followed by - name: at the same column), this condition clears stepind on the sequence item. A later uses: key in that step has no leading dash and is therefore misclassified as a job-level reusable call when its action path resembles .github/workflows/*.yml. In that scenario, the checker incorrectly permits a self-SHA ref: for an action and exits successfully, defeating the guard this change is intended to add.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants