-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(docs): repair the contributing guide content defects #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,40 +1,40 @@ | ||
| # Clone the repository | ||
|
|
||
| git clone <https://github.com/hyperpolymath/nextgen-databases.git> cd | ||
| nextgen-databases | ||
| git clone https://github.com/hyperpolymath/nextgen-databases.git | ||
| cd nextgen-databases | ||
|
|
||
| # Using Nix (recommended for reproducibility) | ||
| # Using Guix (recommended for reproducibility) | ||
|
|
||
| nix develop | ||
| guix develop | ||
|
|
||
| # Or using toolbox/distrobox | ||
|
|
||
| toolbox create nextgen-databases-dev toolbox enter nextgen-databases-dev | ||
| \# Install dependencies manually | ||
| toolbox create nextgen-databases-dev | ||
| toolbox enter nextgen-databases-dev | ||
| # Install dependencies manually | ||
|
|
||
| # Verify setup | ||
|
|
||
| just check \# or: cargo check / mix compile / etc. just test \# Run test | ||
| suite | ||
| just check # or: cargo check / mix compile / etc. | ||
| just test # Run test suite | ||
|
|
||
|
|
||
| ### Repository Structure | ||
| ### Repository Structure | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Remove the four-space indentation from normal guide text. Markdown renders the indented paragraphs and lists as code blocks. For example, the content under 🧰 Tools🪛 markdownlint-cli2 (0.23.2)[warning] 21-21: Heading levels should only increment by one level at a time (MD001, heading-increment) 🤖 Prompt for AI Agents |
||
|
|
||
| `nextgen-databases` is a **coordination repo** — it does not hold database | ||
| implementations. Each database and query language has its own repo (see `REGISTRY.adoc`). | ||
|
|
||
| nextgen-databases/ ├── README.adoc / EXPLAINME.adoc / TOPOLOGY.adoc / | ||
| ROADMAP.adoc \# Portfolio docs ├── REGISTRY.adoc \# Authoritative map: | ||
| ROADMAP.adoc # Portfolio docs ├── REGISTRY.adoc # Authoritative map: | ||
| database/language → its own repo ├── CLAUDE.md / AGENTS.md / | ||
| 0-AI-MANIFEST.a2ml \# Agent guardrails ├── docs/ \# Coordination docs | ||
| (incl. migration runbooks) ├── tests/ \# CROSS-database integration | ||
| tests only ├── .machine_readable/ \# Canonical SCM metadata ├── .github/ | ||
| \# CI/CD, issue templates, governance ├── .well-known/ LICENSES/ └── | ||
| flake.nix / Justfile / stapeln.toml / opsm.toml \# Shared env & | ||
| 0-AI-MANIFEST.a2ml # Agent guardrails ├── docs/ # Coordination docs | ||
| (incl. migration runbooks) ├── tests/ # CROSS-database integration | ||
| tests only ├── .machine_readable/ # Canonical SCM metadata ├── .github/ | ||
| # CI/CD, issue templates, governance ├── .well-known/ LICENSES/ └── | ||
| flake.nix / Justfile / stapeln.toml / opsm.toml # Shared env & | ||
| orchestration | ||
|
|
||
|
|
||
| #### What belongs here vs. in a database repo | ||
| #### What belongs here vs. in a database repo | ||
|
Comment on lines
+21
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: python3 - <<'PY'
from pathlib import Path
p = Path('.github/CONTRIBUTING.md')
lines = p.read_text().splitlines()
for i, line in enumerate(lines, 1):
if line.lstrip().startswith('#'):
print(f'{i}: {line}')
print('\n--- surrounding section ---')
for start, end in ((1, 45),):
for i in range(start, min(end, len(lines)) + 1):
print(f'{i}: {lines[i-1]}')
PYRepository: hyperpolymath/nextgen-databases Length of output: 2599 Align the repository headings with the section hierarchy.
🧰 Tools🪛 LanguageTool[uncategorized] ~31-~31: The official name of this software platform is spelled with a capital “H”. (GITHUB) [locale-violation] ~32-~32: LICENSES must be spelled with a “c” when used as a noun in British English. Use “licences”. (LICENCE_LICENSE_NOUN_PLURAL) 🪛 markdownlint-cli2 (0.23.2)[warning] 21-21: Heading levels should only increment by one level at a time (MD001, heading-increment) [warning] 32-32: Headings should be surrounded by blank lines (MD022, blanks-around-headings) [warning] 32-32: Headings should be surrounded by blank lines (MD022, blanks-around-headings) [warning] 37-37: Heading levels should only increment by one level at a time (MD001, heading-increment) 🤖 Prompt for AI Agents |
||
|
|
||
| - ✅ **Here**: portfolio docs, the registry, cross-database integration tests, shared | ||
| infrastructure/orchestration, governance and machine-readable metadata. | ||
|
|
@@ -47,9 +47,9 @@ | |
|
|
||
| --- | ||
|
|
||
| ## How to Contribute | ||
| ## How to Contribute | ||
|
|
||
| ### Reporting Bugs | ||
| ### Reporting Bugs | ||
|
|
||
| **Before reporting**: | ||
| 1. Search existing issues | ||
|
|
@@ -66,7 +66,7 @@ | |
| - Expected vs actual behaviour | ||
| - Logs, screenshots, or minimal reproduction | ||
|
|
||
| ### Suggesting Features | ||
| ### Suggesting Features | ||
|
|
||
| **Before suggesting**: | ||
| 1. Check the [roadmap](ROADMAP.md) if available | ||
|
|
@@ -82,7 +82,7 @@ | |
| - Alternatives considered | ||
| - Which perimeter this affects | ||
|
|
||
| ### Your First Contribution | ||
| ### Your First Contribution | ||
|
|
||
| Look for issues labelled: | ||
|
|
||
|
|
@@ -93,22 +93,25 @@ | |
|
|
||
| --- | ||
|
|
||
| ## Development Workflow | ||
| ## Development Workflow | ||
|
|
||
| ### Branch Naming | ||
| ### Branch Naming | ||
|
|
||
| docs/short-description \# Documentation (P3) test/what-added \# Test | ||
| additions (P3) feat/short-description \# New features (P2) | ||
| fix/issue-number-description \# Bug fixes (P2) refactor/what-changed \# | ||
| Code improvements (P2) security/what-fixed \# Security fixes (P1-2) | ||
| docs/short-description # Documentation (P3) test/what-added # Test | ||
| additions (P3) feat/short-description # New features (P2) | ||
| fix/issue-number-description # Bug fixes (P2) refactor/what-changed # | ||
| Code improvements (P2) security/what-fixed # Security fixes (P1-2) | ||
|
|
||
|
|
||
| ### Commit Messages | ||
| ### Commit Messages | ||
|
|
||
| We follow [Conventional Commits](https://www.conventionalcommits.org/): | ||
|
|
||
| (): | ||
| type(scope): description | ||
|
|
||
| Body: what changed and why. | ||
|
|
||
| Footer: issue reference, e.g. Closes #123 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Remove the stale optional placeholders.
🤖 Prompt for AI Agents |
||
| \[optional body\] | ||
|
|
||
| \[optional footer\] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fence the literal setup and repository-tree blocks.
The setup commands and the repository tree are not inside fenced blocks. Markdown parses lines such as
# Using Guixand the new# CI/CDline as headings. It also collapses the tree into prose. Add fences around the setup block and the tree so each command and tree entry remains literal.Also applies to: 32-32
🤖 Prompt for AI Agents
Source: Linters/SAST tools
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: hyperpolymath/nextgen-databases
Length of output: 228
🏁 Script executed:
Repository: hyperpolymath/nextgen-databases
Length of output: 3948
🏁 Script executed:
Repository: hyperpolymath/nextgen-databases
Length of output: 3944
🌐 Web query:
official GNU Guix documentation guix develop no arguments guix.scm manifest.scm💡 Result:
<search_synthesis>
When you invoke guix shell without any arguments, GNU Guix attempts to automatically load a development environment from a guix.scm or manifest.scm file found in the current working directory or any of its parent directories [1][2]. This behavior is subject to the following conditions: 1. Interactive Use Only: This automatic loading only occurs when guix shell is invoked interactively [2][3]. If you provide any other arguments (such as a command to execute, e.g., guix shell -- my-command), the automatic loading of guix.scm or manifest.scm is disabled, and guix shell will instead create an empty environment [1][4]. 2. Authorization: For security reasons, the directory containing the guix.scm or manifest.scm file must be listed in your ~/.config/guix/shell-authorized-directories file [1][2][5]. If the directory is not authorized, guix shell will not load the file [6][3]. 3. Precedence: If both files are present, the behavior is determined by the implementation, which typically searches for these files in the current directory or its ancestors [2][6]. If a manifest.scm is found, it is used as if passed via the --manifest option; if a guix.scm is found, it is used as if passed via the --development and --file options [1][2][6]. You can explicitly inhibit this behavior by using the -q option [7][6].
</search_synthesis>
<source_evidence>
Citations:
🌐 Web query:
site:guix.gnu.org/manual GNU Guix guix develop command guix shell --development official documentation💡 Result:
<search_synthesis>
The guix shell command is the official, recommended tool in GNU Guix for creating one-off software environments, including those specifically tailored for package development [1][2]. It replaced the older guix environment command, which has been deprecated since October 2021 [3]. Key features and usage for development include: 1. Purpose: guix shell allows developers to quickly set up the necessary environment for a package—including all required dependencies—without needing to manually install them into their user profile [1][4]. 2. Development Environments: To create an environment containing the dependencies required to build a specific package, you use the -D (or --development) option [5]. For example, running guix shell -D package-name will spawn a shell with all the inputs needed to develop that package [5]. 3. Manifests: For more complex or reproducible environments, you can use a manifest file. The -D option can also be used in conjunction with manifests to define the development environment inputs [5]. By using guix shell, you ensure that your development environment is isolated and does not pollute your global profile, making it a standard practice for managing project-specific dependencies in Guix [1][2].
</search_synthesis>
<source_evidence>
No source excerpts or source summaries were returned.
</source_evidence>
Citations:
Replace
guix developwith a supported Guix setup.The repository contains no
guix.scmormanifest.scm, and GNU Guix documentsguix shell --development, notguix develop, for development environments. Add a Guix definition and document its exact invocation, or document the repository's supported setup command instead.🤖 Prompt for AI Agents