Repository navigation
Fix RE001 inheritance and endpoint findings from #1036 review #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyperpolymath
wants to merge
6
commits into
main
Choose a base branch
from
codex/egress-review-followups-20261116
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fb20d65
fix(rules): reconcile RE001 secret inheritance and endpoint evidence
hyperpolymath 23abb27
Merge branch 'main' into codex/egress-review-followups-20261116
hyperpolymath 5c8122f
Merge branch 'main' into codex/egress-review-followups-20261116
hyperpolymath 29579ce
Merge branch 'main' into codex/egress-review-followups-20261116
hyperpolymath 84f719f
fix(rules): exclude Docker images without registries from endpoints
coderabbitai[bot] 14c38ab
Merge branch 'main' into codex/egress-review-followups-20261116
hyperpolymath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When both a workflow URL and its deed use the same fully qualified hostname with a trailing dot, such as
https://example.com./and"example.com.:443", this new normalization strips the dot only from the discovered host.literal_endpoint/1preserves the dot in the declaration, socovers?/3now reports a mismatch even though the two endpoints are identical; normalize declared and allowed hosts the same way before comparing them.Useful? React with 👍 / 👎.