Repository navigation
fix(rsr): main compile break from the #1113/#1115/#1117 collision - #1132
Conversation
…collided on Main did not compile: descriptiles_parse/1 called an undefined deed_state/1, a duplicate record_files == [] branch could never run, and descriptile_carrier/0 was never called. - 3.1.1 now uses descriptile_carrier/0 (deed first, then the directory), as #1117 describes. - deed_state/1 replaces deed_parses?/1 and returns :ok, :none or :broken. - 3.2.1: a broken chora deed fails even when the .a2ml files parse (#1117); the dead duplicate branch is gone. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZmUcth17dd8P9G2L1G
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
|
Closing as a duplicate: #1128 was already merged with the same fix. On main (1d1e279), Generated by Claude Code |
#1133 broke (#1136) ## Summary #1133 (Deed parser v2) merged while one Codex finding and four red checks were still open. Three of the four reds came from #1133 and are fixed here. The fourth was already red on main. ## Changes 1. **Codex, `lib/hypatia/deed.ex:104`.** `dispatch/1` accepted any `*_praxis.deed` without checking the stem. - In deed.abnf (146–148), `praxis-file` and `repo-file` share one rule: `stem = 1*( ALPHA / DIGIT / "-" / "." / "_" )`. One `stem/3` now enforces it for both suffixes. - Tests: `_praxis.deed`, `☃_praxis.deed`, `café_praxis.deed` and `a b_praxis.deed` are refused by both `dispatch/1` and `parse/2`. `my-proj.v2_x_praxis.deed` is accepted. The chora cases still refuse. 2. **Elixir Compile (dogfood toolchain).** `check-no-active-logtalk.sh` fails on the vendored fixture `test/fixtures/deed/standards/valid/rsr-template-repo_chora.deed:110`, which carries the upstream `:report-format "logtalk"`. - The fixture is added to `.logtalk-allowlist` with the same class ("vendored upstream fixture") and the same removal condition as its two identical siblings already listed. - The list's header asks for rule-level review of a new entry. That review belongs here, because editing the fixture would break its byte-faithfulness to standards. 3. **governance / UUID v7 and UUID v8 conformance.** `check-uuid-v8.sh --strict` (pinned at standards 7641c7f) flagged four ids in `test/deed_conformance_test.exs` that are deliberately not v8. - Those inputs are now built at run time from one v8 id by swapping its version and variant nibbles. The assertions are unchanged, and the v5 case now also checks the refusal reason. - The test file and three vendored invalid fixtures go into `.uuid-v8-exempt`, following the `test/deed_test.exs` precedent. The fixtures pass the pinned gate but fail the current standards script, so the exemption keeps them from breaking when the pin moves. - No real id or domain is touched. 4. **Escript packaging soundness: not this change.** It failed on `undefined function deed_state/1`, which came from #1117's merge. That red push run sat on 6033a78, before #1125/#1128/#1132. The same error reproduces on 6033a78, and an unrelated PR failed the same way before #1133 merged. Current main passes (43638218845). ## Verification Run with Elixir 1.19.4 / OTP 27.3.4.19, the CI versions: - `mix compile --warnings-as-errors`: exit 0. - `mix test`: 3338 tests, 0 failures, 246 excluded (seed 0; `verisim_data` and the other excluded tags as configured). - `test/soundness/run-escript-soundness.sh`: 14/14. - The consumer-shaped scan output passes `check-findings-schema.sh`. - `mix format --check-formatted` passes on the changed files. - `check-uuid-v8.sh --strict` passes at the pinned and the current standards versions. The logtalk guard reports 15 allowlisted, 0 violations. ## For the owner - **Gate looser than the grammar:** the standards gate `deed_lint.js` (702–703) doesn't check the praxis stem, so it accepts names the grammar refuses. The reader now follows the grammar. - **Formatting on main:** 27 files on main fail `mix format --check-formatted` under 1.19.4, and no workflow runs that check. Not touched here. --- _Generated by [Claude Code](https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC)_ --------- Co-authored-by: Claude <noreply@anthropic.com>



Summary
Main does not compile since #1117.
descriptiles_parse/1callsdeed_state/1, which nothing defines. A duplicaterecord_files == []branch could never run, anddescriptile_carrier/0was never called.Changes
descriptile_carrier/0(deed first, then the directory), as feat(rules): RSR 3.1.1 and 3.2.1 read the chora deed first #1117 describes.deed_state/1replacesdeed_parses?/1and returns:ok,:noneor:broken..a2mlfiles parse, as feat(rules): RSR 3.1.1 and 3.2.1 read the chora deed first #1117 says. The dead duplicate branch is removed.Verification
mix compile --warnings-as-errors: clean (it failed before with the undefined function and the unused function).mix format --check-formattedon the file: clean.mix test: 3514 tests, 0 failures, 246 excluded (LANG=C.UTF-8).Not run: Rust, Zig and Idris2 checks.
Generated by Claude Code