Repository navigation
chore(audits): translate assail-classifications.a2ml into a deed #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9e7ef32
chore(deed): translate the descriptiles into hypatia_chora.deed
claude b5c2d76
chore(deed): replace 0-AI-MANIFEST.a2ml with a pointer-only 0-AI-MANI…
claude f38793a
chore(a2ml): delete the A2ML records that no mapping spec translates
claude e9a6190
test(rule_loader): inline the three hypatia-rules fixtures; ship no .…
claude e1935eb
feat(rules): read the deed-era carriers of STATE, META, ECOSYSTEM and…
claude 009bb15
docs: point agents and readers at the deeds, not the retired .a2ml files
claude 7d1059a
chore(tools): remove scm-to-a2ml.sh, a producer of A2ML files
claude 1f4e22f
chore(audits): translate assail-classifications.a2ml into a deed
claude f87fd9d
docs(a2ml ledger): name panic-attack's assail module, not a path hypa…
claude 3712c4a
Merge branch 'chore/a2ml-to-deed' into chore/assail-classifications-deed
hyperpolymath 9e1371a
Merge main into chore/assail-classifications-deed
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| ;; SPDX-License-Identifier: MPL-2.0 | ||
| ;; SPDX-FileCopyrightText: 2026 Jonathan D.A. Jewell (hyperpolymath) <j.d.a.jewell@open.ac.uk> | ||
| ;; | ||
| ;; assail-classifications_praxis.deed — audited panic-attack findings for | ||
| ;; hypatia. Translated entry for entry from audits/assail-classifications.a2ml | ||
| ;; (removed; see docs/history/A2ML-REMOVED.adoc): (file "…") is :file, | ||
| ;; (category "…") is the symbol :category, (audit "…") is :audit and | ||
| ;; (rationale "…") is :rationale. Nothing was added or dropped. | ||
| ;; | ||
| ;; Read by panic-attack's deed-first registry reader (load_user_classifications, | ||
| ;; src/assail/classifications.rs): findings matching (:file, :category) are | ||
| ;; flipped to suppressed = true AFTER the structural kanren suppression pass. | ||
| ;; A malformed file fails the scan; it is never read as an empty registry. | ||
| ;; Entries here are AUDITED-SOUND residuals, not exemptions of convenience: | ||
| ;; every entry must cite its rationale, and the registry lives apart from the | ||
| ;; source so a code edit cannot self-suppress (see panic-attack CLAUDE.md, | ||
| ;; User-Classification Registry). | ||
| ;; | ||
| ;; Audit trail: 2026-06-11 estate-loop session — fresh panic-attack | ||
| ;; 2.5.5 scan of hypatia; every entry below was inspected at source. | ||
| (praxis-deed | ||
| :schema-version "1.0.0" | ||
| :canonical-name "hypatia-assail-classifications" | ||
| :beholding-chora #uuid"0889b37b-defb-831f-973c-e119500db00e" | ||
| :profile assail-classifications | ||
|
|
||
| ;; ── Soundness-gate negative fixtures ───────────────────────────── | ||
| ;; test/soundness/fixtures/code_safety/ exists to PROVE the scanner | ||
| ;; catches these constructs; the findings are the fixtures working | ||
| ;; as designed. Mirrors lib/hypatia/scanner_suppression.ex, which | ||
| ;; already exempts these paths for hypatia's own scanner. | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/transmute.rs" | ||
| :category UnsafeCode | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects mem::transmute") | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/admitted.v" | ||
| :category ProofDrift | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects Admitted") | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/believe_me.idr" | ||
| :category ProofDrift | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects believe_me") | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/sorry.lean" | ||
| :category ProofDrift | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects sorry") | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/obj_magic_ocaml.ml" | ||
| :category UnsafeTypeCoercion | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects Obj.magic") | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/unsafe_coerce.hs" | ||
| :category UnsafeTypeCoercion | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects unsafeCoerce") | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/elixir_code_eval.ex" | ||
| :category DynamicCodeExecution | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects Code.eval_string") | ||
| (classification | ||
| :file "test/soundness/fixtures/code_safety/zig_ptr_cast.zig" | ||
| :category UnsafeCode | ||
| :audit "test/soundness — deliberate negative fixture" | ||
| :rationale "fixture asserting the scanner detects Zig pointer casts") | ||
|
|
||
| ;; ── Remediation scripts: pattern strings, not vulnerabilities ──── | ||
| (classification | ||
| :file "scripts/fix-scripts/fix-deno-permissions.sh" | ||
| :category ExcessivePermissions | ||
| :audit "remediation tool — replaces `deno -A` with scoped permission flags; scripts/fix-scripts/ is already exempt in scanner_suppression.ex" | ||
| :rationale "contains -A as the SEARCH pattern it removes from other repos") | ||
|
|
||
| ;; ── FFI boundary unsafe: documented, load-bearing ──────────────── | ||
| (classification | ||
| :file "clients/rust/hypatia-client/src/ffi.rs" | ||
| :category UnsafeCode | ||
| :audit "in-file # Safety section (ffi.rs:7-30) enumerates the invariant for every unsafe block; carries hypatia allow pragmas" | ||
| :rationale "libloading C-ABI boundary calls against libhypatia_ffi.so; each block's invariant documented at source") | ||
|
|
||
| ;; ── Test harnesses ─────────────────────────────────────────────── | ||
| (classification | ||
| :file "tests/e2e.sh" | ||
| :category CommandInjection | ||
| :audit "tests/e2e.sh:88-93 — heredoc writes a deliberately insecure fixture" | ||
| :rationale "the eval is fixture CONTENT generated for the scanner-detection test, not executed by the harness") | ||
| (classification | ||
| :file "integration/run-tests.sh" | ||
| :category HardcodedSecret | ||
| :audit "integration/run-tests.sh:268 — ARANGODB_PASSWORD=testpassword" | ||
| :rationale "throwaway credential for the ephemeral integration-test database container") | ||
|
|
||
| ;; ── Env-var binding misread as a secret ────────────────────────── | ||
| (classification | ||
| :file "hooks/lib/cache.sh" | ||
| :category HardcodedSecret | ||
| :audit "hooks/lib/cache.sh:17-22 — CICD_CACHE_PASSWORD=\"${CICD_CACHE_PASSWORD:-}\"" | ||
| :rationale "empty-default env-var binding, documented in-file; no literal secret present") | ||
|
|
||
| ;; ── Rule definitions detecting themselves ──────────────────────── | ||
| (classification | ||
| :file "lib/hypatia/scanner_suppression.ex" | ||
| :category HardcodedSecret | ||
| :audit "scanner suppression rule definitions contain secret-shaped pattern strings" | ||
| :rationale "detector/suppression pattern table, not credentials — same class as the scripts/fix-* carve-out in scanner_suppression.ex") | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the legacy registry until every checked-in scanner lane uses the deed-aware panic-attack revision. In this commit,
.github/workflows/estate-rescan.ymlstill pins410a8f821ea8297833162565b50a298f787815da, and.github/workflows/hypatia-scan.ymlstill delegates to the unchanged standards workflow at7641c7fdb01420696b5420ab85d88f599f32f609; those revisions predate the deed reader described here. Consequently, scans through either lane ignore this new file after the.a2mlregistry is deleted, causing all 14 audited findings to reappear unsuppressed.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This is the ordering the PR body called for.
estate-rescan.ymlPA_SHAtocbf2b935, the panic-attack#295 merge commit with the deed reader.hypatia-scan-reusable.yml(plusfork-governance.ymlanddeep-recon-reusable.yml) to the same SHA.hypatia-scan.ymluses:to the merge commit, on this branch, before this PR lands.Generated by Claude Code