Skip to content

Stack coherence: README status references, checker pin and scan pin - #90

Merged
hyperpolymath merged 6 commits into
mainfrom
claude/stack-coherence-fixes
Nov 20, 2026
Merged

hyperpolymath merged 6 commits into
mainfrom
claude/stack-coherence-fixes

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Three disagreements between haec and its sibling repositories, found by the stack coherence gate (hyperpolymath/trope-particularity-workbench#83). Prose and pins only.

Changes

  • README. It cited a root STATUS.adoc three times. haec has no such file; it has compiler/STATUS.adoc and lsp/STATUS.adoc. The README now names those.
  • Checker pin. trope-check.yml pins trope-checker at 0dceab6 (was 4ecba4f). hermeneia and vocarium move to the same commit in the same sweep, so the three siblings build against one checker. Between the two commits trope-checker's src/, schemas/, spec/ and conformance fixtures do not differ, and the one Idris2 file that differs (Trope/Order.idr) differs in comments only.
  • Scan pin. hypatia-scan.yml moves to standards 58362c2, which installs OTP 27.3.4.19. Earlier revisions install OTP 28.x, which crashes the scanner on some trees (hypatia#1061; reproduced on trope-checker).

Not changed

Known red check

The root-shape check fails on main for a reason this change does not touch (#83, owner-only). Expect it red here too.

Testing

TROPECHECK_REQUIRED=1 TROPECHECK_BIN=…/tropecheck-rs bash tests/check-examples.sh
  -> vendored schema matches; 3 round-trips to the stated verdicts

The Rust core was built from trope-checker sources identical to main in src/, schemas/, spec/ and the conformance fixtures. The Idris2 reference path was not run locally; the workflow runs it.


Generated by Claude Code

…ns the stack shares

The README cited a root STATUS.adoc three times. haec has no such file; it
has compiler/STATUS.adoc and lsp/STATUS.adoc, which the README now names.

The trope-check workflow pins trope-checker at 0dceab6, with hermeneia and
vocarium. Between the previous pin (4ecba4f) and 0dceab6, trope-checker's
src/, schemas/, spec/ and conformance fixtures do not differ; the one
Idris2 file that differs (Trope/Order.idr) differs in comments only.

The Hypatia scan pin moves to standards 58362c2, which installs OTP
27.3.4.19. Earlier revisions install OTP 28.x, which faults in the VM's
garbage collector on some trees (hypatia#1061).

Not changed: design/elaboration.adoc still states an O2 obligation in
terms of the v0.1 ordering. That is deferred to the owner.

tests/check-examples.sh passes locally against the Rust core built from
trope-checker sources identical to main. Found by the stack coherence gate
(workbench#83).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: acde778e-9543-47c8-bb27-f17b29fc7ab6
Commits

Reviewing files that changed from the base of the PR and between 4ad8ba0 and 6df6232.

Files selected for processing: 3

  • .github/workflows/workflow-linter.yml
  • .machine_readable/root-allow.txt
  • CHANGELOG.adoc

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated the compiler and language server status links in the README to point to their respective status files.
    • Added Unreleased changelog entries covering the documentation and workflow updates.
  • Bug Fixes
    • Workflow linting now checks the leading comment block for an SPDX identifier and provides an updated error message when it is missing.
  • Chores
    • Updated the automated scan and trope-check workflows to use revised versions.

This pull request updates workflow lint checks for SPDX identifiers, changes the pinned revisions for two workflows, corrects compiler and LSP status links in the README, and records the changes in the changelog.

Changes: Repository updates

Layer / File(s) Summary
Check workflow header comments
.github/workflows/workflow-linter.yml, CHANGELOG.adoc
The linter scans the leading comment block for an SPDX identifier and skips YAML document separators. Its messages refer to the header comment block. The changelog records the check and notes that workflows without the identifier still fail.
Update workflow revisions and status references
.github/workflows/hypatia-scan.yml, .github/workflows/trope-check.yml, README.adoc, CHANGELOG.adoc
The Hypatia scan and trope-checker workflows use new pinned revisions. The README links to the compiler and LSP status files. The changelog records these updates and notes that the O2 obligation was not changed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

  • hyperpolymath/haec#89 — This pull request updates the README status references and trope-checker pin described in the issue. It does not change the .machine_readable/ items.

Possibly related PRs

  • hyperpolymath/haec#85 — PR #85 introduced the trope-checker revision that this pull request replaces.
Merge Risk: Minimal · previous review 4ad8b

This change updates documentation links and dependency pins and makes the workflow header lint tolerate a lock-tool banner. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the three changes in the PR: README status references, checker pin and scan pin. It is specific and matches the changeset, although it lists three items rather than one main change and…
Description check Passed The description has a clear summary and a changes list that matches the diff: README status links, trope-checker pin, and hypatia scan pin. It explains the rationale, lists items not changed, and give…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the three changes in the PR: README status references, checker pin and scan pin. It is specific and matches the changeset, although it lists three items rather than one main change and uses the term 'Stack coherence' as a general label. It is accurate, so the check passes.

Full details: Description check

Explanation

The description has a clear summary and a changes list that matches the diff: README status links, trope-checker pin, and hypatia scan pin. It explains the rationale, lists items not changed, and gives testing output. It does not follow the repository template. The template's SPDX header is absent from the description, though that header belongs to the file, not the PR text. The RSR Quality Checklist is missing, and the 'Changes' section does not tick any boxes. The Screenshots section is not addressed, which is acceptable because it is marked as applicable only when relevant. The CHANGELOG entry is covered by the separate CHANGELOG.adoc change. The checklist omissions are significant for a template-based check, but the core sections are present and the description is mostly complete.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 47ce39f5-79af-42e4-8838-e28e98dc507f
Commits

Reviewing files that changed from the base of the PR and between 052120e and 4ad8ba0.

Files selected for processing: 2

  • .github/workflows/workflow-linter.yml
  • CHANGELOG.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 9

  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Patch Bridge CVE triage
  • GitHub Check: Runtime Policy
  • GitHub Check: lint-workflows
  • GitHub Check: analyze (actions, none)
  • GitHub Check: examples-lower-to-valid-ir
  • GitHub Check: estate-rules
  • GitHub Check: CI / required
Additional context used

GitHub Check: SonarCloud Code Analysis

.github/workflows/workflow-linter.yml

[warning] 50-50: Redirect this error message to stderr (>&2).

See more on https://sonarcloud.io/project/issues?id=hyperpolymath_haec&issues=AaHqWrGcDeh-l5YrlFie&open=AaHqWrGcDeh-l5YrlFie&pullRequest=90

@linear-code
linear-code Bot marked this pull request as ready for review November 17, 2026 12:50

Copy link
Copy Markdown
Owner Author

Three checks are red here, and none comes from this change. Each is already failing on main:

Check Latest result on main
CI / required failure at 7083d19 (2026-11-10)
Estate rules failure at 7083d19; the root-shape check, tracked in #83
Workflow security lint failure at df8e7bb (2026-11-11); it requires the SPDX line first, and the workflows carry a "managed by gh actions-lock" line above it

This PR changes a README, a changelog and two pins, and touches none of those causes. I have not changed the workflow headers: the line above the SPDX header is written by the lock tool across every workflow, so the fix belongs with that tool and applies to the other repositories too.


Generated by Claude Code

The lint tested line 1 of each workflow for the SPDX identifier. gh
actions-lock inserts its banner at line 1 whenever it refreshes the lockfile,
so the test failed on nearly every workflow, here and on main. It now reads
the leading comment block, the test standards governance-reusable.yml uses.
A workflow with no identifier in that block still fails (checked with two
planted files).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The check for reusable workflow calls looked for 40 hex characters anywhere
on the line and only matched an unquoted value. A branch ref with a commit
named in a trailing comment passed, and so did any quoted ref.

The value of each uses: is now read with its comment and quotes removed, and
the text after the @ must be exactly 40 lowercase hex characters. Four
planted references (comment, double quote, single quote, 41 characters) pass
the previous check and fail this one; a plain commit, a quoted commit and an
ordinary action on a tag are unaffected.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The previous version read the raw text of each uses: line, so an escape
inside a quoted value (for example \x77orkflows) kept a branch ref out of
the check. With yq on the runner each workflow is now parsed and the
decoded job-level uses: values are judged: a call that is not local must
end in @ and exactly 40 lowercase hex characters, and a workflow that does
not parse fails. Without yq the raw-text check remains, with a warning.

Run against the real step: an escaped path, a flow-style mapping and a
comment carrying a commit are each rejected; a quoted commit, a local call
and an ordinary tagged action pass.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The raw-text fallback for runners without yq could not see a flow-style
mapping or an escaped path, so on that path a branch ref still passed. The
fallback is removed: when yq is missing the step fails and says why.

Run against the real step: a flow-style branch ref and an escaped path are
rejected, a quoted commit and a local call pass, both repositories pass,
and with yq taken off PATH the step exits 1.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The allowlist carried the template's .md names (CHANGELOG.md,
CONTRIBUTING.md, SECURITY.md), while this repository's root files are
AsciiDoc. The root-shape check therefore rejected CHANGELOG.adoc,
CONTRIBUTING.adoc, SECURITY.adoc, FUNDING and PROOF-PROGRESS.adoc, which
failed CI / required and estate-rules here and on main.

The five are added with a line each; the .md entries are left in place.
Edit authorised by the owner for this file and these five entries.

Before: check-root-shape.sh exits 1 naming the five. After: PASS, 47
entries, 52 permitted.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Owner Author

@coderabbitai approve


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Rate Limit Exceeded

@hyperpolymath have exceeded the limit for the number of chat messages per hour. Please wait 12 minutes and 42 seconds before sending another message.

Copy link
Copy Markdown
Owner Author

@coderabbitai approve


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@hyperpolymath The approval workflow will check eligibility and review readiness, then report the result.


Learnings added

Learnt from: hyperpolymath
URL: https://github.com/hyperpolymath/haec/pull/90

Timestamp: 2026-11-18T01:14:35.077Z
Learning: Within repository "hyperpolymath/haec", only for files matching one of [".github/workflows/**"]: In `.github/workflows/` files managed by `gh actions-lock`, the tool inserts a management comment before the SPDX header. Do not flag that generated banner solely because it precedes the SPDX identifier.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

Action performed

Changes approved. Review threads were not changed.

@hyperpolymath
hyperpolymath merged commit 5891ef0 into main Nov 20, 2026
22 checks passed
@hyperpolymath
hyperpolymath deleted the claude/stack-coherence-fixes branch November 20, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants