Repository navigation
Stack coherence: README status references, checker pin and scan pin - #90
Conversation
…ns the stack shares The README cited a root STATUS.adoc three times. haec has no such file; it has compiler/STATUS.adoc and lsp/STATUS.adoc, which the README now names. The trope-check workflow pins trope-checker at 0dceab6, with hermeneia and vocarium. Between the previous pin (4ecba4f) and 0dceab6, trope-checker's src/, schemas/, spec/ and conformance fixtures do not differ; the one Idris2 file that differs (Trope/Order.idr) differs in comments only. The Hypatia scan pin moves to standards 58362c2, which installs OTP 27.3.4.19. Earlier revisions install OTP 28.x, which faults in the VM's garbage collector on some trees (hypatia#1061). Not changed: design/elaboration.adoc still states an O2 obligation in terms of the v0.1 ordering. That is deferred to the owner. tests/check-examples.sh passes locally against the Rust core built from trope-checker sources identical to main. Found by the stack coherence gate (workbench#83). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
|
Three checks are red here, and none comes from this change. Each is already failing on
This PR changes a README, a changelog and two pins, and touches none of those causes. I have not changed the workflow headers: the line above the SPDX header is written by the lock tool across every workflow, so the fix belongs with that tool and applies to the other repositories too. Generated by Claude Code |
The lint tested line 1 of each workflow for the SPDX identifier. gh actions-lock inserts its banner at line 1 whenever it refreshes the lockfile, so the test failed on nearly every workflow, here and on main. It now reads the leading comment block, the test standards governance-reusable.yml uses. A workflow with no identifier in that block still fails (checked with two planted files). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The check for reusable workflow calls looked for 40 hex characters anywhere on the line and only matched an unquoted value. A branch ref with a commit named in a trailing comment passed, and so did any quoted ref. The value of each uses: is now read with its comment and quotes removed, and the text after the @ must be exactly 40 lowercase hex characters. Four planted references (comment, double quote, single quote, 41 characters) pass the previous check and fail this one; a plain commit, a quoted commit and an ordinary action on a tag are unaffected. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The previous version read the raw text of each uses: line, so an escape inside a quoted value (for example \x77orkflows) kept a branch ref out of the check. With yq on the runner each workflow is now parsed and the decoded job-level uses: values are judged: a call that is not local must end in @ and exactly 40 lowercase hex characters, and a workflow that does not parse fails. Without yq the raw-text check remains, with a warning. Run against the real step: an escaped path, a flow-style mapping and a comment carrying a commit are each rejected; a quoted commit, a local call and an ordinary tagged action pass. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The raw-text fallback for runners without yq could not see a flow-style mapping or an escaped path, so on that path a branch ref still passed. The fallback is removed: when yq is missing the step fails and says why. Run against the real step: a flow-style branch ref and an escaped path are rejected, a quoted commit and a local call pass, both repositories pass, and with yq taken off PATH the step exits 1. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
The allowlist carried the template's .md names (CHANGELOG.md, CONTRIBUTING.md, SECURITY.md), while this repository's root files are AsciiDoc. The root-shape check therefore rejected CHANGELOG.adoc, CONTRIBUTING.adoc, SECURITY.adoc, FUNDING and PROOF-PROGRESS.adoc, which failed CI / required and estate-rules here and on main. The five are added with a line each; the .md entries are left in place. Edit authorised by the owner for this file and these five entries. Before: check-root-shape.sh exits 1 naming the five. After: PASS, 47 entries, 52 permitted. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDim4mMEfCer9SiAV4H
|
|
@coderabbitai approve Generated by Claude Code |
Rate Limit Exceeded
|
|
@coderabbitai approve Generated by Claude Code |
|
@hyperpolymath The approval workflow will check eligibility and review readiness, then report the result. Learnings added
Action performed
|



Summary
Three disagreements between haec and its sibling repositories, found by the stack coherence gate (hyperpolymath/trope-particularity-workbench#83). Prose and pins only.
Changes
STATUS.adocthree times. haec has no such file; it hascompiler/STATUS.adocandlsp/STATUS.adoc. The README now names those.trope-check.ymlpins trope-checker at0dceab6(was4ecba4f). hermeneia and vocarium move to the same commit in the same sweep, so the three siblings build against one checker. Between the two commits trope-checker'ssrc/,schemas/,spec/and conformance fixtures do not differ, and the one Idris2 file that differs (Trope/Order.idr) differs in comments only.hypatia-scan.ymlmoves to standards58362c2, which installs OTP 27.3.4.19. Earlier revisions install OTP 28.x, which crashes the scanner on some trees (hypatia#1061; reproduced on trope-checker).Not changed
design/elaboration.adoc:52still states an O2 obligation in terms of the v0.1 ordering ("thePredicated-incomparable-to-Droppedclaim"). The calculus made retention a chain in IR 0.2 (ADR 0004 A2). Rewording an obligation is deferred to the owner..machine_readable/:.machine_readable/6a2/has template residue, and its pipeline and clade differ from the sibling repos #89.Known red check
The root-shape check fails on
mainfor a reason this change does not touch (#83, owner-only). Expect it red here too.Testing
The Rust core was built from trope-checker sources identical to
maininsrc/,schemas/,spec/and the conformance fixtures. The Idris2 reference path was not run locally; the workflow runs it.Generated by Claude Code