Skip to content

chore(deps): add deny.toml (licence policy) and versioned path deps - #525

Merged
hyperpolymath merged 2 commits into
mainfrom
chore/deny-toml
Nov 19, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
chore/deny-toml

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

PR 3 of the rust-ci migration scoping. The estate reusable rust-ci.yml (proven-cicd-and-workflows@5b6024c) runs cargo deny check advisories bans sources always and adds licenses only when deny.toml exists, because licence policy is owner-authored. This adds that file. Echidna's own CI does not run cargo-deny today, so merging this changes no CI result until the migration lands.

The licence allowlist is a draft for owner review: it is the permissive set found in Cargo.lock at adoption, not a ruling.

Changes

  • deny.toml (new): [licenses] allowlist (Apache-2.0 incl. LLVM-exception, BSD-2/3, BSL-1.0, CC0-1.0, CDLA-Permissive-2.0, ISC, MIT, MIT-0, MPL-2.0, Unicode-3.0, Unlicense, Zlib); [bans] multiple-versions = "warn", wildcards = "deny"; [sources] crates.io only, no git.
  • Cargo.toml: typed-wasm and echidna-core path deps gain version = "0.1.0" / "0.2.0" (what those crates declare). cargo-deny's wildcard ban otherwise errors on them because echidna is not publish = false. No lockfile change.

Owner decisions

  • Confirm CDLA-Permissive-2.0 (webpki-roots CA data).
  • Copyleft is deliberately not allowed. r-efi is MIT OR Apache-2.0 OR LGPL-2.1-or-later and passes through its MIT arm.
  • Alternative to the version requirements: mark echidna publish = false, or set wildcards = "warn". I chose the version requirements to fix it at the source.
  • Duplicate crates (11 at adoption: getrandom x3, syn, sha2, digest, ...) stay a warning, not an error.

Verification

Run locally with cargo-deny 0.20.2 using the reusable's exact flags (--all-features --locked, --warn unmaintained --warn yanked):

  • check advisories bans sources: exit 0
  • check licenses: exit 0
  • Negative control: removing MIT from the allowlist makes check licenses exit 4.
  • cargo check --locked --workspace --all-targets: pass.

Advisory note, not a failure: cargo-deny warns chrono is unmaintained (RustSec). It is a warning under --warn unmaintained; no ignore entry was added.

RSR Quality Checklist

Required

  • SPDX license headers present on all new/modified source files
  • No secrets, credentials, or .env files included
  • New dependencies reviewed for license compatibility (none added; policy only)

Generated by Claude Code

Adds the cargo-deny licence/bans/sources policy the estate rust-ci
reusable switches on when deny.toml exists. Allowlist is the permissive
set present in Cargo.lock at adoption; copyleft is absent. Path deps on
typed-wasm and echidna-core gain the version each crate declares so the
wildcard ban passes without relaxing it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZkqCNUotDR2GTtx8G3
@hyperpolymath
hyperpolymath marked this pull request as ready for review November 19, 2026 11:24
@sonarqubecloud

Copy link
Copy Markdown

Repository owner deleted a comment from coderabbitai Bot Nov 19, 2026
@hyperpolymath
hyperpolymath enabled auto-merge (rebase) November 19, 2026 11:51
auto-merge was automatically disabled November 19, 2026 11:54

Branch protection rule check failed

@hyperpolymath
hyperpolymath merged commit 9dd703a into main Nov 19, 2026
80 checks passed
@hyperpolymath
hyperpolymath deleted the chore/deny-toml branch November 19, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants