Skip to content

fix(proofs): run Agda with --without-K --cubical-compatible - #226

Open
hyperpolymath wants to merge 1 commit into
mainfrom
claude/proof-policy-drift
Open

hyperpolymath wants to merge 1 commit into
mainfrom
claude/proof-policy-drift

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Findings

Both findings still applied at HEAD. The Logtalk removal on its own branch was not touched.

agda-not-strict (PROOF-POLICY §2.1). The finding said it was undetermined whether the just proof-check-agda recipes exist. They do. Both affinescript-ecosystem/rattlescript/Justfile and affinescript-ecosystem/affinescript-vite/Justfile define proof-check-agda, and both ran plain agda --safe "$f". Both now run agda --safe --without-K --cubical-compatible "$f". Both template Properties.agda files got {-# OPTIONS --safe --without-K --cubical-compatible #-} above the module line, and the SPDX header is untouched. I kept the modules rather than removing them, because the recipes now gate them.

percentage-census (§8.4). rattlescript/PROOF-STATUS.adoc and affinescript-vite/.machine_readable/compliance/PROOF-STATUS.adoc line 18: "0% proven" is now "0 of 7 obligations proven". 7 is the Total row of each doc's own table.

Verification

  • agda --safe --without-K --cubical-compatible -i . -i <agda-stdlib v2.3 src> Properties.agda with Agda 2.8.0.2: rattlescript exit 0, affinescript-vite exit 0. The standard library was a local agda-stdlib v2.3 checkout passed with -i, not a version pinned by the repo. Generated .agdai files were deleted, and none are tracked.
  • asciidoctor --failure-level=WARN on both PROOF-STATUS files: exit 0 each.
  • I did not run just proof-check-agda.

Skipped / noticed, not changed

  • The recipe's loop is for f in "$(find ...)" in affinescript-vite (quoted, so it treats all files as one argument). It also exits 0 with "SKIP" when agda is absent. Both are outside the finding.
  • No CI workflow runs the Agda gate. I did not add one, because that would mean editing workflows and pinned uses: lines.

🤖 Generated with Claude Code

https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ

PROOF-POLICY 2.1: the proof-check-agda recipes in rattlescript and
affinescript-vite ran plain --safe, and their template Properties.agda
had no OPTIONS pragma. PROOF-POLICY 8.4: report 0 of 7 instead of 0%.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0165rGu3tsKmJtevmrdMVyfJ
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated proof status reports to show the number of proven obligations rather than a percentage.
  • Chores
    • Agda proof checks now use additional safety and compatibility options.

Both projects now use the same Agda compiler options in their proof modules and check recipes. Their proof status reports express progress as a count of proven obligations out of seven.

Changes: Agda proof checks

Layer / File(s) Summary
Compiler options and proof status
affinescript-ecosystem/affinescript-vite/verification/proofs/agda/Properties.agda, affinescript-ecosystem/affinescript-vite/Justfile, affinescript-ecosystem/rattlescript/verification/proofs/agda/Properties.agda, affinescript-ecosystem/rattlescript/Justfile, affinescript-ecosystem/affinescript-vite/.machine_readable/compliance/PROOF-STATUS.adoc, affinescript-ecosystem/rattlescript/PROOF-STATUS.adoc
Both Agda proof modules and check recipes enable --safe, --without-K and --cubical-compatible. Both status reports replace 0% proven with a count of proven obligations out of seven.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: Minimal · up to 66ea7

The Agda proof checks and templates now use the same stricter options in both projects, and the status reports show an obligation count instead of a percentage. No concrete merge-blocking risk remains. Anyone running very old Agda (before 2.6.3) would need to upgrade, but the repository does not claim to support such versions.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the Agda proof recipes and Properties.agda templates now run with --without-K and --cubical-compatible. The title is a single, specific sentence. The 'fix(proofs)' pre…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is specific and tied to the changeset. It names the affected files and recipes: both proof-check-agda recipes, both Properties.agda templates, and both PROOF-STATUS.adoc reports. It st…
Full details: Title check

Explanation

The title names the main change: the Agda proof recipes and Properties.agda templates now run with --without-K and --cubical-compatible. The title is a single, specific sentence. The 'fix(proofs)' prefix is a conventional commit style, and the title is about proofs as the changeset is.

Full details: Description check

Explanation

The description is specific and tied to the changeset. It names the affected files and recipes: both proof-check-agda recipes, both Properties.agda templates, and both PROOF-STATUS.adoc reports. It states the Agda flags added and the count change from 0% proven to 0 of 7 obligations proven. It also gives verification steps and notes what was not run.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 425b8f76-22de-4887-bbb1-2b50f3e5dfb5
Commits

Reviewing files that changed from the base of the PR and between 279af0e and 66ea7b1.

Files selected for processing: 6

  • affinescript-ecosystem/affinescript-vite/.machine_readable/compliance/PROOF-STATUS.adoc
  • affinescript-ecosystem/affinescript-vite/Justfile
  • affinescript-ecosystem/affinescript-vite/verification/proofs/agda/Properties.agda
  • affinescript-ecosystem/rattlescript/Justfile
  • affinescript-ecosystem/rattlescript/PROOF-STATUS.adoc
  • affinescript-ecosystem/rattlescript/verification/proofs/agda/Properties.agda

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 2

  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
Additional context used

Skipped guideline sources: 15

Not fully prepared for this review (preparing guideline files took longer than 2 minutes): 15 files
  v-ecosystem/v-graphql/.windsurfrules
  v-ecosystem/v-grpc/.cursorrules
  v-ecosystem/v-grpc/.windsurfrules
  v-ecosystem/v-idris-abi/.cursorrules
  v-ecosystem/v-idris-abi/.windsurfrules
  v-ecosystem/v-middleware/.cursorrules
  v-ecosystem/v-middleware/.windsurfrules
  v-ecosystem/v-rest/.cursorrules
  v-ecosystem/v-rest/.windsurfrules
  v-ecosystem/v-telemetry/.cursorrules
  v-ecosystem/v-telemetry/.windsurfrules
  v-ecosystem/v-validator/.cursorrules
  v-ecosystem/v-validator/.windsurfrules
  v-ecosystem/v-zig-ffi/.cursorrules
  v-ecosystem/v-zig-ffi/.windsurfrules
Additional comments: 1

affinescript-ecosystem/affinescript-vite/verification/proofs/agda/Properties.agda: 1

8-8: Functional Correctness

The comment asks whether Agda 2.6.2 is a supported installation. The inspected repository does not declare that version, and it declares no minimum Agda version. The claimed workflow regression depends on that undeclared support premise, so the finding has no source-established consequence. The Agda 2.6.3 introduction of --cubical-compatible is correct, but it does not by itself establish a defect in this repository.

@linear-code
linear-code Bot marked this pull request as ready for review November 17, 2026 22:20
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants