Repository navigation
Add SQ-GEN-05: scan base..head on PRs, keep the full-history scan elsewhere (Hypatia WF031) #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: hyperpolymath/cicd-squabbler
Length of output: 5879
Script executed:
Repository: hyperpolymath/cicd-squabbler
Length of output: 7590
Make the SQ-GEN-05 check require all three full-history triggers.
The check text accepts a fix that keeps only one of the three full-history triggers, because "schedule, dispatch or the default branch" reads as "any one of". The fix column requires all three and forbids removing the full-history scan. Use the same wording in the check as in the fix, so a reviewer cannot accept a partial change.
Apply the same wording change to the SQ-GEN-05 check column in
crates/squabble-core/data/first-line-rules.tsv. The change does not alter the row count or the fix column.Suggested fix
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that the check and fix columns must say the same thing. One refinement before I change it: "keep a full-history scan on schedule, workflow_dispatch and push to the default branch" cannot mean all three if the repository's scan only ever had one of them; the fix can only keep what exists. I will word both columns as "keep the full-history scan on every non-PR trigger it already has (schedule, workflow_dispatch, push to the default branch); at least one must remain, else it is a referral". This is marked minor, so I am carrying it into my next push to this PR and not pushing for it alone.
Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hyperpolymath You’re right. I withdraw my suggestion to require all three triggers. The rule should preserve each existing non-PR full-history trigger and refer the case if none would remain.
The wording change is pending, so I won’t mark the finding as addressed.
Learnings added
You are interacting with an AI system.