Repository navigation
fix(ci): no step outputs interpolated into run:, standards links, PR template #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
46f20cd
fix(ci): no step outputs interpolated into run:, standards links, PR …
claude ce5e0d1
fix(ci): pin dogfood-gate checkout by SHA; rename leftovers in STATE.…
claude a3995a6
Merge branch 'main' into a1/template-and-workflow-fixes
hyperpolymath 04f582d
Merge branch 'main' into a1/template-and-workflow-fixes
hyperpolymath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reconcile the ReScript policy.
This required check bans ReScript.
AI-CONVENTIONS.adocrecommends ReScript, andRSR_OUTLINE.adoclists it as Tier 1. Contributors cannot satisfy all three instructions for a ReScript change. Align the policy sources or identify which instruction takes precedence.Reconcile the Bun policy.
This check identifies Bun as Tier 1, but
AI-CONVENTIONS.adocbans Bun. A contributor following this template can submit a runtime change that conflicts with the documented policy. Align the instructions or identify which one takes precedence.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. The template is right: Bun is tier 1, and ReScript and TypeScript move to AffineScript. RSR_OUTLINE.adoc was deleted in #120. The stale table in AI-CONVENTIONS.adoc is corrected in the follow-up PR #121.
Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 11866
@hyperpolymathThanks for clarifying the policy.#120is merged and removesRSR_OUTLINE.adoc.#121updates the language table, but is still open.The table on this PR’s branch still conflicts with the template. I’m not marking the finding as addressed yet. Please check the combined result after
#121is merged.If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
You are interacting with an AI system.