Repository navigation
fix: close the five review findings left on the A2ML exit (#115) - #118
Conversation
- setup-repo.k9.ncl: checkpoint_files is off by default, and the create-checkpoint-files recipe no longer writes STATE/ECOSYSTEM/META .a2ml; it refuses and points at <repo>_chora.deed and .machine_readable/descriptiles/STATE.deed. - RELEASE-RUNBOOK.adoc: every phase-status instruction that named STATE.a2ml now names the root ROADMAP.adoc, as the status note at the top already says; the Verpex VPS reference points at the portal spec. - rhodibot.yml: the A2ML check scans the whole tree, 9-archive/ included, and fails on any .a2ml except the three kept files (verisim/config.a2ml, verisim/seed/clades.a2ml, verisim/seed/forges.a2ml). The uses: lines are unchanged. - .clinerules line 16: identity is the root chora-registry_chora.deed; descriptive deeds live in .machine_readable/descriptiles/. - RSR_OUTLINE.adoc: the gone just state-touch is replaced by the manual :affirmed review of STATE.deed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…anifest pointer-only (#120) ## Summary This closes three departures that #118 reported and left open. Cut from main da23811. ## Changes - **`docs/RSR_OUTLINE.adoc` is deleted.** This is an **owner ruling, given by selector to the A1 session on 2026-11-14**: the file is a stale copy of the rsr-template-repo README, and nothing reads it. Its Palimpsest badges go with it. A grep for `RSR_OUTLINE` (and `rsr-outline`, `RSR Outline`) finds no link to repoint. - **The agent rule files** (`.machine_readable/ai/.clinerules`, `.cursorrules`, `.windsurfrules`, `.github/copilot-instructions.md`): - The banned-language lines follow the current policy: - TypeScript and ReScript → AffineScript; - Node.js and yarn → Bun (order Bun > Deno > pnpm > npm, npm only as the last resort); - Go → Rust; - Python → AffineScript, Rust or Julia, with no exceptions. - All four had said TypeScript → ReScript, Node/npm/bun → Deno, and Python → Julia or Rust. - Each now points at `docs/practice/AI-CONVENTIONS.adoc`, which exists; `docs/AI-CONVENTIONS.md` does not. `PLACEHOLDERS.adoc` names the `.adoc` path too. - **`0-AI-MANIFEST.deed` is pointer-only (A7 ruling Q15).** - Removed `:canonical-name`, `:repo-uuid` and `:beholding-chora`. What is left is `:schema-version` and `(front-doors …)`. - `chora-registry_chora.deed` carries the same `:repo-uuid` (`a65b74d8-351a-89d9-a38d-aea470863b03`) and `:beholding-chora` (`0889b37b-…00e`). No id and no domain changes. - The header comment now names the repo as the chora-registry (formerly gv-clade-index). - Nothing reads identity from the manifest. I grepped the Justfile (`validate-rsr`), `contractile.just`, `worker/src/`, `scripts/`, `sync/`, `.github/hooks/`, `governance.yml`, `dogfood-gate.yml`, and the standards scripts that `governance.yml` calls. `validate-a2ml.sh` takes identity from the `(repo-deed` head. `dogfood-gate.yml`, `governance.yml` and the PR template are untouched, because #119 owns them. ## Testing - `scripts/check-registry.sh`: PASS, at both commits. - `tests/check-registry-test.sh`: PASS, 19 planted failures fire. - `deed_lint.js 0-AI-MANIFEST.deed chora-registry_chora.deed`: OK, OK. - `.github/hooks/validate-a2ml.sh`: passed, both before (da23811) and after. - `just validate-rsr`: fails the same way before and after. The files it lists as missing are already absent on main, and this PR doesn't touch them. - `just fmt-check`, `just lint` and `just validate-state`: clean. ## Not done here - `.machine_readable/descriptiles/STATE.deed` and `TOPOLOGY.adoc` still name the repo `gv-clade-index`, and `STATE.deed` has it in `:canonical-name`. Left for the registry session. - `dogfood-gate.yml` pins `actions/checkout` by tag, not by SHA. That file belongs to #119. ## Licence No licence or SPDX edits. The PMPL `add-license` recipe in `setup-repo.k9.ncl` is left alone and flagged only. The Palimpsest badges went only because the owner ruled the whole file deleted. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC --------- Co-authored-by: Claude <noreply@anthropic.com>
…template (#119) ## Summary This PR fixes items (a) and (b), as the owner ruled by selector in the A1 thread on 2026-11-14. Items (c) RSR_OUTLINE and (d) the /v1 shape are recorded for later decisions. Item (e), the PMPL fetch in `setup-repo.k9.ncl`, is flag-only, because licence edits are manual. ## Changes - **`dogfood-gate.yml`.** The five "Write summary" steps now receive their step outputs through `env:` and read them as shell variables. Before, `${{ steps.*.outputs.* }}` was interpolated straight into `run:` scripts, which is an injection pattern. No `${{ }}` is left in any `run:` block. - **`governance.yml`.** - `hyperpolymath/standards` becomes `metadatastician/standards`, its current home. The standards-only branches (`if [ "$GITHUB_REPOSITORY" = …standards ]`) can therefore match again. - `${{ github.repository }}` inside `run:` becomes `$GITHUB_REPOSITORY`. It is still used in `with: repository:`, where it is safe. - **`.github/pull_request_template.md`.** - Bun is tier 1, not banned. The banned-language line now reads: TypeScript, ReScript, Node/npm as a runtime, Go and Python. - `TOPOLOGY.md` is corrected to `TOPOLOGY.adoc`. ## Testing - Both workflows parse as YAML. - `awk` confirms that no `${{ … }}` remains inside a `run:` block in `dogfood-gate.yml`. - The registry files are not touched, so the registry gate is unaffected. This PR does not overlap #118. Like #118, it is left as a draft for the owner to merge. --- _Generated by [Claude Code](https://claude.ai/code/session_0136P7ZoUeC49fDEvSwDNvuS)_ --------- Co-authored-by: Claude <noreply@anthropic.com>



Summary
#115 merged with five Codex P2 findings still open. This PR fixes them. A1, who owns this repo, asked for it as a PR separate from the rename (#117). It is cut from main 57607d3, which already includes #117.
Changes
.machine_readable/svc/k9/examples/setup-repo.k9.nclcheckpoint_filesnow defaults tofalse, with a comment pointing to the root<repo>_chora.deedand.machine_readable/descriptiles/STATE.deed.create-checkpoint-filesrecipe no longer writes STATE/ECOSYSTEM/META.a2mlfiles. It prints a pointer to the deed and exits 1.docs/governance/RELEASE-RUNBOOK.adoc: the bookkeeping rule and the Phase 2/3/4/6 gates now update the phase Status in the rootROADMAP.adoc. The VPS fact citesdocs/SPEC-clade-verisim-portal.adocLayer 3. NoSTATE.a2mlreferences remain..github/workflows/rhodibot.yml9-archive/included, and fails on any.a2mlexcept the three allowlisted files:verisim/config.a2ml,verisim/seed/clades.a2mlandverisim/seed/forges.a2ml.${{ }}inrun:, and theuses:lines are unchanged..machine_readable/ai/.clinerules, line 16 only: identity is the rootchora-registry_chora.deed; descriptive deeds live in.machine_readable/descriptiles/.docs/RSR_OUTLINE.adoc:122:just state-touchis replaced by the manual:affirmedreview. The Justfile is not edited.Verification
9-archive/old/STATE.a2mlplusdocs/stray.a2ml: rc=1;9-archive/plant: rc=1;0-AI-MANIFEST.a2mlplus the near-missverisim/seed/x/clades.a2ml: both flagged, rc=1;scripts/check-registry.sh: PASS, 327 repos. Also PASS against main'srepos.json: no id changed.tests/check-registry-test.sh: PASS, all 19 planted failures fire.just fmt-check,just lintandjust validate-state: OK.nickel typecheckandnickel exporton the k9 component: OK..a2mlis created, and no id is changed.Departures seen, not fixed
docs/RSR_OUTLINE.adocis still a stale template copy: it recommends A2ML files, says to use Deno and not Bun, lists ReScript as tier 1, and carries Palimpsest badges (licence material, flag only)..clineruleslines 27–30 reverse the current policy ("TypeScript → ReScript", "bun → Deno"), and line 3 points at a missing.md.add-licenserecipe insetup-repo.k9.nclfetches PMPL-1.0. That is licence drift, flag only.dogfood-gate.ymlinterpolates${{ steps.detect.outputs.* }}intorun:.Generated by Claude Code