Skip to content

chore(a2ml): move boj-server off A2ML; CLAUDE.md follows the current runtime ruling - #383

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/a2ml-to-deed
Nov 14, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
chore/a2ml-to-deed

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

The owner approved this on 2026-11-14. It follows hyperpolymath/hypatia#1113 and deletes 48 of the 52 .a2ml files. docs/history/A2ML-REMOVED.adoc records each one with size, sha256 and blob id, plus the files kept and the questions still open.

Changes

Translated into boj-server_chora.deed, following the mapping specs. Fields a spec doesn't list are dropped, and a deed comment names each one.

  • META → (meta), including 14 (adr) clauses. license is left out because meta open question 2 is unruled.
  • PLAYBOOK → (playbook).
  • ANCHOR → (anchor :schema "hyperpolymath.anchor/2" :authority "upstream-canonical" …), under A7 §6.4.
  • CLADE, AGENTIC and NEUROSYM were already translated. Three (status) fields outside the clade spec are removed.
  • 0-AI-MANIFEST.a2ml → a pointer-only 0-AI-MANIFEST.deed (Q15) with the same :repo-uuid. The id is unchanged.

Deleted, with no spec and no reader (grepped across the repo and the org):

  • 19 directory manifests;
  • ENSAID_CONFIG and dev-toolchain;
  • the agent_instructions, contractile, integrations and policies files;
  • servers/menu.a2ml and servers/order-ticket.a2ml (the live menu is GET /menu, built from cartridge.json);
  • docs/examples/extension.a2ml.

Kept, with the reasons in the ledger:

  • 6a2/ECOSYSTEM.a2ml, cut by deletion only to its [publishing.readme] block, which readme-derive.yml reads;
  • audits/assail-classifications.a2ml, because no released panic-attack reads the deed yet;
  • .boj/project-memories.a2ml;
  • panll/src/Boj.a2ml.

Readers moved off the deleted files:

  • Justfile recipes (validate-rsr, which was failing on main and now passes; validate-state and others);
  • the contractile runners;
  • agent files and docs.

.claude/CLAUDE.md:

  • The runtime is Bun > Deno > pnpm > npm, with package.json plus bun.lock required.
  • The garbled line now says ReScript is no longer the destination.
  • The Machine-Readable section points to the deeds and the ledger.

No licence or SPDX line was changed.

Verification

  • deed_lint passes on both deeds, and --anchor passes.
  • check-uuid-v8.sh --strict: exit 0.
  • validate-a2ml.sh and validate-k9.sh pass.
  • scripts/pre-merge-gate.sh --offline passes.
  • just validate-rsr and just validate-state pass.

These were already failing on main and still fail: just validate (AI_INSTALLATION_GUIDE missing), just --fmt --check, and nickel on bust.ncl.

For the owner

The ledger lists the open points:

  • the source of (clade :rationale);
  • META license;
  • an out-of-date anchor implementation-policy;
  • Trustfile runbook steps that now have no file;
  • departures not touched here: report_format = "a2ml", the pre-commit hook, the k9 example, the <name>.a2ml.json cartridge manifests, the dep5 lines (flagged only), and bun.lock missing.

Generated by Claude Code

…s, move the readers, delete 48 of 52 files

The owner approved on 2026-11-14 moving boj-server off A2ML, as
hyperpolymath/hypatia#1113 did for hypatia.

Translated into boj-server_chora.deed under standards
1-formats/deed/mappings/ (a field no table lists is dropped):
- META -> (meta) with 14 (adr) clauses and the maintenance axes; the
  licence field is held back (meta spec open question 2).
- PLAYBOOK -> (playbook) with the five slot positions.
- ANCHOR -> (anchor), hyperpolymath.anchor/2, by A7 section 6.4.
- CLADE, AGENTIC and NEUROSYM were already translated; the files go.
- STATE -> nothing new (option B: status is (status), no maturity was
  named, the journal is archived by reference).
- ECOSYSTEM -> nothing (no table rows match; P-6 fails).
- 0-AI-MANIFEST.a2ml -> pointer-only 0-AI-MANIFEST.deed (Q15).
The three (status) fields outside the clade spec's table are removed;
:evidence-source named STATE.a2ml.

Deleted with no mapping spec and no reader: the directory manifests,
ENSAID_CONFIG, dev-toolchain, agent_instructions, the six contractile
.a2ml files, integrations, policies, servers/menu and order-ticket,
docs/examples/extension.a2ml.

Kept, each with its reason in docs/history/A2ML-REMOVED.adoc:
- .machine_readable/6a2/ECOSYSTEM.a2ml, trimmed to [publishing.readme],
  which readme-derive.yml still reads;
- audits/assail-classifications.a2ml (panic-attack);
- .boj/project-memories.a2ml (owner's coord-tui hook); its stale
  STATE.a2ml step is deleted;
- panll/src/Boj.a2ml (PanLL CladeLoader).

Readers moved: the Justfile's validate-rsr, validate-state, state-phase,
state-touch and info recipes read the chora deed (validate-rsr now
passes); sync-metadata (an A2ML no-op) is removed; the contractile
runners name <Verb>file.deed. Agent and doc pointers (.claude/CLAUDE.md,
copilot instructions, ai.txt, PR template, AI-CONVENTIONS, warm-up and
developer docs) point at the deeds and the ledger.

.claude/CLAUDE.md also corrects two departures: the runtime is Bun
(Bun > Deno > pnpm > npm, package.json + bun.lock required), and
ReScript, not AffineScript, is no longer the migration destination.

No LICENSE or SPDX header is changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Summary

Summary by CodeRabbit

  • Documentation
    • Repository guidance and project-state records now use deed-based sources instead of retired A2ML files.
    • Updated contributor and reference materials to describe the live /menu endpoint and cartridge catalogue.
    • Added a history of retired A2ML content and its recorded destinations.
  • Chores
    • Removed legacy A2ML manifests, state files, policies and configuration records.

The PR retires most repository A2ML files, adds deed-based repository metadata and pointers, and updates command recipes, contract references, guidance, and documentation. A history document records removed files, mapped content, retained files, and outstanding items.

Changes: A2ML Retirement and Deed Migration

Layer / File(s) Summary
Deed records and mapped state
0-AI-MANIFEST.deed, boj-server_chora.deed, .machine_readable/6a2/*, .machine_readable/6a2/anchor/*, .machine_readable/policies/*
The new manifest points to the chora deed. The deed adds metadata, playbook, and anchor clauses, and documents mappings and omitted fields from selected A2ML files. Related state, metadata, agent, playbook, and policy files are removed.
Command and contract consumers
Justfile, .boj/project-memories.a2ml, .machine_readable/contractiles/*
Justfile state and validation recipes now read deed data or report that no timestamp is maintained. Contract pairing metadata points to deed files. The generated contractile header records the retirement and warns against regenerating from retired A2ML files.
Retired A2ML files and manifests
.github/0.1-AI-MANIFEST.a2ml, .machine_readable/*, container/*, docs/examples/extension.a2ml, verification/*
The PR deletes A2ML manifests, policies, contract files, integrations, server specifications, toolchain declarations, and verification manifests. It also removes the A2ML menu and order-ticket specifications and the extension example.
Guidance, history, and replacement references
.claude/CLAUDE.md, .github/*, .well-known/ai.txt, site/.well-known/ai.txt, docs/*, .machine_readable/ai/README.adoc
Guidance and documentation identify deed files as repository sources and describe the A2ML retirement. The new history document lists removed and retained files, recorded destinations, and open points. Menu references now describe GET /menu and cartridge cartridge.json files.

Estimated code review effort: 4 (Complex) | ~60 minutes

Change: Other

Merge Risk: Low · up to ba0f1

This change retires most A2ML files in favour of deed files and updates the related docs and recipes. It is mostly documentation, but a few instructions still contradict each other or point at retired files. The lifecycle validation recipe also does not fail when the deed is invalid. These are small fixes that should be made, but they do not block merging.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:28:58.482160Z ba0f150 PR opened
🔒 Security Review ✅ Completed 2026-11-14T20:26:03.510604Z ba0f150 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 68 issues detected

Severity Count
🔴 Critical 1
🟠 High 12
🟡 Medium 55

⚠️ Action Required: Critical security issues found!

View findings (sorted by severity)
[
  {
    "line": 70,
    "reason": "believe_me undermines formal verification (4 occurrences, CWE-704, line 70, 269, 279, 289)",
    "type": "believe_me",
    "file": "/home/runner/work/boj-server/boj-server/src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_safety",
    "action": "flag",
    "severity": "critical",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/src/abi/Boj/SafetyLemmas.idr",
          "end_line": 70,
          "start_line": 70
        },
        "rule": "code_safety/believe_me",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Step uses `peter-evans/repository-dispatch` with `token: ${{ secrets.FARM_DISPATCH_TOKEN }}` but has no `if: secrets.FARM_DISPATCH_TOKEN != ''` gate. On repos where the secret hasn't been propagated the action fails on every push, red-maining the repo. Add the step-level gate (or env+if pattern) so the missing-secret path is a clean skip instead of a red.",
    "type": "secret_action_without_presence_gate",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "workflow_audit",
    "action": "peter-evans/repository-dispatch",
    "severity": "high",
    "fix_recipe": "add_secret_presence_gate",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "workflow_audit/secret_action_without_presence_gate",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 29,
    "reason": "job `deploy` in .github/workflows/pages-deploy.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring; it holds the credential next to fetched code (a piped installer or a dependency install/build) in the same step",
    "type": "RE001",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 29,
          "start_line": 29
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/workflow_audit/secret_action_without_presence_gate -- Hypatia workflow_audit: secret_action_without_presence_gate -- 41 day(s) old [STALE]",
    "type": "CSA001",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/code_safety/believe_me -- Hypatia code_safety: believe_me -- 44 day(s) old [STALE]",
    "type": "CSA001",
    "file": "src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "src/abi/Boj/SafetyLemmas.idr",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/proofs.yml is 33 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/proofs.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/proofs.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/structural_drift/SD007 (medium) at .claude/CLAUDE.md is 38 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".claude/CLAUDE.md",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".claude/CLAUDE.md",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/workflow_audit/secret_action_without_presence_gate (high) at .github/workflows/instant-sync.yml is 41 days old (threshold: 7 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/workflow_audit/missing_timeout_minutes (medium) at .github/workflows/pages-deploy.yml is 41 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/code_safety/zig_bit_cast (medium) at ffi/zig/src/cartridge_shim.zig is 44 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": "ffi/zig/src/cartridge_shim.zig",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "ffi/zig/src/cartridge_shim.zig",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/code_safety/believe_me (high) at src/abi/Boj/SafetyLemmas.idr is 44 days old (threshold: 7 days) -- overdue for remediation",
    "type": "CSA003",
    "file": "src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "src/abi/Boj/SafetyLemmas.idr",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/push-email-notify.yml is 54 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/push-email-notify.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/push-email-notify.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/dogfood-gate.yml is 54 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/dogfood-gate.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/dogfood-gate.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Job `deploy` in pages-deploy.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
    "type": "missing_timeout_minutes",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "workflow_audit",
    "action": "flag",
    "severity": "medium",
    "recipe_id": "recipe-add-workflow-timeout-minutes",
    "job": "deploy",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "workflow_audit/missing_timeout_minutes",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 44,
    "reason": "job `build-and-push` in .github/workflows/container-publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/container-publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/container-publish.yml",
          "end_line": 44,
          "start_line": 44
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 37,
    "reason": "job `sonarqube` in .github/workflows/build.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/build.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/build.yml",
          "end_line": 37,
          "start_line": 37
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 88,
    "reason": "job `publish-bun` in .github/workflows/publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/publish.yml",
          "end_line": 88,
          "start_line": 88
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 122,
    "reason": "job `publish-jsr` in .github/workflows/publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/publish.yml",
          "end_line": 122,
          "start_line": 122
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 34,
    "reason": "job `dispatch` in .github/workflows/instant-sync.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 34,
          "start_line": 34
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 278,
    "reason": "job `scan` in .github/workflows/hypatia-scan.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring; it holds the credential next to fetched code (a piped installer or a dependency install/build)",
    "type": "RE001",
    "file": ".github/workflows/hypatia-scan.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/hypatia-scan.yml",
          "end_line": 278,
          "start_line": 278
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 46,
    "reason": "job `notify` in .github/workflows/push-email-notify.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/push-email-notify.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/push-email-notify.yml",
          "end_line": 46,
          "start_line": 46
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 38,
    "reason": "workflow .github/workflows/fuzz.yml:38 step `Run core FFI fuzz tests` swallows non-zero exit via `continue-on-error: true` AND `|| true` — failures will be masked",
    "type": "RE005",
    "file": ".github/workflows/fuzz.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/fuzz.yml",
          "end_line": 38,
          "start_line": 38
        },
        "rule": "research_extensions/RE005",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 224,
    "reason": "workflow .github/workflows/abi-drift.yml:224 step `Scope cartridges to verify` swallows non-zero exit via `|| true` — failures will be masked",
    "type": "RE005",
    "file": ".github/workflows/abi-drift.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/abi-drift.yml",
          "end_line": 224,
          "start_line": 224
        },
        "rule": "research_extensions/RE005",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 22,
    "reason": "workflow .github/workflows/pages-deploy.yml:22 job `deploy` has no `timeout-minutes:` — defaults to 360 min on hang",
    "type": "WH006",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "workflow_hardening",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 22,
          "start_line": 22
        },
        "rule": "workflow_hardening/WH006",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 175,
    "reason": "Zig @bitCast reinterprets bits without type checking (1 occurrences, CWE-704, line 175)",
    "type": "zig_bit_cast",
    "file": "/home/runner/work/boj-server/boj-server/ffi/zig/src/cartridge_shim.zig",
    "level": "epi",
    "rule_module": "code_safety",
    "action": "flag",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/ffi/zig/src/cartridge_shim.zig",
          "end_line": 175,
          "start_line": 175
        },
        "rule": "code_safety/zig_bit_cast",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba0f150f80

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/CLAUDE.md
- **No new TypeScript** — convert existing TS to AffineScript (`.affine`) directly; AffineScript is no longer the destination as of 2026-04-30.
- **Deno** for the runtime, not Node. `deno.json` for imports, no `node_modules` in production.
- **No new TypeScript or ReScript** — convert existing TS/ReScript to AffineScript (`.affine`) directly; ReScript is no longer the destination as of 2026-04-30.
- **Bun** for the JS runtime (order Bun > Deno > pnpm > npm; npm only as the last resort), not Node. JS dependencies are declared in `package.json` and pinned by `bun.lock`; both are required. `bun install --production` for production dependencies.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize the Bun policy across contributor guidance

When contributors or Copilot follow the other repository instructions, this new Bun requirement conflicts with docs/AI-CONVENTIONS.adoc:88-89 and .github/copilot-instructions.md:39-40, which still ban Bun and require Deno, while .github/pull_request_template.md:24 asks authors to certify that no Bun is used. This can cause agents to remove or reject the package.json/bun.lock setup now required here, so update those policy surfaces together with this runtime ruling.

Useful? React with 👍 / 👎.

Comment on lines +208 to +209
Write the descriptor as a cartridge manifest (currently `cartridge.json`); see
link:../EXTENSIBILITY.adoc[EXTENSIBILITY] §1 for the format. The fields are:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Provide a valid JSON cartridge descriptor

When a contributor follows this instruction and saves the immediately following TOML block as cartridge.json, BojRest.Catalog.load_one/2 rejects it at Jason.decode before schema validation; the operative schemas/cartridge-v1.json also expects flat required keys such as $schema, spdx, name, and tier, rather than [extension] and [metadata] tables. Replace the example with valid schema-conforming JSON or continue naming a format that accepts this syntax.

Useful? React with 👍 / 👎.

Comment on lines +85 to +87
| 781
| `c9e945d66d069efbdee9d9d3c3de451f1f52e924da1fccae131c900fbfe69420`
| `6bf1f8c7f3805520515a5106f68b8cc8d53ad993`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct the archived root manifest checksums

The size, SHA-256, and blob ID recorded here belong to .machine_readable/6a2/0-AI-MANIFEST.a2ml, not the deleted root 0-AI-MANIFEST.a2ml. At the reviewed parent, the root file is 5054 bytes with SHA-256 147b9d52b16ea780dcdd318ccfeabe4fe0da1bd433ba7020b250d349a2b0bcb4 and blob e8f6c4b3a23f10a9002a336598e8af403da1aa52; leaving the duplicate values defeats the ledger's purpose of identifying and verifying the exact retired artifact.

Useful? React with 👍 / 👎.

-d '{\"task_id\":\"<your-task-id>\"}'")
(step 3 "Read the plan"
"cat .machine_readable/6a2/STATE.a2ml # look for [expansion-roadmap]"))
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the remaining live STATE.a2ml update instruction

Removing the startup read does not fully migrate this live worker briefing: its backend template still requires a STATE.a2ml backend count update at line 65. Because the commit deletes that file and this briefing is retained specifically because an external hook prepends it to worker sessions, backend workers following the completion checklist are still directed to modify a nonexistent retired artifact; replace that wiring item with the new roadmap/deed target or remove it.

Useful? React with 👍 / 👎.

| `abdb3ecb8fae889a5ae4a9e84ffe5dc6d76c55acbe35a7ca47b8c16106671498`
| `4a684faaf9b80241083987d6ba03ce3d43548b51`
| Trust contractile: threat model, DNS, email, TLS, Cloudflare edge, headers, container and dependency supply chain, gateway, proofs, verification ladder, signature block.
| Deleted: no mapping spec, no machine reader. `trust.ncl` now names `Trustfile.deed`, not yet written. Runbook steps that flip a Trustfile status (`docs/integration/hcg-tier2-rollout-runbook.adoc`) have no target until it exists.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve a target for gateway rollout attestation

Deleting this contract while its deed replacement does not exist makes the production HCG rollout impossible to close out as documented: docs/integration/hcg-tier2-rollout-runbook.adoc:565-587 requires the final action to flip tier_2_gateway.status and link that commit in the closure comment, and lines 630-633 identify this file as the current authoritative target. Retain the legacy file until Trustfile.deed exists, or migrate the status and update the runbook in the same change, rather than landing a period where deployment evidence has nowhere to be recorded.

Useful? React with 👍 / 👎.

@hyperpolymath
hyperpolymath merged commit 71ce950 into main Nov 14, 2026
45 of 46 checks passed
@hyperpolymath
hyperpolymath deleted the chore/a2ml-to-deed branch November 14, 2026 20:29
hyperpolymath added a commit that referenced this pull request Nov 14, 2026
## Summary

#383 was squash-merged with five Codex P2 findings still open. All five
were real on main (559004b), and this PR fixes them. It is a new branch
cut from main, because this repo squash-merges.

## Changes

1. **Bun policy, everywhere.**
- `docs/AI-CONVENTIONS.adoc` gets a new JavaScript Runtime section: Bun
> Deno > pnpm > npm, both `package.json` and `bun.lock` required, no
TypeScript.
   - `.github/copilot-instructions.md` says the same.
- `.github/pull_request_template.md` no longer asks authors to certify
"no Bun". It asks for Bun first.
2. **Where the tier-2 gateway status lives.** The Trustfile contract was
deleted, but the rollout runbook still named it as the target for its
final attestation.
- The status (`PENDING`) is now a "Tier-2 gateway status" item under
v1.1.0 in `docs/status/ROADMAP.adoc`.
- The runbook (§0, §1.2, §1.4, §5.3, §6, §6.4, Appendices A and B)
points there.
- The ledger records the move, and says the status goes to
`Trustfile.deed` once that form exists.
   - No new deed form is invented.
3. **`docs/wikis/Developer-Guide.adoc`.**
- The TOML block presented as `cartridge.json` is replaced with JSON
that validates against `schemas/cartridge-v1.json`.
- The example name changes to `database-pg-mcp`, because the schema
requires the role suffix last. The old name fails, which serves as the
negative control.
   - A dead `EXTENSIBILITY.md` link now points at the `.adoc` file.
4. **`.boj/project-memories.a2ml`.** The `STATE.a2ml backend count
update` item is removed by deletion only; nothing is added. The ledger
row is re-hashed.
5. **`docs/history/A2ML-REMOVED.adoc`.** The root `0-AI-MANIFEST.a2ml`
row carried the values of the `.machine_readable/6a2/` copy. Its real
values at ad5bcdb are 5054 bytes, sha256 `147b9d52…`, blob `e8f6c4b3…`.
All 52 rows were rechecked against ad5bcdb, and this was the only wrong
one.

## Verification

- The example JSON is checked with ajv 8.17.1 (draft 2020-12, run under
Bun): VALID, and the old name is INVALID.
- asciidoctor.js reports 0 warnings on the 6 changed `.adoc` files.
- `just validate-rsr`: PASS. `just validate-state`: valid.
- `validate-a2ml.sh`: 0 errors. `git diff --check`: clean.
- `just validate` fails only at `validate-ai-install`, and fails the
same way on main.

## Seen, not fixed (for the owner)

- There is no `bun.lock` at the root, though `package.json` exists.
- `docs/EXTENSIBILITY.adoc` §1 has the same TOML-as-JSON block, a
`backend` field the schema doesn't have, and names that break the
role-suffix rule.
- Other references to the retired Trustfile remain
(`elixir/README.adoc`, `contractile.just`, CODEOWNERS, gateway docs, the
maintenance checklist).
- Several integration docs link to `.md` files that are `.adoc`.

---
_Generated by [Claude
Code](https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC)_

Co-authored-by: Claude <noreply@anthropic.com>
hyperpolymath added a commit that referenced this pull request Nov 14, 2026
…strip the AI manifest to pointers (#386)

## Summary

Small debts, docs and metadata only. No code, workflow, licence or
lockfile changes.

## Changes

- **`docs/EXTENSIBILITY.adoc`**
- The descriptor example was TOML in a file named `.cartridge.json`. It
is now a `cartridge.json` that validates against
`schemas/cartridge-v1.json` (checked with ajv, draft 2020-12). It uses
the role-suffixed name the schema requires: `database-pg-mcp`. The
schema rejects `database-mcp-pg`.
- The C `boj_ext_invoke` export is replaced by the ADR-0006 five-symbol
Zig FFI, taken from
`templates/cartridge-template/ffi/cartridge_ffi.zig`.
- The C `#include "boj_catalogue.h"` registration is replaced by Zig
`extern` declarations that match `ffi/zig/src/catalogue.zig`. Constants
are from `generated/abi/boj_catalogue.h`.
  - The menu JSON now has the shape that `boj_menu_json` writes.
- The REST text now matches the router. `POST /community/submit` is
specified (openapi, gateway policy) but `router.ex` does not serve it.
`/cartridges` takes no `domain` or `backend` parameters. The examples
use `"$BOJ_URL"` instead of `http://localhost`.
- The spec link now points to `README.adoc`. The doc also says the
backend label lives in the catalogue, not in `cartridge.json`.
- **Trustfile references.** `Trustfile.a2ml` was retired in #383 with no
mapping spec. `Trustfile.deed` is not yet written, and the tier-2 status
lives in `docs/status/ROADMAP.adoc`. Updated these files to say so:
  - the integration docs
  - the maintenance checklist (the false `[x]` is now unchecked)
  - the v1 plan
  - `elixir/README.adoc`
- the contractiles README, which named `Trustfile.hs` and
`lust/Intentfile`

ADRs 0003/0004, the dated audit and the 3b completion snapshot keep
their historical wording.
- **`0-AI-MANIFEST.deed`** is now pointer-only, per A7 ruling Q15.
`:canonical-name`, `:repo-uuid` and `:beholding-chora` are removed.
`boj-server_chora.deed` carries identical values, and no id or domain
was changed.

## Testing

- `deed_lint.js`: `OK 0-AI-MANIFEST.deed`, `OK boj-server_chora.deed`
- Governance scripts at the pinned standards SHA `1725beb` all pass:
workflows-parse, lock-sync, close-lock, duplicate-keys,
licence-consistency, language-policy, ts-allowlist, package-policy,
docs-presence, uuid-v8 `--strict`, trusted-base, exemption and debt
ratchets.
- These also pass: `validate-a2ml.sh`, `validate-k9.sh`,
`check-shebang-first.sh` and `just validate-rsr`.
- Asciidoctor.js renders every changed `.adoc` with 0 warnings. `git
diff --summary` shows no mode changes.

---
_Generated by [Claude
Code](https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants