Skip to content

fix(ffi): bring ffi main.zig to the template form - #32

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/ffi-main-template-form
Nov 14, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/ffi-main-template-form

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Proven 3-outcome fails on main with src/main.zig:279: error: use of undeclared identifier 'dupeZ'. The template upgrade (#10) added tests/ffi_strings_test.sh, which calls the template's module-level dupeZ helper (Allocator.dupeZ was removed in Zig 0.17), but did not apply the matching src/interface/ffi/src/main.zig.

main.zig on main differed from the template only by the project name, so this is the template file with the name filled in. Same fix as Apodeixis.jl#18. Nothing else changes.

Not proven: the Zig toolchain is not installed here, so the test was not run locally; CI on this head is the evidence.


Generated by Claude Code

The template added a module-level dupeZ helper to main.zig after this
repository was cut from it (Allocator.dupeZ was removed in Zig 0.17). The
template upgrade added tests/ffi_strings_test.sh, which calls that helper,
but did not apply the matching main.zig change, so the test fails to compile
with "use of undeclared identifier 'dupeZ'". Proven 3-outcome fails on main
for this reason.

main.zig differed from the template only by the project name, so the change
is the template file with the name filled in. Nothing else changes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d5e5111 and 8c2a9a6.

Files selected for processing: 1

  • src/interface/ffi/src/main.zig

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 17:19
@hyperpolymath
hyperpolymath merged commit 7a85748 into main Nov 14, 2026
33 of 37 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T17:20:52.407075Z 8c2a9a6 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-14T17:22:04.761151Z 8c2a9a6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath deleted the fix/ffi-main-template-form branch November 14, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants