Repository navigation
docs: PROOF-STATUS.adoc to the template form, token filled, seven obligations as open rows (replaces #17) - #23
hyperpolymath wants to merge 1 commit into
Conversation
…m, with the seven obligations as open rows Replaces #17. The template-form PROOF-STATUS.adoc, with the {{PROJECT}} title token filled (bactrian), and the seven mandatory obligations from PROOF-NEEDS.adoc (ABI-1..5, TP-1, TP-2) restated as rows with status token open, PWG ungraded and no receipt, so the census sees open obligations. No row claims a proof. Row text is copied from PROOF-NEEDS.adoc. witness-map.ncl is unchanged from #17. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afea451a3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | TP-1 | Core data type well-formedness | TP | Idris2 | P1 | 4h | ||
| | TP-2 | Public API type safety | TP | Lean4 | P2 | 4h | ||
| |=== | ||
| none |
There was a problem hiding this comment.
Record the existing ASSUMED bridge
The none declaration is false for this repository: .machine_readable/coaptation/core/Coaptation.idr lines 28–31 and .machine_readable/coaptation/README.adoc lines 47–50 explicitly classify the unverified model-to-Nickel correspondence as ASSUMED. Since this section instructs maintainers to list every such boundary, leaving it as none hides a trust dependency from proof-status readers and the estate census; record the bridge and the claims that rely on it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified, the finding is right and this is my miss. .machine_readable/coaptation/core/Coaptation.idr lines 28-31 and .machine_readable/coaptation/README.adoc lines 47-50 classify the model-to-Nickel correspondence as ASSUMED, so "none" was false. The fix is to record that bridge in Trust boundary: the Idris2 model is argued, not kernel-checked, to be a faithful transcription of coapt.ncl, which stays authoritative. No row in the Claims table rests on it (the seven rows are the ABI and type proofs), and the section should say so.
I have the fix ready but cannot push it to this branch: its push guard lists a code-coverage rule that an update push would bypass, and I do not bypass gates. It will go in as a replacement PR from a new branch name once the sweep agrees. Left open until then.
Generated by Claude Code
| == Claims | ||
|
|
||
| [cols="1,3,1,1,1,1,2",options="header"] | ||
| |=== | ||
|
|
||
| == Proofs Blocked | ||
|
|
||
| [cols="1,3,2,3", options="header"] | ||
| |=== | ||
| | ID | Proof | Blocked By | Notes | ||
|
|
||
| | — | — | — | — | ||
| | ID | Claim (and the artefact that proves or tests it) | Token | PWG | Rocq leg | Lean leg | Receipt |
There was a problem hiding this comment.
Keep the proof-status command compatible with the new table
After this rewrite removes the Total summary row, just proof-status no longer displays any status: build/just/proofs.just lines 55–58 only greps for that row and otherwise prints (No summary row in docs/status/PROOF-STATUS.adoc). Update that recipe to summarize or print the new per-claim table so the repository's documented status command remains functional.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified, the finding is right: build/just/proofs.just lines 55-58 only grep for a Total row, so just proof-status prints "(No summary row ...)" against the template-form table. The fix belongs at source, in the template, not here. rsr-template-repo#385 adds scripts/proof-claims-rows.sh (prints the rows of the == Claims table, with 8 controls) and points the recipe at it. This repository gets it with the next template sync. I am not patching the recipe here, to keep this PR to the PROOF-STATUS form. Left open until #385 lands.
Generated by Claude Code
|
Closing in favour of #27, which carries the same two files plus the Trust boundary fix (the ASSUMED coaptation bridge, found by Codex). The push guard on this branch lists a code-coverage rule that an update push would bypass, so the fix goes in as a replacement from a new branch. The branch stays for the owner to delete. Generated by Claude Code |
…UMED bridge (replaces #23) (#27) * docs: bring PROOF-STATUS.adoc and witness-map.ncl to the template form, with the seven obligations as open rows Replaces #17. The template-form PROOF-STATUS.adoc, with the {{PROJECT}} title token filled (bactrian), and the seven mandatory obligations from PROOF-NEEDS.adoc (ABI-1..5, TP-1, TP-2) restated as rows with status token open, PWG ungraded and no receipt, so the census sees open obligations. No row claims a proof. Row text is copied from PROOF-NEEDS.adoc. witness-map.ncl is unchanged from #17. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ * docs: record the ASSUMED coaptation bridge in the proof-status trust boundary The trust boundary said none, but the coaptation README and Coaptation.idr declare the Idris2-model-to-coapt.ncl correspondence ASSUMED (argued, not kernel-checked). List it, and say that no Claims row rests on it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ --------- Co-authored-by: Claude <noreply@anthropic.com>



Replaces bactrian#17 (guarded branch, no update push possible). Owner ruling relayed by the sweep session.
What it does: brings
docs/status/PROOF-STATUS.adocand.machine_readable/coaptation/witness-map.nclto the template form, as #17 did, with two differences:{{PROJECT}}title token is filled (bactrian). docs: bring PROOF-STATUS.adoc and witness-map.ncl to the template form #17 left it unfilled, which failscheck-no-placeholders.sh/ the OpenSSF placeholder check.open, PWGungraded, no legs and no receipt, so the estate census sees open obligations. Row text is copied fromdocs/status/PROOF-NEEDS.adoc. No row claims a proof. (The file's own vocabulary puts engineering proofs in Idris2 atn/a; the owner choseungraded, so I usedungraded. Flagging the difference, not changing it.)The intro paragraph that said "a freshly minted repository has no claims" is reworded to match.
Checks run locally: no
{{token remains in the file;scripts/proof-claims-rows.sh(rsr-template-repo#385) reads 7 rows. Not run: CI on this branch. The push to this new branch name was one push, output has no "Bypassed" (the guard for the name listscode_coverage).Stacking: touches only those two files. Independent of #11 (no overlap), #13, #14, #15, #16, #19. After this merges, #17 should be closed.
https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Generated by Claude Code