Repository navigation
docs: fix three dead internal links #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to the issue forms, not their YAML definitions.
Both links open the YAML files. Contributors cannot fill out or submit the forms from those pages. Link to the corresponding new-issue forms instead, using GitHub's
templatequery parameter. (docs.github.com)Also applies to: 64-64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that a link to the issue form is better than a link to its YAML, and that is a "Minor" finding, so I am not pushing a change for it now (and I cannot push to this branch anyway: its rules include
code_coverage).Where the fix belongs: the template's own
CONTRIBUTING.adoclinks to.github/ISSUE_TEMPLATE/bug_report.ymlin the same way, and.github/CONTRIBUTING.mdhere is a leftover from an older template (the current template has only the rootCONTRIBUTING.adoc). Changing the link form once at source (https://github.com/<owner>/<repo>/issues/new?template=bug_report.yml) and re-syncing is cleaner than editing a retired file in each repo. This PR only repairs the dead path (.github/.github/...,.mdto.yml).Generated by Claude Code