Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c692533
fix(ci): regenerate actions.lock entries so CI starts again; guard drift
HoTT-stuff Nov 19, 2026
fe174af
style(ci): [[ ]] tests and named locals in check-actions-lock.sh (Son…
HoTT-stuff Nov 19, 2026
7fa3736
fix(ci): actions.lock guard sees flow-style steps and transitive depe…
HoTT-stuff Nov 19, 2026
71ac72e
fix(ci): actions.lock guard reads quoted uses keys, ignores run-scrip…
HoTT-stuff Nov 19, 2026
97f8623
style(ci): quote the joined lists in check-actions-lock.sh messages (…
HoTT-stuff Nov 19, 2026
b18fb9e
fix(ci): actions.lock guard allows space before the uses colon
HoTT-stuff Nov 19, 2026
57f6e23
fix(ci): actions.lock guard keeps refs whose branch contains /
HoTT-stuff Nov 19, 2026
1d2b480
fix(ci): actions.lock guard fails closed on unreadable uses values
HoTT-stuff Nov 19, 2026
7fc0186
fix(ci): tell reusable-workflow calls from steps by context, not path
HoTT-stuff Nov 19, 2026
e3eb086
style(ci): name positional parameters in tag()/refs() (Sonar S7679)
HoTT-stuff Nov 19, 2026
5ede7ec
fix(ci): keep indentless step sequences in step context; add guard se…
HoTT-stuff Nov 19, 2026
15fe522
fix(ci): hold OCaml at 4.14 on Ubuntu 26.04 runners
HoTT-stuff Nov 19, 2026
ebdf44c
docs(changelog): record the OCaml 4.14 CI toolchain fix
HoTT-stuff Nov 19, 2026
8c9a09f
fix(tea): import node and create in the Todo example the e2e test drives
HoTT-stuff Nov 19, 2026
cf511fb
fix(tea): also import patch for the Todo e2e keyed-diffing test
HoTT-stuff Nov 19, 2026
d98edf6
fix(ci): trim trailing whitespace in uses: values before checking
HoTT-stuff Nov 19, 2026
d3bd6eb
fix(ci): add the gate job the main ruleset requires as CI/gate
HoTT-stuff Nov 19, 2026
e5f4503
fix(ci): name the gate job CI/gate so it matches the required check
HoTT-stuff Nov 19, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions .claude/CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,20 @@ resolved; kept here with current status so agents don't re-investigate:
root files. A real new finding shows as a *delta in your changed files*;
otherwise ignore. (The Hypatia *check run* gates separately and is green.)

**CI is now standalone and green on `main` (since #604 / `c7922cf`).** Two
`startup_failure` classes bit `ci` / `governance` / `secret-scanner` for days
(and `main` itself) — worth knowing so they aren't reintroduced:

1. The repo's Actions "allowed actions" policy **rejects tag-pinned action
refs at run-creation** (a `startup_failure` with zero jobs). **Pin every
`uses:` to a full commit SHA** — `actions/foo@v4` will fail to start.
**CI is standalone (since #604 / `c7922cf`).** Two `startup_failure` classes
(a run that never starts, with zero jobs) have bitten `ci` / `governance` /
`secret-scanner` and `main` itself. `ci` did not run at all from
2026-10-11 until the actions.lock fix. Know them so they aren't reintroduced:

1. **`.github/workflows/actions.lock` is the pin authority** (GitHub's actions
lockfile, `gh actions-lock`). Workflows reference actions by tag
(`actions/checkout@v7.0.1`) and the lock maps each to a commit SHA. A
workflow whose `uses:` refs do not match the lock does not start. A
Dependabot bump that does not regenerate the lock causes exactly this
(#782 stopped `ci`). **After any change to a `uses:` ref, regenerate
`actions.lock`.** `tools/ci/check-actions-lock.sh` (governance check 4)
fails on a mismatch. (An older note here said tag pins themselves were
rejected; the run history shows tag pins that match the lock start fine.)
2. A reusable-workflow *caller* that declares `concurrency:` on the same key
the reusable also declares is rejected at run-creation (BP008 — see
`.github/workflows/spark-theatre-gate.yml`).
Expand Down
26 changes: 13 additions & 13 deletions .github/workflows/actions.lock
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ workflows:
- 'actions/configure-pages@v6.0.0'
- 'actions/deploy-pages@v5.0.1'
- 'actions/upload-pages-artifact@v5.0.0'
- 'haskell-actions/setup@v2.12.0'
- 'haskell-actions/setup@v2.12.1'
'.github/workflows/ci.yml':
- 'actions/checkout@v7.0.1'
- 'actions/setup-node@v7.0.0'
- 'actions/upload-artifact@v7.0.1'
- 'actions/setup-node@v7.1.0'
- 'actions/upload-artifact@v7.0.2'
'.github/workflows/codeql.yml':
- 'actions/checkout@v7.0.1'
- 'github/codeql-action@v4.39.3'
Expand All @@ -40,7 +40,7 @@ workflows:
- 'actions/upload-pages-artifact@v5.0.0'
'.github/workflows/panic-attack.yml':
- 'actions/checkout@v7.0.1'
- 'actions/upload-artifact@v7.0.1'
- 'actions/upload-artifact@v7.0.2'
- 'dtolnay/rust-toolchain@master'
'.github/workflows/publish-jsr.yml':
- 'actions/checkout@v7.0.1'
Expand Down Expand Up @@ -92,19 +92,19 @@ dependencies:
commit: 'sha1-368f82528645a54fb793d4d04e342629a3f51346'
owner_id: 44036562
repo_id: 438112499
'actions/setup-node@v7.0.0':
ref: 'v7.0.0'
commit: 'sha1-820762786026740c76f36085b0efc47a31fe5020'
'actions/setup-node@v7.1.0':
ref: 'v7.1.0'
commit: 'sha1-949feb2413d6458794dcd2491c4babbbce0c15c1'
owner_id: 44036562
repo_id: 189476904
'actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f':
ref: 'v7.0.0'
commit: 'sha1-bbbca2ddaa5d8feaa63e36b76fdaad77386f024f'
owner_id: 44036562
repo_id: 192625955
'actions/upload-artifact@v7.0.1':
ref: 'v7.0.1'
commit: 'sha1-043fb46d1a93c77aae656e7c1c64a875d1fc6a0a'
'actions/upload-artifact@v7.0.2':
ref: 'v7.0.2'
commit: 'sha1-cf430e030ddbb5b0abf93d22962f4752f3646cd9'
owner_id: 44036562
repo_id: 192625955
'actions/upload-pages-artifact@v5.0.0':
Expand All @@ -129,9 +129,9 @@ dependencies:
commit: 'sha1-33d7b85da1a04171e211befe2c739303b9a4c066'
owner_id: 9919
repo_id: 259445878
'haskell-actions/setup@v2.12.0':
ref: 'v2.12.0'
commit: 'sha1-6037f33647c3f17758a2356c80fc4a53d7e0685d'
'haskell-actions/setup@v2.12.1':
ref: 'v2.12.1'
commit: 'sha1-0f8e8c99d88aeb3fbfd523f1ef2c6f762d10d64d'
owner_id: 75048950
repo_id: 623796603
'hyperpolymath/smtp-notify-action@v0.5.1':
Expand Down
82 changes: 44 additions & 38 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@
#
# Standalone CI: no dependency on third-party actions or external-repo
# reusable workflows. The OCaml toolchain is self-hosted via apt + opam
# (replacing ocaml/setup-ocaml), and only first-party `actions/*` are used
# (checkout / setup-node / upload-artifact), SHA-pinned. dune-project requires
# OCaml >= 4.14, satisfied by the runner's apt OCaml (ocaml-system), with a
# base-compiler fallback.
# (replacing ocaml/setup-ocaml) in tools/ci/setup-ocaml.sh, and only
# first-party `actions/*` are used (checkout / setup-node / upload-artifact).
# OCaml is held at 4.14: dune-project needs >= 4.14 and the with-test
# dependency bisect_ppx needs < 5.0, so the runner's apt OCaml is used only
# when it is 4.14.x (Ubuntu 26.04 ships 5.4) and a pinned
# ocaml-base-compiler.4.14.2 is built otherwise.
#
# NOTE on pins: first-party `actions/*` are SHA-pinned (repo SHA-pinning
# policy + Hypatia workflow_audit + the "allowed actions" policy that rejects
# tag refs at run-creation). `actions/checkout` is v7.0.0 (`9c091bb…`, bumped
# by Dependabot in #605); `setup-node` / `upload-artifact` remain v4.
# NOTE on pins: `.github/workflows/actions.lock` is the pin authority. Steps
# name actions by tag and the lock maps each to a commit SHA; a workflow
# whose refs do not match the lock never starts (startup_failure, zero
# jobs). Regenerate the lock after any `uses:` change; governance check 4
# (tools/ci/check-actions-lock.sh) fails on drift.
name: CI
on:
push:
Expand Down Expand Up @@ -44,15 +47,8 @@ jobs:
# clone makes property 4 fail closed ("stamp not present").
fetch-depth: 0
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
# Prefer the runner's system OCaml (>= 4.14 satisfies dune-project)
# for an instant switch; fall back to a pinned base compiler.
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Set up Node.js
uses: actions/setup-node@v7.1.0
with:
Expand Down Expand Up @@ -187,13 +183,8 @@ jobs:
- name: Checkout code
uses: actions/checkout@v7.0.1
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Install dependencies
# Match the build job: `dune build` compiles everything including
# test/ (which depends on alcotest, with-test) and the @doc target
Expand All @@ -216,13 +207,8 @@ jobs:
- name: Checkout code
uses: actions/checkout@v7.0.1
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Install dependencies
run: opam install . --deps-only --with-test --with-doc --yes
- name: Build bench targets
Expand Down Expand Up @@ -266,13 +252,8 @@ jobs:
- name: Checkout code
uses: actions/checkout@v7.0.1
- name: Set up OCaml toolchain (self-hosted; replaces ocaml/setup-ocaml)
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends opam ocaml
opam init --bare --disable-sandboxing --yes
opam switch create . ocaml-system --no-install --yes \
|| opam switch create . ocaml-base-compiler.4.14.2 --no-install --yes
opam exec -- ocaml -version
# OCaml 4.14 (bisect_ppx needs < 5.0): runner OCaml when 4.14.x, else pinned 4.14.2.
run: ./tools/ci/setup-ocaml.sh
- name: Install dependencies
run: opam install . --deps-only --with-test --with-doc --yes
- name: Set up Node.js
Expand Down Expand Up @@ -434,3 +415,28 @@ jobs:
( cd tools/vendor/tree-sitter-rescript \
&& tree-sitter parse --quiet "${fixture_abs}" > /dev/null )
echo "smoke-parsed: ${fixtures[0]}"

# Single required check. The `Branch-Floor` ruleset on main requires the
# status `CI/gate` by check-run name, which is this job's `name:` (not the
# job id), so the name must stay exactly `CI/gate`. It passes only when every
# job above succeeded (a skipped job counts as passing, a failed or cancelled
# one does not). Add any new CI job to `needs:` here, or the ruleset will not
# wait for it.
gate:
name: CI/gate
if: always()
needs: [build, lint, bench-visibility, coverage-visibility, vscode-smoke, migration-assistant]
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- name: All CI jobs passed
env:
RESULTS: ${{ join(needs.*.result, ' ') }}
run: |
echo "CI job results: $RESULTS"
for r in $RESULTS; do
case "$r" in
success|skipped) ;;
*) echo "::error::a required CI job ended as '$r'"; exit 1 ;;
esac
done
4 changes: 2 additions & 2 deletions .github/workflows/publish-jsr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ jobs:
timeout-minutes: 10
steps:
- uses: actions/checkout@v7.0.1
# v2.0.5 — immutable commit pin (tag: v2.0.5).
- uses: denoland/setup-deno@22d081ff2d3a40755e97629de92e3bcbfa7cf2ed
# v2.0.5; its commit is pinned in actions.lock (the pin authority).
- uses: denoland/setup-deno@v2.0.5
with:
deno-version: v2.x
- name: Resolve package directory
Expand Down
14 changes: 14 additions & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,20 @@ JSR publish (#303)

==== CI

* fix(ci): `CI` never started from 2026-10-11 (startup_failure, zero jobs)
because Dependabot #782 bumped actions in ci.yml without regenerating
`.github/workflows/actions.lock`. The lock now matches every workflow
(ci.yml, panic-attack.yml, casket-pages.yml, publish-jsr.yml), and
governance check 4 (`tools/ci/check-actions-lock.sh`) fails on any drift
* fix(ci): the OCaml jobs (build, lint, bench, coverage) failed on Ubuntu
26.04 runners, which ship OCaml 5.4, because the with-test dependency
`bisect_ppx` needs OCaml < 5.0. `tools/ci/setup-ocaml.sh` uses the runner
OCaml only when it is 4.14.x and otherwise builds a pinned
`ocaml-base-compiler.4.14.2`
* fix(ci): no PR could merge into main after the `Branch-Floor` ruleset
started requiring the status `CI/gate` (16 Nov), because no CI job was
named `gate`. A `gate` job now needs every CI job and passes only when
all of them succeed
* ci(migration-assistant): fix smoke-parse for tree-sitter-cli 0.25
(#342)
* ci: bump github/codeql-action from 4.32.6 to 4.36.0 (#323)
Expand Down
2 changes: 1 addition & 1 deletion affinescript-tea/examples/todo/Todo.affine
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
module Todo;

use prelude::*;
use Tea::{Html, Attr, Cmd, Sub, Event, run, text, div, span, button, input, ul, li, h1, p,
use Tea::{Html, Attr, Cmd, Sub, Event, run, text, node, create, patch, div, span, button, input, ul, li, h1, p,
class, id, value, key, attr, lazy, on_click, on_input, on_enter, on_check, none, send,
every, no_sub, tea_map, tea_filter, run_cmd, tea_defer};

Expand Down
Loading
Loading