Repository navigation
Fix C# rejection tests with the stricter WIT parser - #2049
Merged
jsturtevant merged 1 commit intoNov 11, 2026
Merged
Conversation
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
added
A-testing
jsturtevant
requested review from
andreiltd,
dblnz,
devigned,
jprendes,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
November 11, 2026 19:03
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the component-text fixture and rejection-test updates.
No open issues 🎉
What changed in this PR
The C# rejection tests use component-text fixtures so unsupported types reach the generator’s validation checks despite stricter WIT parsing.
Changes:
- Add a shared helper for generating component-text type fixtures.
- Use the helper to test rejection of empty types and flags with more than 32 members.
| File | Description |
|---|---|
src/hyperlight_component_csharp/src/tests.rs |
Adds the fixture helper and updates the generator rejection tests. |
Review effort: Balanced
jsturtevant
enabled auto-merge (squash)
November 11, 2026 19:19
yoshuawuyts
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1964 upgraded wit-parser from 0.259.0 to 0.262.0. That causes wit to error earlier with these invalid WIT types which caused the test to fail before it go to the expected checks. This updates it to use a module to bypass the parser and get to the expected error
record e {}empty recordflags e {}empty flagstuple<>empty tuplecannot have more than 32 flags