Repository navigation
HIP 0007: Major Versions - #1994
yoshuawuyts wants to merge 1 commit into
Conversation
Signed-off-by: Yosh <github@yosh.is>
yoshuawuyts
added
the
A-infra
jprendes
left a comment
jprendes
left a comment
There was a problem hiding this comment.
Sounds sensible to me.
I like that we are not commiting to ABI stability.
There are some crates in hyperlight-dev/hyperlight for wich we might not want to provide the same guarantees, like hyperlight-component-util and hyperlight-common. We publish those crates, but they are not really intended for external usage.
Also, in some cases we have some #[doc(hidden)] APIs (e.g., for macros), I think we want to exclude those too (although hyrum's law probably says someone will depend on them anyway XD)
|
|
||
| So instead we only promise API stability. If you upgrade from 1.0 to 1.1 you'll | ||
| need to recompile your guests and regenerate your snapshots, but you shouldn't | ||
| need to change any code. Guests targeting WebAssembly through `hyperlight-wasm` |
There was a problem hiding this comment.
This is a little misleading: by 1.0 we will probably have hyperlight-wasm-aot produce snapshots which will need to be recompiled, so while the .wasm that your precompilation service uses will not change, the snapshot that you actually load into hyperlight-wasm to use it will need to be recompiled.
There was a problem hiding this comment.
I assumed ahead of time compilation in hyperlight-wasm was optional though?
There was a problem hiding this comment.
no it's not, currently :-(
There was a problem hiding this comment.
we could provide safe precompilaton using hl-uk :-)
jsturtevant
left a comment
jsturtevant
left a comment
There was a problem hiding this comment.
LGTM, One thought I had is how will we progress on the new features that are going to need a major version bump? Will that mean we have a branch for 1.x that we back port security fixes to only? and x.0 would be all new features?
This introduces a HIP for Hyperlight 1.0 and future major versions.