Repository navigation
Make benchmark report indicators configurable - #1910
Merged
jprendes merged 1 commit intoOct 8, 2026
Merged
Conversation
Update criterion-markdown to 0.3.0 and read grouped threshold and emoji settings from bench_report.toml. Preserve command-line threshold precedence and renderer defaults. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jsturtevant,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
October 8, 2026 21:02
jprendes
added
C-deps
ludfjig
approved these changes
Oct 8, 2026
jprendes
enabled auto-merge (squash)
October 8, 2026 21:06
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The breaking configuration migration needs a changelog entry.
1 open finding
What changed in this PR
Makes benchmark report thresholds and indicators configurable through the report configuration.
Changes:
- Upgrades
criterion-markdownto 0.3.0. - Groups ratios under
[thresholds]. - Adds configurable classification icons under
[thresholds.emojis].
| File | Description |
|---|---|
src/hyperlight_ci/src/config.rs |
Adds nested threshold and indicator configuration. |
src/hyperlight_ci/src/bench_report.rs |
Applies configured thresholds and icons. |
src/hyperlight_ci/Cargo.toml |
Upgrades criterion-markdown. |
Cargo.lock |
Locks version 0.3.0. |
bench_report.toml |
Configures report ratios and icons. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
criterion-markdownto 0.3.0.[thresholds]and indicators under[thresholds.emojis].Testing
just fmt-applycargo test --locked -p hyperlight-cijust clippyjust testsubrecipesThe full unit stage passed 483 tests and reached the known host dependent
kvm_does_not_expose_cet_to_guestfailure.