Repository navigation
fix: adjust scratch size for benchmarks - #1847
Merged
Merged
Conversation
This gives a headroom for benchmarks with large scratch after introducing virtual queue. Signed-off-by: Tomasz Andrzejak <andreiltd@gmail.com>
andreiltd
requested review from
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
September 22, 2026 15:39
simongdavies
approved these changes
Sep 22, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Adjusts benchmark scratch sizing to provide headroom for page tables and virtual-queue transport.
Changes:
- Increases medium sandbox scratch from
0x50000to0x60000. - Clarifies scratch sizing documentation.
| File | Summary |
|---|---|
src/hyperlight_host/benches/benchmarks.rs |
Updates benchmark scratch sizing and documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ludfjig
approved these changes
Sep 22, 2026
andreiltd
enabled auto-merge (squash)
September 22, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives a headroom for benchmarks with large scratch after introducing virtual queue.
Fixes CI error:
HyperlightVmError(Initialize(Run(HandleIo(Outb(GuestAborted { code: 13, message: "Out of physical memory" })))))