Repository navigation
Map exact page-rounded lengths in simpleguest - #1844
Merged
Merged
Conversation
`map_region` requires a page-aligned length. Adding 4096 maps an extra page when the buffer is already aligned and leaves other lengths unaligned. Round up to the smallest page multiple that covers the buffer. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
September 21, 2026 18:42
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Only a minor regression-coverage nit remains.
Review effort: Lite
Findings: None
What changed in this PR
Updates simpleguest to map buffers using the smallest page-aligned length.
Changes:
- Imports
PAGE_SIZE. - Replaces fixed extra-page lengths with
next_multiple_of(PAGE_SIZE).
| File | Description |
|---|---|
src/tests/rust_guests/simpleguest/src/main.rs |
Applies exact page-rounded lengths to read, write, and execute mappings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
simongdavies
approved these changes
Sep 30, 2026
andreiltd
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map_regionrequires a page-aligned length. Adding 4096 maps an extra page when the buffer is already aligned and leaves other lengths unaligned. Round up to the smallest page multiple that covers the buffer.Note this only affects simpleguest which is a test-only guest