Skip to content

WHP: releasing file mappings after deleting partition in WhpVm::Drop #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ludfjig wants to merge 1 commit into from
Closed

WHP: releasing file mappings after deleting partition in WhpVm::Drop #1756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/hyperlight_host/src/hypervisor/virtual_machine/whp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,11 +1360,6 @@ impl WhpVm {

impl Drop for WhpVm {
fn drop(&mut self) {
// Clean up any remaining file mappings that weren't explicitly unmapped.
for (handle, view) in self.file_mappings.drain(..) {
release_file_mapping(view, handle);
}

// Stop the software timer thread before tearing down the partition.
#[cfg(feature = "hw-interrupts")]
if let Some(mut t) = self.timer.take() {
Expand All @@ -1379,6 +1374,11 @@ impl Drop for WhpVm {
if let Err(e) = unsafe { WHvDeletePartition(self.partition) } {
tracing::error!("Failed to delete partition: {}", e);
}

// Clean up any remaining file mappings that weren't explicitly unmapped.
for (handle, view) in self.file_mappings.drain(..) {
release_file_mapping(view, handle);
Comment on lines +1379 to +1380
}
}
}

Expand Down
Loading