Repository navigation
Use short-form license pragmas - #1750
Merged
Merged
Conversation
yoshuawuyts
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
August 20, 2026 13:28
yoshuawuyts
added
the
C-refactor
Signed-off-by: Yosh <github@yosh.is>
Signed-off-by: Yosh <github@yosh.is>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Hyperlight source headers from the long-form Apache 2.0 boilerplate to compact SPDX license identifiers plus a copyright line, and updates the repo’s Rust header checker script to validate the new format.
Changes:
- Replace long-form Apache 2.0 license blocks with
// SPDX-License-Identifier: Apache-2.0+// Copyright …across Rust/C sources. - Update
dev/check-license-headers.shto validate the new two-line header forsrc/**/*.rs. - Minor formatting cleanup in
picolibc.hmacro alignment and a trailing-space removal in surrogate docs.
Show a summary per file
| File | Description |
|---|---|
| dev/check-license-headers.sh | Update Rust header checker to validate SPDX + copyright two-line header. |
| fuzz/fuzz_targets/guest_call.rs | Switch file header to SPDX short form. |
| fuzz/fuzz_targets/guest_estimate_trace_event.rs | Switch file header to SPDX short form. |
| fuzz/fuzz_targets/guest_trace.rs | Switch file header to SPDX short form. |
| fuzz/fuzz_targets/host_call.rs | Switch file header to SPDX short form. |
| fuzz/fuzz_targets/virtq_packed_ring.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/benches/buffer_pool.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/benches/common/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/benches/virtq_api.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/arch/aarch64/exn.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/arch/aarch64/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/arch/aarch64/vmem.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/arch/amd64/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/arch/amd64/vmem.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/component.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/function_call.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/function_types.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/guest_error.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/guest_log_data.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/guest_log_level.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/guest_trace_data.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/host_function_definition.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/host_function_details.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/flatbuffer_wrappers/util.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/func/error.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/func/functions.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/func/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/func/param_type.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/func/ret_type.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/func/utils.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/log_level.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/mem.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/outb.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/resource.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/version_note.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/access.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/buffer.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/concurrency.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/consumer.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/desc.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/event.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/msg.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/pool.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/producer.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/virtq/ring.rs | Switch file header to SPDX short form. |
| src/hyperlight_common/src/vmem.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_macro/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/component.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/elaborate.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/emit.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/etypes.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/guest.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/hl.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/host.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/resource.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/rtypes.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/structure.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/substitute.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/subtype.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/tv.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/util.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/src/wf.rs | Switch file header to SPDX short form. |
| src/hyperlight_component_util/tests/wasmtime_guest_codegen.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/arch/aarch64/exit.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/arch/aarch64/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/arch/aarch64/prim_alloc.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/arch/amd64/exit.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/arch/amd64/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/arch/amd64/prim_alloc.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/error.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/exit.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/guest_handle/handle.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/guest_handle/host_comm.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/guest_handle/io.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/prim_alloc.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest/src/types.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/aarch64/exception/entry.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/aarch64/exception/handle.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/aarch64/exception/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/aarch64/exception/types.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/aarch64/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/aarch64/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/aarch64/paging.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/context.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/dispatch.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/exception/entry.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/exception/handle.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/exception/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/init.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/machine.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/arch/amd64/paging.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/exception.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/error.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/guest_function/call.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/guest_function/definition.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/guest_function/register.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/guest_logger.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/host_comm.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/init.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/libc_stubs.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/memory.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_bin/src/paging.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/build.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/dispatch.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/error.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/flatbuffer.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/logging.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/types.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/types/function_call.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/types/parameter.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_capi/src/types/vec.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_macro/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_tracing/src/invariant_tsc.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_tracing/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_tracing/src/state.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_tracing/src/subscriber.rs | Switch file header to SPDX short form. |
| src/hyperlight_guest_tracing/src/visitor.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/benches/benchmarks.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/build.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/crashdump/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/func_ctx/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/guest-debugging/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/hello-world/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/logging/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/map-file-cow-test/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/metrics/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/tracing/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/tracing-chrome/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/examples/tracing-otlp/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/error.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/func/host_functions.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/func/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hyperlight_surrogate/build.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hyperlight_surrogate/src/main.rs | Switch file header to SPDX short form and remove trailing whitespace in docs. |
| src/hyperlight_host/src/hypervisor/crashdump.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/gdb/arch.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/gdb/event_loop.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/gdb/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/gdb/x86_64_target.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/aarch64/common_fpu.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/aarch64/common_regs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/aarch64/kvm_reg.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/aarch64/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/aarch64/special_regs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/x86_64/debug_regs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/x86_64/fpu.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/x86_64/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/x86_64/msrs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/x86_64/special_regs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/regs/x86_64/standard_regs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/surrogate_process.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/surrogate_process_manager.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/hvf/bindings.h | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/hvf/fp_abi.c | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/hvf/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/kvm/aarch64.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/kvm/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/kvm/x86_64.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/mshv/aarch64.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/mshv/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/mshv/x86_64.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/whp.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/x86_64/hw_interrupts.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/virtual_machine/x86_64/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/hypervisor/wrappers.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/elf.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/exe.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/layout.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/memory_region.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/mgr.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/ptr.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/ptr_addr_space.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/ptr_offset.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/shared_mem.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/mem/shared_mem_tests.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/metrics/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/builder.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/callable.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/config.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/file_mapping.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/host_funcs.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/initialized_multi_use.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/outb.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/file/config.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/file/digest.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/file/fsutil.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/file/media_types.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/file/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/file/reference.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/file_tests.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/snapshot/tripwires.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/trace/context.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/trace/mem_profile.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/trace/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/uninitialized.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/sandbox/uninitialized_evolve.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/signal_handlers/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/testing/log_values.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/src/testing/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/common/mod.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/integration_test.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/sandbox_host_tests.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/snapshot_goldens/checks.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/snapshot_goldens/fixtures.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/snapshot_goldens/goldens_version.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/snapshot_goldens/main.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/snapshot_goldens/oci.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/snapshot_goldens/platform.rs | Switch file header to SPDX short form. |
| src/hyperlight_host/tests/wit_test.rs | Switch file header to SPDX short form. |
| src/hyperlight_libc/build.rs | Switch file header to SPDX short form. |
| src/hyperlight_libc/build_files.rs | Switch file header to SPDX short form. |
| src/hyperlight_libc/include/picolibc.h | Switch file header to SPDX short form and adjust macro alignment. |
| src/hyperlight_libc/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_libc/src/stubs.rs | Switch file header to SPDX short form. |
| src/hyperlight_testing/src/lib.rs | Switch file header to SPDX short form. |
| src/hyperlight_testing/src/logger.rs | Switch file header to SPDX short form. |
| src/hyperlight_testing/src/simplelogger.rs | Switch file header to SPDX short form. |
| src/hyperlight_testing/src/tracing_subscriber.rs | Switch file header to SPDX short form. |
| src/tests/rust_guests/dummyguest/src/main.rs | Switch file header to SPDX short form. |
| src/tests/rust_guests/simpleguest/src/main.rs | Switch file header to SPDX short form. |
| src/tests/rust_guests/witguest/src/bindings.rs | Switch file header to SPDX short form. |
| src/tests/rust_guests/witguest/src/main.rs | Switch file header to SPDX short form. |
| src/trace_dump/main.rs | Switch file header to SPDX short form. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 245/245 changed files
- Comments generated: 0
- Review effort level: Lite
yoshuawuyts
force-pushed
the
license-pragma
branch
from
August 20, 2026 13:41
43356e0 to
d8217b6
Compare
jprendes
approved these changes
Aug 20, 2026
jprendes
left a comment
jprendes
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
As we are a CNCF project, I checked the CNCF guidelines
https://github.com/cncf/foundation/blob/main/license-notices.md#original-content-for-cncf-projects
These notices can be included using either the standard language from the license steward, and/or using an SPDX short-form identifier.
So I think we are good with this change
Contributor
|
btw, I am not a lawyer :-D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I've been reading the Hyperlight source, I noticed we're using long-form license pragmas in each file. I assume we have a reason for that, so I don't want to suggest we remove these outright. But what I figured we could do is move to the short-form pragma format that is a bit more compact.
The format I'm introducing here is for example also used by the Linux kernel (example). As I understand it, tools like FOSSA also know how to ingest this, and can ensure appropriate attribution. As far as I can tell there are no downsides to adopting this shorter format, other than the cost of making the change itself (e.g. this PR). But admittedly this is the first time I'm involved in a migration of this kind, so it might be that I've missed something.
Anyway, I figured this might be a relatively easy way to delete some code with no real downsides. As well as to familiarize myself with the Hyperlight contribution process. Keen to hear what folks think; thanks!