Skip to content

Restore does not rewind the guest TSC on WHP #2021

Closed

Description

@ludfjig

After restore, the guest TSC should equal its value in the snapshot. On WHP hosts with TscAdjustSupport, it also includes the time since the snapshot. KVM (after #2015) and MSHV restore it exactly.

Writing TSC shifts TSC_ADJUST by the same amount, and writing TSC_ADJUST shifts TSC back, so restoring both undoes the rewind. Clearing TscAdjustSupport, as the MSHV driver does, fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-needs-triageThe issue has not yet been reviewed.

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions