Skip to content

Remove possibility of silent errors in vmem::TableOps #1128

Open

Description

@ludfjig

#1093 introduced

struct GuestPageTableBuffer {
    buffer: std::cell::RefCell<Vec<u8>>,
}.

To avoid UB in the into_bytes implementation, this buffer made Vec<u8> instead of Vec<u64>. However this forced read_entry to possibly error silently using unwrap_or(0).

We should remove the possibility of error occurring silently, either by panicking, or by rewriting into_bytes to avoid UB using Vec<u64>

Activity

  1. added
    S-confirmedBug is verified or proposal seems reasonable
    and removed
    S-needs-triageThe issue has not yet been reviewed.
    on Jan 21, 2026
  2. added this to the Backlog milestone on Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

S-confirmedBug is verified or proposal seems reasonable

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions