Repository navigation
Keep the Rust build cache across tool bumps - #48
Merged
Merged
Conversation
The build cache key included a hash of tool-versions.sh, and rust-cache only falls back across Cargo.lock changes. Bumping any tool discarded the whole cache, so the PR that bumped hyperlight-wasm-aot rebuilt every tool and crate from scratch. Tool binaries now use a separate cache keyed by tool-versions.sh, with a fallback to older tool sets. setup-tools.sh reinstalls only tools whose versions differ. The build cache key keeps only the cargo-hyperlight version, since that tool builds the dummy guest into a cached target directory. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build cache key included a hash of
tool-versions.sh, and rust-cache only falls back acrossCargo.lockchanges. Bumping any tool discarded the whole cache, so #46 rebuilt every tool and crate from scratch.tool-versions.sh, with a fallback to older tool sets.setup-tools.shreinstalls only tools whose versions differ.cargo-hyperlightversion, since that tool builds the dummy guest into a cached target directory.Every cache misses once after merge because the keys change.