Repository navigation
Fail Pages deploys that do not go live - #47
Merged
Merged
Conversation
actions/deploy-pages uses GITHUB_SHA as the Pages build version. Pages runs on main, so every deploy between merges reuses one version and the status check reports success right away. One deploy reported success but Pages kept serving the previous site, so a preview stayed stale with a green job. Assemble now adds marker files at a path unique to the run attempt. After deploying, the job polls a different marker each time until one is served, and fails after 5 minutes. Fresh paths avoid 404s cached by the CDN, which ignores query strings. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/deploy-pagesusesGITHUB_SHAas the Pages build version. Pages runs onmain, so every deploy between merges reuses one version, and the status check reports success right away. On #46, a deploy reported success but Pages kept serving the previous site, so the preview stayed stale with a green job.The check only runs from
main, so it gets exercised after merge.