Use protobuf getters to access member variables - #5558
Merged
Conversation
Use only protobuf getter methods to access member variables on protobuf messages. This protects against panics if accessing members of a nil message, which the getter handles gracefully by returning nil or a default value for a nil receiver. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Contributor
|
have you used |
Member
Author
|
Effectively yes. I used golangci-lint configured with just the protogetter linter and I considered adding a simple golangci-lint lint check as part of this change but your golangci-lint change is already in flight so thought it better to wait for that to go in. |
bestbeforetoday
marked this pull request as ready for review
September 10, 2026 13:10
pfi79
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use only protobuf getter methods to access member variables on protobuf messages. This protects against panics if accessing members of a nil message, which the getter handles gracefully by returning nil or a default value for a nil receiver.