fix: Release flow control capacity when RecvStream is dropped - #930
Merged
seanmonstar merged 1 commit intoAug 10, 2026
Conversation
ArniDagur
force-pushed
the
fix/recv-stream-drop-releases-connection-capacity
branch
3 times, most recently
from
August 8, 2026 21:29
27b0876 to
686fe1b
Compare
Dropping `RecvStream` discards buffered DATA, but doesn't release connection-level flow control capacity until all stream references are dropped. That can starve other streams of flow control capacity. With this change, we release capacity immediately on `RecvStream` drop.
ArniDagur
force-pushed
the
fix/recv-stream-drop-releases-connection-capacity
branch
from
August 9, 2026 02:25
686fe1b to
7b6f5d7
Compare
seanmonstar
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping
RecvStreamdiscards buffered DATA, but doesn't release connection-level flow control capacity until all stream references are dropped.That can starve other streams of flow control capacity. With this change, we release capacity immediately on
RecvStreamdrop.