Skip to content

Fix release CLI workflow: build common-utils before compilation - #2086

Merged
kodiakhq[bot] merged 4 commits into
mainfrom
warren/fix-release-cli-workflow
Apr 10, 2026
Merged

Fix release CLI workflow: build common-utils before compilation#2086
kodiakhq[bot] merged 4 commits into
mainfrom
warren/fix-release-cli-workflow

Conversation

@wrn14897

@wrn14897 wrn14897 commented Apr 10, 2026

Copy link
Copy Markdown
Member

The "Release CLI Binaries" job fails because bun build --compile can't resolve @hyperdx/common-utils/dist/* imports. In CI it's a fresh checkout — yarn install puts source code in place but common-utils needs to be compiled (tsup) to produce its dist/ output.

Adds a make ci-build step between yarn install and the CLI compile step.

Fixes https://github.com/hyperdxio/hyperdx/actions/runs/24220292098/job/70710194631

@changeset-bot

changeset-bot Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f5eadca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Apr 10, 2026 2:59pm

Request Review

@github-actions github-actions Bot added the review/tier-4 Critical — deep review + domain expert sign-off label Apr 10, 2026
@github-actions

github-actions Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔴 Tier 4 — Critical

Touches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD.

Why this tier:

  • Critical-path files (1):
    • .github/workflows/release.yml

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

Stats
  • Files changed: 1
  • Lines changed: 2
  • Branch: warren/fix-release-cli-workflow
  • Author: wrn14897

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Review

✅ No critical issues found.

The fix is correct and minimal — make ci-build runs npx nx run-many -t ci:build, which compiles common-utils (and any other packages with a ci:build target) to produce the dist/ output needed by bun build --compile. Placement is correct: after yarn install and before the CLI compile steps. Already approved by a team member and all E2E tests pass.

@wrn14897
wrn14897 force-pushed the warren/fix-release-cli-workflow branch from 01eb1f3 to f2f2ac9 Compare April 10, 2026 00:47
@github-actions

github-actions Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 131 passed • 3 skipped • 1061s

Status Count
✅ Passed 131
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@wrn14897
wrn14897 force-pushed the warren/fix-release-cli-workflow branch from 759571a to b6f4a4e Compare April 10, 2026 01:10
@kodiakhq
kodiakhq Bot merged commit f8f7634 into main Apr 10, 2026
17 checks passed
@kodiakhq
kodiakhq Bot deleted the warren/fix-release-cli-workflow branch April 10, 2026 15:04
knudtty pushed a commit that referenced this pull request Apr 16, 2026
@wrn14897
Fix release CLI workflow: build common-utils before compilation (#2086)
2d02a79 
The "Release CLI Binaries" job fails because `bun build --compile` can't resolve `@hyperdx/common-utils/dist/*` imports. In CI it's a fresh checkout — `yarn install` puts source code in place but `common-utils` needs to be compiled (tsup) to produce its `dist/` output.

Adds a `make ci-build` step between `yarn install` and the CLI compile step.

Fixes https://github.com/hyperdxio/hyperdx/actions/runs/24220292098/job/70710194631
Copilot AI pushed a commit that referenced this pull request Apr 20, 2026
@wrn14897 @peter-leonov-ch
Fix release CLI workflow: build common-utils before compilation (#2086)
c6a58a7 
The "Release CLI Binaries" job fails because `bun build --compile` can't resolve `@hyperdx/common-utils/dist/*` imports. In CI it's a fresh checkout — `yarn install` puts source code in place but `common-utils` needs to be compiled (tsup) to produce its `dist/` output.

Adds a `make ci-build` step between `yarn install` and the CLI compile step.

Fixes https://github.com/hyperdxio/hyperdx/actions/runs/24220292098/job/70710194631
Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — f5eadca9 Deployed Apr 10, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandon-pereira brandon-pereira brandon-pereira approved these changes

Assignees

No one assigned

Labels

automerge review/tier-4 Critical — deep review + domain expert sign-off

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wrn14897 @brandon-pereira