Repository navigation
feat(agent): durable HITL approvals; fix duplicate gated calls and Gemini call IDs - #151
Merged
Merged
Conversation
Identical RequiresConfirmation calls in one wave were each prompted and each executed; duplicates now reuse the first call's result.
Gemini returns no call IDs, so parallel calls of one tool shared the name as ID and one result overwrote the other. FunctionResponse names now resolve from the issuing call.
Deferred calls are saved in session history without a result and the run ends with ErrApprovalPending; Resume answers them from any process, PendingApprovals lists what is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeferApprovals+Resume+PendingApprovals: approvals are saved in session history and answered later from any process, so they survive restarts.ConfirmFuncunchanged.