Repository navigation
72: Avoid replacing core/query namespace on query loop wrapper - #75
Merged
Merged
Conversation
For #72. With enhanced pagination on, core declares `data-wp-interactive="core/query` on the query loop wrapper and the pagination links look for that namespace when reading their context. We were replacing this with `query-filter`, which orphaned those links by removing the context they looked for. This caused a TypeError to be output on every page load and after every pagination interaction. Our own blocks don't actually need the `query-filter` namespace itself, each block sets it own, so now we only set the namespace when core has not.
Playwright — PHP 8.3 / WP latest
Details
|
goldenapples
approved these changes
Oct 29, 2026
goldenapples
left a comment
goldenapples
left a comment
Contributor
There was a problem hiding this comment.
This fix seems correct, and matches the workarounds that I see in other projects that have run into this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #72. With enhanced pagination on, core declares
data-wp-interactive="core/queryon the query loop wrapper and the pagination links look for that namespace when reading their context. We were replacing this withquery-filter, which orphaned those links by removing the context they looked for. This caused a TypeError to be output on every page load and after every pagination interaction.Our own blocks don't actually need the
query-filternamespace itself, each block sets it own, so now we only set the namespace when core has not.