Skip to content

QA: applied ruff rule PLW1514 - #48990

Open
tarekziade wants to merge 1 commit into
mainfrom
tarek-encoding
Open

tarekziade wants to merge 1 commit into
mainfrom
tarek-encoding

Conversation

@tarekziade

@tarekziade tarekziade commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

CPU CI GPU run-slow

What does this PR do?

Per #48948 (comment) added PLW1514

This means enabling preview mode and fixing a few extra spots that were triggered by the preview mode (even with explicit-preview-rules)

most fixes here were produced by Ruff's autofix

@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: audio_spectrogram_transformer, auto, bark, beit, bertweet, biogpt, bit, blt, canary, chameleon, conditional_detr, convnext, convnextv2, cvt, d_fine, dab_detr

@tarekziade

Copy link
Copy Markdown
Collaborator Author

run-slow: audio_spectrogram_transformer, auto, bark, beit, bertweet, biogpt, bit, blt, canary, chameleon, conditional_detr, convnext, convnextv2, cvt, d_fine, dab_detr

@github-actions

Copy link
Copy Markdown
Contributor

AMD CI

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs on AMD:

models: ["models/audio_spectrogram_transformer", "models/auto", "models/bark", "models/beit", "models/bertweet", "models/biogpt", "models/bit", "models/blt", "models/canary", "models/chameleon", "models/conditional_detr", "models/convnext", "models/convnextv2", "models/cvt", "models/d_fine", "models/dab_detr"]

@github-actions

Copy link
Copy Markdown
Contributor

Nvidia CI

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs on Nvidia:

models: ["models/audio_spectrogram_transformer", "models/auto", "models/bark", "models/beit", "models/bertweet", "models/biogpt", "models/bit", "models/blt", "models/canary", "models/chameleon", "models/conditional_detr", "models/convnext", "models/convnextv2", "models/cvt", "models/d_fine", "models/dab_detr"]
quantizations: []

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1 Rocketknight1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM! I see this causing problems for Windows/non-Latin users, and the fix is pretty simple. It becomes redundant after Py3.15, but that's a few years away yet 😅

@github-actions

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 35619609826:1
Result: failure | Jobs: 16 | Tests: 191,003 | Failures: 1 | Duration: 17h 10m

@tarekziade

Copy link
Copy Markdown
Collaborator Author

the generate failure is unrelated. @ydshieh is that one of the failures you were looking at?

@github-actions

Copy link
Copy Markdown
Contributor

CI Results (Nvidia)

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN e7befb0b workflow commit (merge commit)
PR 4c74e244 branch commit (from PR)
main ae05b6b9 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@github-actions

Copy link
Copy Markdown
Contributor

CI Results (AMD)

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN e7befb0b workflow commit (merge commit)
PR 4c74e244 branch commit (from PR)
main ae05b6b9 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants