Fix ASR feature extractors do not actually convert batched multi-channel list inputs to mono - #48977
Closed
mayuriphad wants to merge 7 commits into
Closed
mayuriphad wants to merge 7 commits into
mayuriphad wants to merge 7 commits into
Conversation
…s/cohere_asr/feature_extraction_cohere_asr.py
…s/lasr/feature_extraction_lasr.py
…s/nemotron_asr_streaming/feature_extraction_nemotron_asr_streaming.py
…s/nemotron_asr_streaming/modular_nemotron_asr_streaming.py
…s/parakeet/feature_extraction_parakeet.py
…s/phi4_multimodal/feature_extraction_phi4_multimodal.py
…s/voxtral_realtime/feature_extraction_voxtral_realtime.py
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere_asr, lasr, nemotron_asr_streaming, parakeet, phi4_multimodal, voxtral_realtime |
Contributor
CI recapDashboard: View test results in Grafana |
Member
|
Hi @mayuriphad can you stop opening PRs with whatever code agent you're using? The diffs are often damaged and unreadable and that makes them impossible to review. Also the fixes themselves are quite low-quality. This is mostly just wasting reviewer time, so we may block you if it continues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48670. Assigns the channel mean back to the list instead of only overwriting the local loop variable.