Conversation
Alias modules for image processors forwarded every attribute lookup — including stdlib dunder probes such as __warningregistry__ — into importlib.import_module. unittest.assertWarns walks sys.modules and clears that attribute, which imported torchvision-backed processors and raised ModuleNotFoundError when torchvision was absent. Skip dunder names in the alias __getattr__ paths so probes raise AttributeError without importing the target. Adds a regression test for issue huggingface#48966.
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #48966.
I hit this while running unrelated unit tests after importing transformers:
unittest.TestCase.assertWarns/assertWarnsRegexstarted raisingModuleNotFoundError: No module named 'torchvision'even when the test never touched image processors.assertWarnswalks every module insys.modulesand probes__warningregistry__. Our legacy*_fastimage-processor alias modules implement__getattr__by forwarding intoimportlib.import_module(...). That probe therefore imported torchvision-backed processors (e.g. Aria) and failed in environments without torchvision.I taught both alias
__getattr__paths to raiseAttributeErrorfor dunder names without importing the target — the same idea as the existing explicitmodule.__file__ = Noneguard forinspect. I also added a regression test that exercisesassertWarnsRegexafter import and checks the Aria fast alias returnsNonefor__warningregistry__.Before / after
Testing
main, applied the patch, and confirmed the snippet above now yields the expectedAssertionError.tests/utils/test_import_utils.py::test_module_aliases_ignore_dunder_attribute_probeslocally — passed.