Skip to content

fix: resolve #48964 - Issue doing PEFT on Embedding Gemma w/ new classifier head - #48965

Closed
fathirramadhan-web wants to merge 1 commit into
huggingface:mainfrom
fathirramadhan-web:fix/issue-48964-issue-doing-peft-on-embedding-gemma-w-ne
Closed

fathirramadhan-web wants to merge 1 commit into
huggingface:mainfrom
fathirramadhan-web:fix/issue-48964-issue-doing-peft-on-embedding-gemma-w-ne

Conversation

@fathirramadhan-web

Copy link
Copy Markdown

Closes #48964

Overview

Addresses the problem reported in #48964 by resolving the underlying issue and ensuring test coverage passes.

Verification

  • Tested locally
  • Linters/tests pass

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution 🤗!

CI Security Gate — automatic approval blocked

This PR was not automatically approved for CI because the security gate failed.

Possible reasons:

  • The PR touches 50 or more files — only PRs with fewer than 50 changed files are automatically approved
  • A changed file is outside the allowed directories (src/, tests/, docs/, utils/), has a disallowed extension (only .py, .txt, .md permitted outside tests/ and docs/), or is not .md/.yml inside docs/ — this covers files the PR deletes or renames, not only the ones it edits
  • A new high-severity security issue was detected in the changed Python files (Bandit check)
  • The PR touches a path this repository protects from untrusted PRs, such as the file that decides who reviews it — a maintainer must make that change in a separate PR

See the workflow run for the exact violations.

A maintainer can review and manually approve CI if a finding is a false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue doing PEFT on Embedding Gemma w/ new classifier head

2 participants