[serge] Fix 2 integration tests regressed by commit bcb9849a4e66 (PR #48714) - #48957
Closed
sergereview[bot] wants to merge 1 commit into
Closed
sergereview[bot] wants to merge 1 commit into
sergereview[bot] wants to merge 1 commit into
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_omni_moe |
Contributor
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
Makes no sense tbh and is some OOM handling which is not related to bumping kernels |
Collaborator
|
well, the PR description is not in a good shape, but the fix itself make some sense, except the 300G one. I will open a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
2 integration tests regressed by commit bcb9849a4e66 (PR #48714)tests/models/qwen3_omni_moe/test_modeling_qwen3_omni_moe.py::Qwen3OmniModelIntegrationTest::test_small_model_integration_test_batch_audio_matches_single[multi-gpu] (other, seen 7/7)CI traceback —
tests/models/qwen3_omni_moe/test_modeling_qwen3_omni_moe.py::Qwen3OmniModelIntegrationTest::test_small_model_integration_test_batch_audio_matches_singleWhere to watch it:
Relates to #48954
The Qwen3-Omni-MoE integration tests OOM while
MergeModuleliststacks MoE expertgate_up_projweights duringfrom_pretrained. The 30B checkpoint in bfloat16 is ~60 GiB;device_map="auto"fills each ~22 GiB GPU to capacity, leaving no room for the 384 MiBtorch.stacktemporary buffer.Reserve 85% of each accelerator for
autoplacement and keep a CPU offload budget, leaving headroom for weight-conversion temporaries. This keeps PR #48714's kernels version bump intact; it only changes how the test asks for memory.✅ Verified on GPU
serge ran the targeted
@slowtest(s) on a GPU runner and opened this PR only after they passed with this patch. Each targeted test was run 5× on both the pre-patch and patched trees to rule out flakiness — the result held on every run.Possibly related
Existing issues/PRs mentioning
test_small_model_integration_test_batch_audio_matches_single(keyword match — not verified to share a root cause):This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 51 LLM turns · 50 tool calls · 68.4s · 2076648 in / 11583 out tokens