[serge] Fix 2 integration tests for model llava_next_video failing with other (other (2)) - #48955
Open
sergereview[bot] wants to merge 1 commit into
Open
sergereview[bot] wants to merge 1 commit into
sergereview[bot] wants to merge 1 commit into
Conversation
…with `other` (other (2))
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: llava_next_video |
Contributor
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
2 integration tests for modelllava_next_videofailing withother(other (2))tests/models/llava_next_video/test_modeling_llava_next_video.py::LlavaNextVideoForConditionalGenerationIntegrationTest::test_small_model_integration_test[multi-gpu] (other, seen 7/7)CI traceback —
tests/models/llava_next_video/test_modeling_llava_next_video.py::LlavaNextVideoForConditionalGenerationIntegrationTest::test_small_model_integration_testWhere to watch it:
The
llava_next_videosmall model integration test fails because the expected generated caption is stale after the recent torch 2.14 CI update (#48750). The model now produces a different, coherent caption on CUDA and XPU.Root cause: expected golden string in
test_small_model_integration_testno longer matches the deterministic generation output.Fix: update the
("cuda", None)and("xpu", None)expected values to the current generated text. The ROCm expectation is unchanged as it was not reported failing.Relates to #48954
This patch changes only expected values in test files — the assertions were rewritten, not the code under test.
The GPU run below is not evidence that this change is correct: the tests were re-run after the patch rewrote what they assert, so they pass by construction. Judge the new value on its merits.
Possibly related
Existing issues/PRs mentioning
test_small_model_integration_test(keyword match — not verified to share a root cause):This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 6 LLM turns · 5 tool calls · 5.6s · 89872 in / 860 out tokens