Conversation
paulinebm
merged commit Sep 21, 2026
c2d5bf6
into
dependabot/github_actions/actions-2436af7829
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated hardening of the workflow files flagged on #835.
Warning
This narrows what the workflow can reach. Job permissions were declared in
.github/workflows/build_kernel.yaml,.github/workflows/build_kernel_cpu.yaml,.github/workflows/build_kernel_macos.yaml,.github/workflows/build_kernel_rocm.yaml,.github/workflows/build_kernel_windows.yaml,.github/workflows/build_kernel_xpu.yaml,.github/workflows/check_variants.yaml,.github/workflows/lint.yml,.github/workflows/nix_checks.yml,.github/workflows/test_e2e.yaml,.github/workflows/test_extra_commands.yaml,.github/workflows/update_cache.yaml. Each job now gets only the scopes its steps were read to need — if one of them does something this could not see, it will fail on the next run. The table below says which step drove each scope.Targets
dependabot/github_actions/actions-2436af7829. Files changed, and what changed them:.github/workflows/build_kernel.yaml— action pins; job permissions.github/workflows/build_kernel_cpu.yaml— action pins; job permissions.github/workflows/build_kernel_macos.yaml— job permissions.github/workflows/build_kernel_rocm.yaml— action pins; job permissions.github/workflows/build_kernel_windows.yaml— job permissions.github/workflows/build_kernel_xpu.yaml— action pins; job permissions.github/workflows/check_variants.yaml— job permissions.github/workflows/lint.yml— job permissions.github/workflows/nix_checks.yml— action pins; job permissions.github/workflows/publish_kernels.yml— action pins.github/workflows/test_e2e.yaml— action pins; job permissions.github/workflows/test_extra_commands.yaml— action pins; job permissions.github/workflows/update_cache.yaml— action pins; job permissionsFixed by this PR:
unpinned-action(pinact) — .github/workflows/build_kernel.yaml:31unpinned-action(pinact) — .github/workflows/build_kernel_cpu.yaml:24unpinned-action(pinact) — .github/workflows/build_kernel_rocm.yaml:24unpinned-action(pinact) — .github/workflows/build_kernel_xpu.yaml:24unpinned-action(pinact) — .github/workflows/nix_checks.yml:24unpinned-action(pinact) — .github/workflows/publish_kernels.yml:251unpinned-action(pinact) — .github/workflows/publish_kernels.yml:323unpinned-action(pinact) — .github/workflows/test_e2e.yaml:37unpinned-action(pinact) — .github/workflows/test_extra_commands.yaml:23unpinned-action(pinact) — .github/workflows/update_cache.yaml:25excessive-permissions(zizmor) — .github/workflows/build_kernel.yaml:1excessive-permissions(zizmor) — .github/workflows/build_kernel.yaml:18excessive-permissions(zizmor) — .github/workflows/build_kernel.yaml:69excessive-permissions(zizmor) — .github/workflows/build_kernel_cpu.yaml:1excessive-permissions(zizmor) — .github/workflows/build_kernel_cpu.yaml:18excessive-permissions(zizmor) — .github/workflows/build_kernel_macos.yaml:1excessive-permissions(zizmor) — .github/workflows/build_kernel_macos.yaml:18excessive-permissions(zizmor) — .github/workflows/build_kernel_rocm.yaml:1excessive-permissions(zizmor) — .github/workflows/build_kernel_rocm.yaml:18excessive-permissions(zizmor) — .github/workflows/build_kernel_windows.yaml:1excessive-permissions(zizmor) — .github/workflows/build_kernel_windows.yaml:18excessive-permissions(zizmor) — .github/workflows/build_kernel_xpu.yaml:1excessive-permissions(zizmor) — .github/workflows/build_kernel_xpu.yaml:18excessive-permissions(zizmor) — .github/workflows/check_variants.yaml:1excessive-permissions(zizmor) — .github/workflows/check_variants.yaml:18excessive-permissions(zizmor) — .github/workflows/lint.yml:1excessive-permissions(zizmor) — .github/workflows/lint.yml:18excessive-permissions(zizmor) — .github/workflows/lint.yml:35excessive-permissions(zizmor) — .github/workflows/lint.yml:51excessive-permissions(zizmor) — .github/workflows/nix_checks.yml:1excessive-permissions(zizmor) — .github/workflows/nix_checks.yml:18excessive-permissions(zizmor) — .github/workflows/test_e2e.yaml:1excessive-permissions(zizmor) — .github/workflows/test_e2e.yaml:29excessive-permissions(zizmor) — .github/workflows/test_e2e.yaml:111excessive-permissions(zizmor) — .github/workflows/test_e2e.yaml:155excessive-permissions(zizmor) — .github/workflows/test_extra_commands.yaml:1excessive-permissions(zizmor) — .github/workflows/test_extra_commands.yaml:18excessive-permissions(zizmor) — .github/workflows/update_cache.yaml:1excessive-permissions(zizmor) — .github/workflows/update_cache.yaml:12This does not fix everything. 10 further finding(s) (2 critical, 1 high, 7 medium) need a decision this bot should not make for you. They are in the security channel with their locations — deliberately not repeated here, since this repository may be public and they are not fixed yet.
Permissions
.github/workflows/build_documentation.yaml.github/workflows/build_kernel.yamlbuildcontents: readtestcontents: read.github/workflows/build_kernel_cpu.yamlbuildcontents: read.github/workflows/build_kernel_macos.yamlbuildcontents: read.github/workflows/build_kernel_rocm.yamlbuildcontents: read.github/workflows/build_kernel_windows.yamlbuildcontents: read.github/workflows/build_kernel_xpu.yamlbuildcontents: readactions/checkoutneeds the token (contents: read); the nix-installer, cachix (authenticated via a secret, not the GITHUB_TOKEN) andnix buildsteps make no GitHub API writes..github/workflows/build_pr_documentation.yaml.github/workflows/check_variants.yamlbuildcontents: read.github/workflows/lint.ymllintcontents: readgriffecontents: readvalidate-dependenciescontents: read.github/workflows/nix_checks.ymlbuildcontents: readnix fmt/nix buildlocally, so no write scopes are needed..github/workflows/test_e2e.yamlinit-build-uploadcontents: readdownload-and-testcontents: readcleanup{}— nothing.github/workflows/test_extra_commands.yamlbuildcontents: read.github/workflows/test_kernels.yamlbuildcontents: read.github/workflows/update_cache.yamlbuildcontents: readnix buildjust builds locally..github/workflows/upload_pr_documentation.yamlAnything not listed above keeps the permissions it had. To measure a job this could not read, add
GitHubSecurityLab/actions-permissions/monitorto it and run the workflow — it reports the minimum the run actually used.Pinning changes come from
pinactand are mechanical. Any other change was generated by Claude — read it before merging.